Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

[EPIC] Upgrade to feathers 5.0.0 #7645

Closed
75 tasks done
Tracked by #8224
speigg opened this issue Feb 28, 2023 · 1 comment · Fixed by #7883 or #8044
Closed
75 tasks done
Tracked by #8224

[EPIC] Upgrade to feathers 5.0.0 #7645

speigg opened this issue Feb 28, 2023 · 1 comment · Fixed by #7883 or #8044
Assignees
Labels
Milestone

Comments

@speigg
Copy link
Member

speigg commented Feb 28, 2023

https://github.com/feathersjs/feathers/releases/tag/v5.0.0

Issues Found in Feathers Typing:

  • When querying find from client, if we pass pagination as false then it returns data in array. But if we pass pagination as undefined, then data is always retured as Paginated object though return typings show it to be either Paginated object or Array. Therefore, we have to explicitly parse the result to Paginated object.
  • When querying find from client, if we pass pagination as false then it returns data in array. We have to first convert that response to any and then to Array.
  • In authentication-setting service when we override patch method we have to convert object to strings before passing to super._patch method. Though as per typings, super._patch method expects them to be object.
@speigg speigg moved this to 4 Next up in Ethereal Engine Assignments Feb 28, 2023
@HexaField HexaField moved this from 4 Next up to 3 Current ToDo in Ethereal Engine Assignments Mar 3, 2023
@hanzlamateen hanzlamateen reopened this Apr 18, 2023
@hanzlamateen hanzlamateen reopened this Apr 18, 2023
@HexaField HexaField reopened this Jun 5, 2023
@HexaField HexaField added epic and removed story - 8 labels Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.