Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Changes for scene service to use schema, knex & feathers 5 #8826

Merged
merged 30 commits into from
Sep 28, 2023

Conversation

MoizAdnan
Copy link
Member

Summary

A summary of changes being made in this PR

References

#7645, closes #8743

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewer

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

@MoizAdnan MoizAdnan marked this pull request as ready for review September 25, 2023 21:52
Copy link
Member

@barankyle barankyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only issue I could see was that portals to other scenes didn't seem to be placing one's avatar in the right spot. When portalling from the apartment to sky-station, it was putting me in a corner of the first-floor interior instead of the apartment portal at the end of the starting platform.

@HexaField
Copy link
Member

The only issue I could see was that portals to other scenes didn't seem to be placing one's avatar in the right spot. When portalling from the apartment to sky-station, it was putting me in a corner of the first-floor interior instead of the apartment portal at the end of the starting platform.

this is a preexisting issue

@barankyle
Copy link
Member

The only issue I could see was that portals to other scenes didn't seem to be placing one's avatar in the right spot. When portalling from the apartment to sky-station, it was putting me in a corner of the first-floor interior instead of the apartment portal at the end of the starting platform.

this is a preexisting issue

Odd, because I went back to dev and the portal was placing me at the end of the platform. But if it's not a major concern then it seems good to merge in.

@speigg
Copy link
Member

speigg commented Sep 26, 2023

While we are here, we also need to move all the logic in the <service>.class.ts files into hooks. @MoizAdnan @hanzlamateen would it make sense to do this work in this PR, or save for a future PR?

@hanzlamateen hanzlamateen added this pull request to the merge queue Sep 28, 2023
Merged via the queue into dev with commit c96678c Sep 28, 2023
@hanzlamateen hanzlamateen deleted the scene-feathers5 branch September 28, 2023 02:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate scene service to feathers 5
5 participants