Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Changes for archiver, discord-bot-auth, oembed services to use schema, knex & feathers 5 #8875

Merged
merged 9 commits into from
Oct 2, 2023

Conversation

MoizAdnan
Copy link
Member

@MoizAdnan MoizAdnan commented Sep 22, 2023

Summary

🤖 Generated by Copilot at a50a95e

This pull request refactors the archiver and discord bot auth services to use schema files for defining the service paths and methods, and to use feathers-swagger for generating the service documentation. It also updates the file browser component and the archive-directory script to use the new archiver service interface. This improves code quality, consistency, and readability.

References

#7645

Explanation

🤖 Generated by Copilot at a50a95e

  • Define service paths and methods for archiver and discord bot auth services in archiver.schema.ts and discord-bot-auth.schema.ts files (link, link)
  • Implement ServiceInterface interface and use RootParams type for archiver and discord bot auth service classes in archiver.class.ts and discord-bot-auth.class.ts files (link, link, link, link, link)
  • Modify get method of archiver service class to accept NullableId and extract directory parameter from params object in archiver.class.ts file (link)
  • Declare variables as constants where possible in archiver.class.ts file (link, link)
  • Separate service documentation from service definition and use feathers-swagger module to generate documentation based on service options in archiver.docs.ts and discord-bot-auth.docs.ts files (link, link)
  • Rename service files and use constants and types from schema files to register services with app in archiver.ts and discord-bot-auth.ts files (link, link)
  • Update service imports in services.ts files (link, link)
  • Import archiverPath constant and pass directory parameter to archiver service calls in FileBrowserContentPanel.tsx and archive-directory.ts files (link, link, link, link)

🤖 Generated by Copilot at a50a95e

To document their services better
They added some schema and swagger
They renamed some files
And fixed some imports with style
And updated the archiver and DiscordBotAuth setter

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@MoizAdnan MoizAdnan marked this pull request as ready for review September 26, 2023 18:36
@MoizAdnan MoizAdnan changed the title Changes for archiver, discord-bot-auth services to use schema, knex & feathers 5 Changes for archiver, discord-bot-auth, oembed services to use schema, knex & feathers 5 Sep 28, 2023
@MoizAdnan MoizAdnan added this pull request to the merge queue Oct 2, 2023
Merged via the queue into dev with commit 7deeda0 Oct 2, 2023
@MoizAdnan MoizAdnan deleted the services-feathers5 branch October 2, 2023 03:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants