Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

replace studio assets pagination with infinite scroll #10756

Merged
merged 16 commits into from
Aug 7, 2024

Conversation

achen5671
Copy link
Contributor

@achen5671 achen5671 commented Jul 30, 2024

Summary

Introduce an InfiniteScroll component with a callback function to call the api whenever scroll bottom is reached.

Subtasks Checklist

Breaking Changes

References

https://tsu.atlassian.net/browse/IR-3337

QA Steps

2024-07-30.at.12.06.13.mp4

@aditya-mitra aditya-mitra changed the title studio: assets infinite scroll replace studio assets pagination with infinite scroll Jul 30, 2024
@aditya-mitra aditya-mitra removed their request for review July 30, 2024 06:44
Copy link
Member

@dinomut1 dinomut1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screencast from 07-30-2024 03:58:06 PM.webm
Missing a scroll bar to trigger onScrollBottom

@aditya-mitra
Copy link
Collaborator

fixed now

2024-08-01.at.20.02.58.mp4

@aditya-mitra aditya-mitra requested a review from dinomut1 August 2, 2024 12:16
@CITIZENDOT CITIZENDOT added this pull request to the merge queue Aug 7, 2024
Merged via the queue into dev with commit ebe790c Aug 7, 2024
25 checks passed
@CITIZENDOT CITIZENDOT deleted the ac-assets-infinite-scroll branch August 7, 2024 13:28
dinomut1 added a commit that referenced this pull request Aug 7, 2024
* Revert "Physics reactivity for collider component updates and order dependenc…" (#10876)

This reverts commit 33afb3b.

* fix collider reactivity (#10877)

* fix collider reactivity

* fix tests

* optimize

* fix duplicate new scene (#10880)

* rigidbody initialization quick fix (#10883)

* Upload drag drop files MT fix (#10881)

* Upload drag drop files MT fix

* Array length check

* LerpTransform from rigid body uses rigid body instead of scene entity (#10882)

* remove old workflows (#10886)

* fix rigidbody crash server (#10891)

* IR-3561: Magic Link template support for mobile and desktop  (#10889)

* feat: refactor magic link email template to support desktop and mobile
chore: layout template to reuse styles in other templates

* Fixed logo link

---------

Co-authored-by: Hanzla Mateen <hanzlamateen@live.com>

* Fixed bugs in instanceserver connections (#10887)

* Fixed bugs in instanceserver connections

There were still some bugs surrounding a client connecting to an
instanceserver if the instance record for that server no longer
existed. updateInstance needed to return false in that situation.

This still led to a situation where the client would be stuck trying
to authenticate forever. Added a step prior to authentication where
the client listens for a message with { instanceReady: true }, which
is sent by setupSocketFunctions. If the server isn't ready within
10 seconds, then it returns { instanceReady: false }, and the client
will do a new instanceserver provision and hopefully connect properly
this time.

* make eslint happy

---------

Co-authored-by: Josh Field <joshfield999@gmail.com>

* ignore hash when checking cache validity (#10900)

* apply proper offsets to select (#10799)

* apply proper offsets to select

* add x offset calculation

* fix offset in select

* match tooltip with figma design (#10690)

* match tooltip with figma design

* fix check-errors

* fix check errors

* match title background with figma

* fix check errors

* fix check errors

---------

Co-authored-by: Appaji <appaji12368@gmail.com>

* center and elipse long text (#10895)

* remove fixed height (#10899)

Co-authored-by: Aditya Mitra <55396651+aditya-mitra@users.noreply.github.com>

* replace studio assets pagination with infinite scroll (#10756)

* set up observer api

* add asset infinite scroll with observer api

* clean up

* fix categorie change

* remove table pagination code

* add infinite scroll in assets container

* keep calling api till element is in view

---------

Co-authored-by: aditya-mitra <55396651+aditya-mitra@users.noreply.github.com>

* studio: swap lit unlit title (#10818)

* swap lit unlit title

* flip lit and unlit icon

---------

Co-authored-by: Liam Broza <mrhegemon@users.noreply.github.com>

* studio: update asset tree to new design (#10817)

* update aseet tree bg and padding

* update h on desph

* padding

* some padding change

* assset height cleanup

* fix font size

* fix tolbar

* Restrict file name length to 64 characters (#10752)

* restrct file name to 64 characters

* bake length search into regex , remove unused regex

* remove comments

* ensure all models have loaded in the scene before marking scene as fully loaded (#10903)

Co-authored-by: lonedevr <102248647+AidanCaruso@users.noreply.github.com>

---------

Co-authored-by: Josh Field <joshfield999@gmail.com>
Co-authored-by: Michael Estes <michael@etherealengine.com>
Co-authored-by: Daniel Belmes <3631206+DanielBelmes@users.noreply.github.com>
Co-authored-by: lucas3900 <66710631+lucas3900@users.noreply.github.com>
Co-authored-by: Kyle Baran <kbaran@bitscoop.com>
Co-authored-by: José Galván <33644205+jose-galvan@users.noreply.github.com>
Co-authored-by: Hanzla Mateen <hanzlamateen@live.com>
Co-authored-by: Aditya Mitra <55396651+aditya-mitra@users.noreply.github.com>
Co-authored-by: Appaji <appaji12368@gmail.com>
Co-authored-by: Andy Chen <44120813+achen5671@users.noreply.github.com>
Co-authored-by: Liam Broza <mrhegemon@users.noreply.github.com>
Co-authored-by: Rahul Ghosh <ghoshr698@gmail.com>
Co-authored-by: lonedevr <102248647+AidanCaruso@users.noreply.github.com>
dinomut1 added a commit that referenced this pull request Aug 7, 2024
* dev to int (#10901)

* Revert "Physics reactivity for collider component updates and order dependenc…" (#10876)

This reverts commit 33afb3b.

* fix collider reactivity (#10877)

* fix collider reactivity

* fix tests

* optimize

* fix duplicate new scene (#10880)

* rigidbody initialization quick fix (#10883)

* Upload drag drop files MT fix (#10881)

* Upload drag drop files MT fix

* Array length check

* LerpTransform from rigid body uses rigid body instead of scene entity (#10882)

* remove old workflows (#10886)

* fix rigidbody crash server (#10891)

* IR-3561: Magic Link template support for mobile and desktop  (#10889)

* feat: refactor magic link email template to support desktop and mobile
chore: layout template to reuse styles in other templates

* Fixed logo link

---------

Co-authored-by: Hanzla Mateen <hanzlamateen@live.com>

* Fixed bugs in instanceserver connections (#10887)

* Fixed bugs in instanceserver connections

There were still some bugs surrounding a client connecting to an
instanceserver if the instance record for that server no longer
existed. updateInstance needed to return false in that situation.

This still led to a situation where the client would be stuck trying
to authenticate forever. Added a step prior to authentication where
the client listens for a message with { instanceReady: true }, which
is sent by setupSocketFunctions. If the server isn't ready within
10 seconds, then it returns { instanceReady: false }, and the client
will do a new instanceserver provision and hopefully connect properly
this time.

* make eslint happy

---------

Co-authored-by: Josh Field <joshfield999@gmail.com>

* ignore hash when checking cache validity (#10900)

---------

Co-authored-by: Josh Field <joshfield999@gmail.com>
Co-authored-by: Michael Estes <michael@etherealengine.com>
Co-authored-by: Daniel Belmes <3631206+DanielBelmes@users.noreply.github.com>
Co-authored-by: lucas3900 <66710631+lucas3900@users.noreply.github.com>
Co-authored-by: Kyle Baran <kbaran@bitscoop.com>
Co-authored-by: José Galván <33644205+jose-galvan@users.noreply.github.com>
Co-authored-by: Hanzla Mateen <hanzlamateen@live.com>

* dev to int: Fix scene loading (#10910)

* Revert "Physics reactivity for collider component updates and order dependenc…" (#10876)

This reverts commit 33afb3b.

* fix collider reactivity (#10877)

* fix collider reactivity

* fix tests

* optimize

* fix duplicate new scene (#10880)

* rigidbody initialization quick fix (#10883)

* Upload drag drop files MT fix (#10881)

* Upload drag drop files MT fix

* Array length check

* LerpTransform from rigid body uses rigid body instead of scene entity (#10882)

* remove old workflows (#10886)

* fix rigidbody crash server (#10891)

* IR-3561: Magic Link template support for mobile and desktop  (#10889)

* feat: refactor magic link email template to support desktop and mobile
chore: layout template to reuse styles in other templates

* Fixed logo link

---------

Co-authored-by: Hanzla Mateen <hanzlamateen@live.com>

* Fixed bugs in instanceserver connections (#10887)

* Fixed bugs in instanceserver connections

There were still some bugs surrounding a client connecting to an
instanceserver if the instance record for that server no longer
existed. updateInstance needed to return false in that situation.

This still led to a situation where the client would be stuck trying
to authenticate forever. Added a step prior to authentication where
the client listens for a message with { instanceReady: true }, which
is sent by setupSocketFunctions. If the server isn't ready within
10 seconds, then it returns { instanceReady: false }, and the client
will do a new instanceserver provision and hopefully connect properly
this time.

* make eslint happy

---------

Co-authored-by: Josh Field <joshfield999@gmail.com>

* ignore hash when checking cache validity (#10900)

* apply proper offsets to select (#10799)

* apply proper offsets to select

* add x offset calculation

* fix offset in select

* match tooltip with figma design (#10690)

* match tooltip with figma design

* fix check-errors

* fix check errors

* match title background with figma

* fix check errors

* fix check errors

---------

Co-authored-by: Appaji <appaji12368@gmail.com>

* center and elipse long text (#10895)

* remove fixed height (#10899)

Co-authored-by: Aditya Mitra <55396651+aditya-mitra@users.noreply.github.com>

* replace studio assets pagination with infinite scroll (#10756)

* set up observer api

* add asset infinite scroll with observer api

* clean up

* fix categorie change

* remove table pagination code

* add infinite scroll in assets container

* keep calling api till element is in view

---------

Co-authored-by: aditya-mitra <55396651+aditya-mitra@users.noreply.github.com>

* studio: swap lit unlit title (#10818)

* swap lit unlit title

* flip lit and unlit icon

---------

Co-authored-by: Liam Broza <mrhegemon@users.noreply.github.com>

* studio: update asset tree to new design (#10817)

* update aseet tree bg and padding

* update h on desph

* padding

* some padding change

* assset height cleanup

* fix font size

* fix tolbar

* Restrict file name length to 64 characters (#10752)

* restrct file name to 64 characters

* bake length search into regex , remove unused regex

* remove comments

* ensure all models have loaded in the scene before marking scene as fully loaded (#10903)

Co-authored-by: lonedevr <102248647+AidanCaruso@users.noreply.github.com>

---------

Co-authored-by: Josh Field <joshfield999@gmail.com>
Co-authored-by: Michael Estes <michael@etherealengine.com>
Co-authored-by: Daniel Belmes <3631206+DanielBelmes@users.noreply.github.com>
Co-authored-by: lucas3900 <66710631+lucas3900@users.noreply.github.com>
Co-authored-by: Kyle Baran <kbaran@bitscoop.com>
Co-authored-by: José Galván <33644205+jose-galvan@users.noreply.github.com>
Co-authored-by: Hanzla Mateen <hanzlamateen@live.com>
Co-authored-by: Aditya Mitra <55396651+aditya-mitra@users.noreply.github.com>
Co-authored-by: Appaji <appaji12368@gmail.com>
Co-authored-by: Andy Chen <44120813+achen5671@users.noreply.github.com>
Co-authored-by: Liam Broza <mrhegemon@users.noreply.github.com>
Co-authored-by: Rahul Ghosh <ghoshr698@gmail.com>
Co-authored-by: lonedevr <102248647+AidanCaruso@users.noreply.github.com>

---------

Co-authored-by: Josh Field <joshfield999@gmail.com>
Co-authored-by: Michael Estes <michael@etherealengine.com>
Co-authored-by: Daniel Belmes <3631206+DanielBelmes@users.noreply.github.com>
Co-authored-by: lucas3900 <66710631+lucas3900@users.noreply.github.com>
Co-authored-by: Kyle Baran <kbaran@bitscoop.com>
Co-authored-by: José Galván <33644205+jose-galvan@users.noreply.github.com>
Co-authored-by: Hanzla Mateen <hanzlamateen@live.com>
Co-authored-by: Aditya Mitra <55396651+aditya-mitra@users.noreply.github.com>
Co-authored-by: Appaji <appaji12368@gmail.com>
Co-authored-by: Andy Chen <44120813+achen5671@users.noreply.github.com>
Co-authored-by: Liam Broza <mrhegemon@users.noreply.github.com>
Co-authored-by: Rahul Ghosh <ghoshr698@gmail.com>
Co-authored-by: lonedevr <102248647+AidanCaruso@users.noreply.github.com>
dinomut1 added a commit that referenced this pull request Aug 7, 2024
* Dev to Int (#10892)

* Revert "Physics reactivity for collider component updates and order dependenc…" (#10876)

This reverts commit 33afb3b.

* fix collider reactivity (#10877)

* fix collider reactivity

* fix tests

* optimize

* fix duplicate new scene (#10880)

* rigidbody initialization quick fix (#10883)

* Upload drag drop files MT fix (#10881)

* Upload drag drop files MT fix

* Array length check

* LerpTransform from rigid body uses rigid body instead of scene entity (#10882)

* remove old workflows (#10886)

* fix rigidbody crash server (#10891)

---------

Co-authored-by: Josh Field <joshfield999@gmail.com>
Co-authored-by: Michael Estes <michael@etherealengine.com>
Co-authored-by: Daniel Belmes <3631206+DanielBelmes@users.noreply.github.com>
Co-authored-by: lucas3900 <66710631+lucas3900@users.noreply.github.com>

* pushing dev to int (#10896)

* Revert "Physics reactivity for collider component updates and order dependenc…" (#10876)

This reverts commit 33afb3b.

* fix collider reactivity (#10877)

* fix collider reactivity

* fix tests

* optimize

* fix duplicate new scene (#10880)

* rigidbody initialization quick fix (#10883)

* Upload drag drop files MT fix (#10881)

* Upload drag drop files MT fix

* Array length check

* LerpTransform from rigid body uses rigid body instead of scene entity (#10882)

* remove old workflows (#10886)

* fix rigidbody crash server (#10891)

* IR-3561: Magic Link template support for mobile and desktop  (#10889)

* feat: refactor magic link email template to support desktop and mobile
chore: layout template to reuse styles in other templates

* Fixed logo link

---------

Co-authored-by: Hanzla Mateen <hanzlamateen@live.com>

* Fixed bugs in instanceserver connections (#10887)

* Fixed bugs in instanceserver connections

There were still some bugs surrounding a client connecting to an
instanceserver if the instance record for that server no longer
existed. updateInstance needed to return false in that situation.

This still led to a situation where the client would be stuck trying
to authenticate forever. Added a step prior to authentication where
the client listens for a message with { instanceReady: true }, which
is sent by setupSocketFunctions. If the server isn't ready within
10 seconds, then it returns { instanceReady: false }, and the client
will do a new instanceserver provision and hopefully connect properly
this time.

* make eslint happy

---------

Co-authored-by: Josh Field <joshfield999@gmail.com>

---------

Co-authored-by: Josh Field <joshfield999@gmail.com>
Co-authored-by: Michael Estes <michael@etherealengine.com>
Co-authored-by: Daniel Belmes <3631206+DanielBelmes@users.noreply.github.com>
Co-authored-by: lucas3900 <66710631+lucas3900@users.noreply.github.com>
Co-authored-by: Kyle Baran <kbaran@bitscoop.com>
Co-authored-by: José Galván <33644205+jose-galvan@users.noreply.github.com>
Co-authored-by: Hanzla Mateen <hanzlamateen@live.com>

* dev to int (#10901) (#10902)

* Revert "Physics reactivity for collider component updates and order dependenc…" (#10876)

This reverts commit 33afb3b.

* fix collider reactivity (#10877)

* fix collider reactivity

* fix tests

* optimize

* fix duplicate new scene (#10880)

* rigidbody initialization quick fix (#10883)

* Upload drag drop files MT fix (#10881)

* Upload drag drop files MT fix

* Array length check

* LerpTransform from rigid body uses rigid body instead of scene entity (#10882)

* remove old workflows (#10886)

* fix rigidbody crash server (#10891)

* IR-3561: Magic Link template support for mobile and desktop  (#10889)

* feat: refactor magic link email template to support desktop and mobile
chore: layout template to reuse styles in other templates

* Fixed logo link

---------



* Fixed bugs in instanceserver connections (#10887)

* Fixed bugs in instanceserver connections

There were still some bugs surrounding a client connecting to an
instanceserver if the instance record for that server no longer
existed. updateInstance needed to return false in that situation.

This still led to a situation where the client would be stuck trying
to authenticate forever. Added a step prior to authentication where
the client listens for a message with { instanceReady: true }, which
is sent by setupSocketFunctions. If the server isn't ready within
10 seconds, then it returns { instanceReady: false }, and the client
will do a new instanceserver provision and hopefully connect properly
this time.

* make eslint happy

---------



* ignore hash when checking cache validity (#10900)

---------

Co-authored-by: Josh Field <joshfield999@gmail.com>
Co-authored-by: Michael Estes <michael@etherealengine.com>
Co-authored-by: Daniel Belmes <3631206+DanielBelmes@users.noreply.github.com>
Co-authored-by: lucas3900 <66710631+lucas3900@users.noreply.github.com>
Co-authored-by: Kyle Baran <kbaran@bitscoop.com>
Co-authored-by: José Galván <33644205+jose-galvan@users.noreply.github.com>
Co-authored-by: Hanzla Mateen <hanzlamateen@live.com>

* Int (#10911)

* dev to int (#10901)

* Revert "Physics reactivity for collider component updates and order dependenc…" (#10876)

This reverts commit 33afb3b.

* fix collider reactivity (#10877)

* fix collider reactivity

* fix tests

* optimize

* fix duplicate new scene (#10880)

* rigidbody initialization quick fix (#10883)

* Upload drag drop files MT fix (#10881)

* Upload drag drop files MT fix

* Array length check

* LerpTransform from rigid body uses rigid body instead of scene entity (#10882)

* remove old workflows (#10886)

* fix rigidbody crash server (#10891)

* IR-3561: Magic Link template support for mobile and desktop  (#10889)

* feat: refactor magic link email template to support desktop and mobile
chore: layout template to reuse styles in other templates

* Fixed logo link

---------

Co-authored-by: Hanzla Mateen <hanzlamateen@live.com>

* Fixed bugs in instanceserver connections (#10887)

* Fixed bugs in instanceserver connections

There were still some bugs surrounding a client connecting to an
instanceserver if the instance record for that server no longer
existed. updateInstance needed to return false in that situation.

This still led to a situation where the client would be stuck trying
to authenticate forever. Added a step prior to authentication where
the client listens for a message with { instanceReady: true }, which
is sent by setupSocketFunctions. If the server isn't ready within
10 seconds, then it returns { instanceReady: false }, and the client
will do a new instanceserver provision and hopefully connect properly
this time.

* make eslint happy

---------

Co-authored-by: Josh Field <joshfield999@gmail.com>

* ignore hash when checking cache validity (#10900)

---------

Co-authored-by: Josh Field <joshfield999@gmail.com>
Co-authored-by: Michael Estes <michael@etherealengine.com>
Co-authored-by: Daniel Belmes <3631206+DanielBelmes@users.noreply.github.com>
Co-authored-by: lucas3900 <66710631+lucas3900@users.noreply.github.com>
Co-authored-by: Kyle Baran <kbaran@bitscoop.com>
Co-authored-by: José Galván <33644205+jose-galvan@users.noreply.github.com>
Co-authored-by: Hanzla Mateen <hanzlamateen@live.com>

* dev to int: Fix scene loading (#10910)

* Revert "Physics reactivity for collider component updates and order dependenc…" (#10876)

This reverts commit 33afb3b.

* fix collider reactivity (#10877)

* fix collider reactivity

* fix tests

* optimize

* fix duplicate new scene (#10880)

* rigidbody initialization quick fix (#10883)

* Upload drag drop files MT fix (#10881)

* Upload drag drop files MT fix

* Array length check

* LerpTransform from rigid body uses rigid body instead of scene entity (#10882)

* remove old workflows (#10886)

* fix rigidbody crash server (#10891)

* IR-3561: Magic Link template support for mobile and desktop  (#10889)

* feat: refactor magic link email template to support desktop and mobile
chore: layout template to reuse styles in other templates

* Fixed logo link

---------

Co-authored-by: Hanzla Mateen <hanzlamateen@live.com>

* Fixed bugs in instanceserver connections (#10887)

* Fixed bugs in instanceserver connections

There were still some bugs surrounding a client connecting to an
instanceserver if the instance record for that server no longer
existed. updateInstance needed to return false in that situation.

This still led to a situation where the client would be stuck trying
to authenticate forever. Added a step prior to authentication where
the client listens for a message with { instanceReady: true }, which
is sent by setupSocketFunctions. If the server isn't ready within
10 seconds, then it returns { instanceReady: false }, and the client
will do a new instanceserver provision and hopefully connect properly
this time.

* make eslint happy

---------

Co-authored-by: Josh Field <joshfield999@gmail.com>

* ignore hash when checking cache validity (#10900)

* apply proper offsets to select (#10799)

* apply proper offsets to select

* add x offset calculation

* fix offset in select

* match tooltip with figma design (#10690)

* match tooltip with figma design

* fix check-errors

* fix check errors

* match title background with figma

* fix check errors

* fix check errors

---------

Co-authored-by: Appaji <appaji12368@gmail.com>

* center and elipse long text (#10895)

* remove fixed height (#10899)

Co-authored-by: Aditya Mitra <55396651+aditya-mitra@users.noreply.github.com>

* replace studio assets pagination with infinite scroll (#10756)

* set up observer api

* add asset infinite scroll with observer api

* clean up

* fix categorie change

* remove table pagination code

* add infinite scroll in assets container

* keep calling api till element is in view

---------

Co-authored-by: aditya-mitra <55396651+aditya-mitra@users.noreply.github.com>

* studio: swap lit unlit title (#10818)

* swap lit unlit title

* flip lit and unlit icon

---------

Co-authored-by: Liam Broza <mrhegemon@users.noreply.github.com>

* studio: update asset tree to new design (#10817)

* update aseet tree bg and padding

* update h on desph

* padding

* some padding change

* assset height cleanup

* fix font size

* fix tolbar

* Restrict file name length to 64 characters (#10752)

* restrct file name to 64 characters

* bake length search into regex , remove unused regex

* remove comments

* ensure all models have loaded in the scene before marking scene as fully loaded (#10903)

Co-authored-by: lonedevr <102248647+AidanCaruso@users.noreply.github.com>

---------

Co-authored-by: Josh Field <joshfield999@gmail.com>
Co-authored-by: Michael Estes <michael@etherealengine.com>
Co-authored-by: Daniel Belmes <3631206+DanielBelmes@users.noreply.github.com>
Co-authored-by: lucas3900 <66710631+lucas3900@users.noreply.github.com>
Co-authored-by: Kyle Baran <kbaran@bitscoop.com>
Co-authored-by: José Galván <33644205+jose-galvan@users.noreply.github.com>
Co-authored-by: Hanzla Mateen <hanzlamateen@live.com>
Co-authored-by: Aditya Mitra <55396651+aditya-mitra@users.noreply.github.com>
Co-authored-by: Appaji <appaji12368@gmail.com>
Co-authored-by: Andy Chen <44120813+achen5671@users.noreply.github.com>
Co-authored-by: Liam Broza <mrhegemon@users.noreply.github.com>
Co-authored-by: Rahul Ghosh <ghoshr698@gmail.com>
Co-authored-by: lonedevr <102248647+AidanCaruso@users.noreply.github.com>

---------

Co-authored-by: Josh Field <joshfield999@gmail.com>
Co-authored-by: Michael Estes <michael@etherealengine.com>
Co-authored-by: Daniel Belmes <3631206+DanielBelmes@users.noreply.github.com>
Co-authored-by: lucas3900 <66710631+lucas3900@users.noreply.github.com>
Co-authored-by: Kyle Baran <kbaran@bitscoop.com>
Co-authored-by: José Galván <33644205+jose-galvan@users.noreply.github.com>
Co-authored-by: Hanzla Mateen <hanzlamateen@live.com>
Co-authored-by: Aditya Mitra <55396651+aditya-mitra@users.noreply.github.com>
Co-authored-by: Appaji <appaji12368@gmail.com>
Co-authored-by: Andy Chen <44120813+achen5671@users.noreply.github.com>
Co-authored-by: Liam Broza <mrhegemon@users.noreply.github.com>
Co-authored-by: Rahul Ghosh <ghoshr698@gmail.com>
Co-authored-by: lonedevr <102248647+AidanCaruso@users.noreply.github.com>

---------

Co-authored-by: Kyle Baran <kbaran@bitscoop.com>
Co-authored-by: Josh Field <joshfield999@gmail.com>
Co-authored-by: Michael Estes <michael@etherealengine.com>
Co-authored-by: Daniel Belmes <3631206+DanielBelmes@users.noreply.github.com>
Co-authored-by: lucas3900 <66710631+lucas3900@users.noreply.github.com>
Co-authored-by: José Galván <33644205+jose-galvan@users.noreply.github.com>
Co-authored-by: Hanzla Mateen <hanzlamateen@live.com>
Co-authored-by: Aditya Mitra <55396651+aditya-mitra@users.noreply.github.com>
Co-authored-by: Appaji <appaji12368@gmail.com>
Co-authored-by: Andy Chen <44120813+achen5671@users.noreply.github.com>
Co-authored-by: Liam Broza <mrhegemon@users.noreply.github.com>
Co-authored-by: Rahul Ghosh <ghoshr698@gmail.com>
Co-authored-by: lonedevr <102248647+AidanCaruso@users.noreply.github.com>
@dinomut1
Copy link
Member

dinomut1 commented Aug 8, 2024

This is broken in several ways

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants