Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Changes for scope type service to use schema, knex & feathers 5 #8306

Merged
merged 6 commits into from
Jul 25, 2023

Conversation

hurairahmateen
Copy link
Member

@hurairahmateen hurairahmateen commented Jul 19, 2023

Summary

Please also merge the following PR with this one:
EtherealEngine/ee-bot#35

References

#7645, closes #8299

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewer

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

@hurairahmateen hurairahmateen added the documentation Improvements or additions to documentation label Jul 20, 2023
port: process.env.MYSQL_PORT ?? 3306,
dialect: 'mysql'
};
username: process.env.MYSQL_USER ?? 'server',

Check failure

Code scanning / CodeQL

Hard-coded credentials

The hard-coded value "server" is used as [user name](1).
@hurairahmateen hurairahmateen marked this pull request as ready for review July 20, 2023 12:24
@barankyle barankyle force-pushed the scope-type-feathers5 branch from e7cc91c to 3fdd6f9 Compare July 24, 2023 18:44
@hurairahmateen hurairahmateen added this pull request to the merge queue Jul 25, 2023
Merged via the queue into dev with commit 13b3d4b Jul 25, 2023
@hurairahmateen hurairahmateen deleted the scope-type-feathers5 branch July 25, 2023 05:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation verified-contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate scope-type service to feathers 5
2 participants