This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 0
Add button capture to camera input system #8918
Merged
DanielBelmes
merged 15 commits into
dev
from
8620-refactor-camera-input-systems-to-integrate-with-spatial-input-system
Oct 31, 2023
Merged
Add button capture to camera input system #8918
DanielBelmes
merged 15 commits into
dev
from
8620-refactor-camera-input-systems-to-integrate-with-spatial-input-system
Oct 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HexaField
suggested changes
Sep 28, 2023
Added similar UX to the grabbable component. When hovering over the link component text will appear saying "Click to follow link." It will also scale up to a limit depending how far you are from it. |
…te-with-spatial-input-system
speigg
suggested changes
Oct 3, 2023
…te-with-spatial-input-system
…te-with-spatial-input-system
HexaField
suggested changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
input flicks between xrui and object
…te-with-spatial-input-system
…te-with-spatial-input-system
HexaField
suggested changes
Oct 19, 2023
HexaField
approved these changes
Oct 23, 2023
…te-with-spatial-input-system
…te-with-spatial-input-system
DanielBelmes
deleted the
8620-refactor-camera-input-systems-to-integrate-with-spatial-input-system
branch
October 31, 2023 21:32
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated by Copilot at 9524c22
This pull request improves the camera and interaction system by allowing the user to switch between camera mode and interaction mode using input source buttons. It also fixes a bug where link entities could be activated by a captured input source. The main files affected are
CameraInputSystem.ts
,AvatarInputSystem.ts
, andLinkComponent.ts
.References
closes #insert number here
Explanation
🤖 Generated by Copilot at 9524c22
🤖 Generated by Copilot at 9524c22
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Checklist