Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When I am upgrading from 0.4.0 to 0.4.1 Lists do not show up anymore #82

Closed
surematu opened this issue Nov 24, 2022 · 4 comments
Closed
Labels
bug Something isn't working

Comments

@surematu
Copy link

Hello.
I'm sorry but I do not really know how to publish a issue in github, so please ask if any more information is needed.

What I do:
Run the code example for an advance document from the readme, also tried the exmaple where
Tried with .net 4.7.2, .net 5, .net 6 and .net 7. They all return the same issue.

Also tried the list code that was updated 18 days ago, where it describe some of the same issue, lists not appearing.
#62 Fix not saving list when save to Stream
OfficeIMO/OfficeIMO.Examples/Word/Lists/Lists.Create2.cs

Issue:
On version 0.4.0 tittles, lists and TOC appears like normal. When I run the code example after upgrading to 0.4, text from the list appears, but not the bulletpoint itself. The titles lacks formating. See picture bellow.

Picture:
image

@PrzemyslawKlys PrzemyslawKlys added the bug Something isn't working label Nov 24, 2022
@PrzemyslawKlys
Copy link
Member

It does seem broken. Could be related to change

@PrzemyslawKlys PrzemyslawKlys pinned this issue Nov 24, 2022
@PrzemyslawKlys
Copy link
Member

I can confirm this is related to change in #76. Rewerting whole class brings back numbering

image

@PrzemyslawKlys
Copy link
Member

Ok, so the issue is the order of run and paragraph properties does matter.

Proper order is:

  • paragraph contains paragraph properties and then it can have a run.

In the @rstm-sf PR the order is:

image

When it should be:

image

@PrzemyslawKlys
Copy link
Member

PrzemyslawKlys commented Nov 25, 2022

The PR fixes the issue, but we need to add more tests for cases like this,, to check order of paragraphs objects.

This can be visible if we open up XML and validate document.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants