-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VerifyTests #86
Add VerifyTests #86
Conversation
b268a57
to
5997d8e
Compare
1774830
to
90b70ad
Compare
@PrzemyslawKlys hello!
I decided to golden tests to make it easier to do refactoring https://youtu.be/wA7oJDyvn4c |
Ok. It's done Sorry for the delay, but I haven’t yet decided how to find the reason why the test breaks. But everything seems to be fine now (at least they passed several tests in a row). If the Also, I did not add all possible options to the tests. I think this is a good start |
Hi, Couple of questions:
I'm looking for number of line commits and it's 170k. If that has to happen with every change to library that seems like a lot of commits mostly because of .txt. I wonder if we're able to somehow solve it differently? Thank you, |
Do you mean end of file? The current file the config, think the IDE fixed it itself https://github.com/EvotecIT/OfficeIMO/blob/2cf68efae04b4917ea911923a7e450463b8d4eab/.editorconfig#L5C1-L5C21
Sorry, this is personal :) I can return it back. "GitIgnore for the studio" is more suitable for dense legacy...
It's possible, but I don't like how the tests are written. They assume that once launched, the application opens to view the result. This no longer looks like a unit test. In addition, there are no options (as far as I remember) that edit existing documents
It seems to me that this is true. Thus, we see all the changes that may affect with PR. The big change will be for new files. Well, now many tests have been added at once For example, look at this commit ca91747 It shows that new styles were added last year, as well as endnotes and footnotes. Also, there are changes to previously generated properties. I think this is a very clear representation of how the file will change after PR |
Huh? I think we only have that option in Examples, not Tests? And it's always set to False? Not sure I understand? |
Oops, my fail. But still, I don’t like that different approaches are mixed. If you want them to be in the same file/project, then I will delete them and add them to the existing ones |
It's fine, just trying to understand, that's all. |
I was just thinking it would mean for every new test, new file would be created as well, and that would lead to larger coverage, but maybe that's a bit too much and it's better to focus on directly those tests. |
Sorry, I didn't use azure devops as an administrator. Moreover, I did not generate badges for it. I think it’s worth returning back then (this table is not interesting for me :)) |
# Conflicts: # azure-pipelines-macos.yml
Hello @PrzemyslawKlys Are we going to merge this?) Here we can see how the document changed during hold time (the tests did not change) d4135d7 |
Yes, we need to commit to this. I've been putting this away a bit, procrastinating because I know that once I commit this, I will have one more step to take care of with each and every PR ;) |
Testsing with https://github.com/VerifyTests/Verify