-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix null iterator deref in printCsLensTypeByMetadata #1767
Conversation
I converted this to draft, because I would like to try adding the CodeQL query to our code scanning before merging this. |
Codecov Report
@@ Coverage Diff @@
## main #1767 +/- ##
==========================================
+ Coverage 67.29% 67.36% +0.06%
==========================================
Files 151 151
Lines 20799 20802 +3
==========================================
+ Hits 13997 14013 +16
+ Misses 6802 6789 -13
Continue to review full report at Codecov.
|
#1768 adds the CodeQL query. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohoh this was def. me who forgot those returns 🤦
Thanks for fixing this! 👍
57397be
to
033175e
Compare
I rebased onto main to rerun the CodeQL analysis now that #1768 is merged. |
Fixes: #1763
This is the same type of bug as I fixed in #1758, but it's in new code that only exists on the main branch. The new code was added in this commit.
The CodeQL query that I wrote would have found this bug too, so I am going to try adding it to our code scanning setup.