Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null iterator deref in printCsLensTypeByMetadata #1767

Merged
merged 2 commits into from
Jul 9, 2021

Conversation

kevinbackhouse
Copy link
Collaborator

Fixes: #1763

This is the same type of bug as I fixed in #1758, but it's in new code that only exists on the main branch. The new code was added in this commit.

The CodeQL query that I wrote would have found this bug too, so I am going to try adding it to our code scanning setup.

@kevinbackhouse kevinbackhouse marked this pull request as draft July 8, 2021 11:31
@kevinbackhouse
Copy link
Collaborator Author

kevinbackhouse commented Jul 8, 2021

I converted this to draft, because I would like to try adding the CodeQL query to our code scanning before merging this.

@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #1767 (033175e) into main (c7757d7) will increase coverage by 0.06%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1767      +/-   ##
==========================================
+ Coverage   67.29%   67.36%   +0.06%     
==========================================
  Files         151      151              
  Lines       20799    20802       +3     
==========================================
+ Hits        13997    14013      +16     
+ Misses       6802     6789      -13     
Impacted Files Coverage Δ
src/canonmn_int.cpp 74.61% <50.00%> (+4.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7757d7...033175e. Read the comment docs.

@kevinbackhouse
Copy link
Collaborator Author

#1768 adds the CodeQL query.

hassec
hassec previously approved these changes Jul 9, 2021
Copy link
Member

@hassec hassec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohoh this was def. me who forgot those returns 🤦

Thanks for fixing this! 👍

@kevinbackhouse
Copy link
Collaborator Author

I rebased onto main to rerun the CodeQL analysis now that #1768 is merged.

@kevinbackhouse kevinbackhouse marked this pull request as ready for review July 9, 2021 09:53
@kevinbackhouse kevinbackhouse merged commit 9284b58 into Exiv2:main Jul 9, 2021
@clanmills clanmills mentioned this pull request Aug 9, 2021
@kevinbackhouse kevinbackhouse added this to the v1.00 milestone Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segment fault on exiv2 -Pt
2 participants