&bytes[0] (std::vector) will crash if bytes has zero elements #1789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinbackhouse
added
forward-to-main
|
It turns out that the I added a third commit to skip this unittest for now, since it fails in release builds. We have done the same thing in other tests that use |
hassec
approved these changes
Jul 25, 2021
kevinbackhouse
added a commit
that referenced
this pull request
Jul 25, 2021
&bytes[0] (std::vector) will crash if bytes has zero elements (backport #1789)
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/Exiv2/exiv2/security/advisories/GHSA-g44w-q3vm-gwjq
&bytes[0]on line 500 causes an assertion failure ifcount == 0.On the main branch it will probably be better to fix this by using
bytes.data()like the TODO comment suggests.I looked for variants by removing this clause from the CodeQL query. The other results look like false positives to me, but most of them should probably also be replaced by
bytes.data()on main.