Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

&bytes[0] (std::vector) will crash if bytes has zero elements (backport #1789) #1798

Merged
merged 3 commits into from
Jul 25, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 25, 2021

This is an automatic backport of pull request #1789 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

@codecov
Copy link

codecov bot commented Jul 25, 2021

Codecov Report

Merging #1798 (3892634) into main (7251a96) will increase coverage by 0.00%.
The diff coverage is 85.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1798   +/-   ##
=======================================
  Coverage   67.58%   67.58%           
=======================================
  Files         151      151           
  Lines       20903    20904    +1     
=======================================
+ Hits        14127    14128    +1     
  Misses       6776     6776           
Impacted Files Coverage Δ
src/image.cpp 72.97% <85.71%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7251a96...3892634. Read the comment docs.

@kevinbackhouse kevinbackhouse merged commit 01b109e into main Jul 25, 2021
@mergify mergify bot deleted the mergify/bp/main/pr-1789 branch July 25, 2021 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants