Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

basicio: use fs::path in Impl #2800

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

basicio: use fs::path in Impl #2800

wants to merge 1 commit into from

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Oct 19, 2023

No description provided.

@ghost
Copy link

ghost commented Oct 19, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented Oct 19, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e8326ba) 63.89% compared to head (918247b) 63.89%.

Files Patch % Lines
src/basicio.cpp 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2800   +/-   ##
=======================================
  Coverage   63.89%   63.89%           
=======================================
  Files         103      103           
  Lines       22361    22362    +1     
  Branches    10861    10861           
=======================================
+ Hits        14288    14289    +1     
  Misses       5855     5855           
  Partials     2218     2218

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neheb neheb mentioned this pull request Oct 19, 2023
Open
@neheb
basicio: use fs::path in Impl
918247b 
Signed-off-by: Rosen Penev <rosenp@gmail.com>
AlynxZhou added a commit to AlynxZhou/ansel that referenced this pull request Dec 2, 2023
@AlynxZhou
CI: Manually build exiv2 0.27 for Windows package
c150e9e 
Exiv2 0.28 dropped the old `std::wstring` path and breaks non-ASCII path
handling in Windows. While recent Windows supports using UTF-8 as
locale, it might cause other issue.

Before actual fix in <Exiv2/exiv2#2800> getting
merged, we stick to exiv2 0.27 branch for Windows build.
AlynxZhou added a commit to AlynxZhou/ansel that referenced this pull request Dec 2, 2023
@AlynxZhou
CI: Manually build exiv2 0.27 for Windows package
bc89c9e 
Exiv2 0.28 dropped the old `std::wstring` path and breaks non-ASCII path
handling in Windows. While recent Windows supports using UTF-8 as
locale, it might cause other issue.

Before actual fix in <Exiv2/exiv2#2800> getting
merged, we stick to exiv2 0.27 branch for Windows build.
AlynxZhou added a commit to AlynxZhou/ansel that referenced this pull request Dec 2, 2023
@AlynxZhou
CI: Manually build exiv2 0.27 for Windows package
db36184 
Exiv2 0.28 dropped the old `std::wstring` path and breaks non-ASCII path
handling in Windows. While recent Windows supports using UTF-8 as
locale, it might cause other issue.

Before actual fix in <Exiv2/exiv2#2800> getting
merged, we stick to exiv2 0.27 branch for Windows build.
AlynxZhou added a commit to AlynxZhou/ansel that referenced this pull request Dec 2, 2023
@AlynxZhou
CI: Manually build exiv2 0.27 for Windows package
5a2a52c 
Exiv2 0.28 dropped the old `std::wstring` path and breaks non-ASCII path
handling in Windows. While recent Windows supports using UTF-8 as
locale, it might cause other issue.

Before actual fix in <Exiv2/exiv2#2800> getting
merged, we stick to exiv2 0.27 branch for Windows build.
AlynxZhou added a commit to AlynxZhou/ansel that referenced this pull request Dec 2, 2023
@AlynxZhou
CI: Manually build exiv2 0.27 for Windows package
4791936 
Exiv2 0.28 dropped the old `std::wstring` path and breaks non-ASCII path
handling in Windows. While recent Windows supports using UTF-8 as
locale, it might cause other issue.

Before actual fix in <Exiv2/exiv2#2800> getting
merged, we stick to exiv2 0.27 branch for Windows build.
@AlynxZhou AlynxZhou mentioned this pull request Dec 2, 2023
Closed
aurelienpierre pushed a commit to aurelienpierreeng/ansel that referenced this pull request Dec 2, 2023
@AlynxZhou @aurelienpierre
CI: Manually build exiv2 0.27 for Windows package
e12ba56 
Exiv2 0.28 dropped the old `std::wstring` path and breaks non-ASCII path
handling in Windows. While recent Windows supports using UTF-8 as
locale, it might cause other issue.

Before actual fix in <Exiv2/exiv2#2800> getting
merged, we stick to exiv2 0.27 branch for Windows build.
@kmilos
Copy link
Collaborator

kmilos commented Feb 14, 2024 •
edited
Loading

I guess we'll need to bump any future version/branch to 0.29 for this?

@neheb
Copy link
Collaborator Author

neheb commented May 5, 2024

this breaks API btw. const std::string& cannot be returned as fs::path is used. If I had to guess, it doesn't work without UTF8 either.

@kmilos kmilos mentioned this pull request Jul 4, 2024
Closed
@kmilos
Copy link
Collaborator

kmilos commented Oct 17, 2024

I think this is no longer desired (on main) after #2951?

Not sure what's to be done about 0.28.x though - either backport UTF-8 only from main to make that clear cut (and bump min Widows req), or someone has to restore wstring...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinbackhouse kevinbackhouse kevinbackhouse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neheb @kmilos @kevinbackhouse