Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more Exifdata? #231

Closed
audiomartin opened this issue Nov 27, 2023 · 14 comments
Closed

No more Exifdata? #231

audiomartin opened this issue Nov 27, 2023 · 14 comments
Labels
upstream A third-party library or dependency changed or deprecated its API, resulting in building problems

Comments

@audiomartin
Copy link

Hi there,

I do not see the information about aperture, focal length, etc. of my .cr3 files anymore.

Expected behavior

See relevant data. In some older version of Ansel this was possible (as far as I remember), usefull for corrections, Denoise, Lens Correction,...

Clipboard02
Clipboard01

System

Win10, i7-2600, Geforce GTX 1050ti
Ansel 6f72fc9

All the Best
audiomartin

@aurelienpierre
Copy link
Collaborator

Can you send an affected CR3 file ?

@audiomartin
Copy link
Author

Shure:
https://we.tl/t-yrqriblmUl

File is to big to upload on github.

m.

@aurelienpierre
Copy link
Collaborator

aurelienpierre commented Nov 29, 2023

I tried your file and I get an Exiv2 error. Are you sure your camera is supported by Exiv2 ?

@aurelienpierre
Copy link
Collaborator

Ok, I needed to rebuild Exiv with ISOBMFF support and it finally worked. Seems supported on Linux…

@audiomartin
Copy link
Author

Thanks for taking care!

Still the same with latest version bf804ef of Ansel on Win10.

#231 (comment)

It is an Eos R5, worked before up to now. With Pictures imported before version 6f72fc9 the Exifdata is still visible.

m.

@aurelienpierre
Copy link
Collaborator

Your last working version was built using mingw-w64-ucrt-x86_64-exiv2-0.28.1-1 and the new ones are built using mingw-w64-ucrt-x86_64-exiv2-0.28.1-2, so I guess something is wrong in the Win Exiv2 package

@audiomartin
Copy link
Author

There might be some hints for a developer, for me it is far beyond me knowledge:

https://github.com/darktable-org/darktable/issues/15478#issue-1959660414

and

https://github.com/Exiv2/exiv2/issues/2637#issue-1729310589

You probably already found it yourself.

m.

@aurelienpierre
Copy link
Collaborator

Also @AlynxZhou found this commit on MingW build script that drops explicit support of ISOBMFF in Exiv2, relying on whatever defaults the CMakeList.txt of the project is using.

@AlynxZhou
Copy link

@audiomartin Did you put your CR3 files in a path contains non-ASCII chars?

@audiomartin
Copy link
Author

YES!
For testing i made a folder without Umlaut, it works! All exif data is visible.
Great Guys. For the moment i will rename my folders without Umlaut.
Thanks for the hints.
m.

@aurelienpierre
Copy link
Collaborator

Bitte schön :D

@AlynxZhou
Copy link

YES! For testing i made a folder without Umlaut, it works! All exif data is visible. Great Guys. For the moment i will rename my folders without Umlaut. Thanks for the hints. m.

I'd like to have a look on how to fix it tomorrow, it's an Exiv2 issue, but I wish you could accept that as a workaround for you.

@aurelienpierre aurelienpierre added the upstream A third-party library or dependency changed or deprecated its API, resulting in building problems label Dec 1, 2023
@aurelienpierre aurelienpierre closed this as not planned Won't fix, can't repro, duplicate, stale Dec 1, 2023
@audiomartin
Copy link
Author

Danke schÖn.

@AlynxZhou
No problem, just have to remember dropping my äöü. :-)

@AlynxZhou
Copy link

OK, I managed to build exiv2 0.27 in our CI so the Windows package will grab it.

And I tested it on my Windows with my CR3 file (because I cannot download yours from the link), it shows EXIF data correctly:

图片

I suppose Exiv2/exiv2#2800 could actual fix this problem for exiv2 0.28, but before that gets merged, stick to exiv2 0.27 in our Windows package is acceptable for me, I'll send a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream A third-party library or dependency changed or deprecated its API, resulting in building problems
Projects
None yet
Development

No branches or pull requests

3 participants