Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix access to null pointer in TiffParser #706

Merged
merged 2 commits into from
Feb 26, 2019
Merged

Fix access to null pointer in TiffParser #706

merged 2 commits into from
Feb 26, 2019

Conversation

piponazo
Copy link
Collaborator

Fix for the second issue reported in #590.

te->pValue() could be 0x0 with the toc file provided by the user.

I did not add a test to reproduce the issue because I do not have much spare time lately, and I think the fix is obvious enough.

@piponazo piponazo added this to the v0.27.1 milestone Feb 12, 2019
@piponazo piponazo self-assigned this Feb 12, 2019
@piponazo piponazo requested review from clanmills and D4N February 12, 2019 21:40
@codecov
Copy link

codecov bot commented Feb 12, 2019

Codecov Report

Merging #706 into 0.27 will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             0.27     #706     +/-   ##
=========================================
+ Coverage   62.44%   62.55%   +0.1%     
=========================================
  Files         156      156             
  Lines       21507    21506      -1     
=========================================
+ Hits        13431    13453     +22     
+ Misses       8076     8053     -23
Impacted Files Coverage Δ
src/tiffimage_int.cpp 91.17% <100%> (+0.53%) ⬆️
src/tiffvisitor_int.cpp 87.31% <0%> (+1.36%) ⬆️
src/exiv2.cpp 69.45% <0%> (+1.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ec6aeb...a557c7f. Read the comment docs.

src/tiffimage_int.cpp Outdated Show resolved Hide resolved
src/tiffimage_int.cpp Outdated Show resolved Hide resolved
src/tiffimage_int.cpp Outdated Show resolved Hide resolved
@piponazo
Copy link
Collaborator Author

@tbeu if you are happy with the changes, could you approve? 😉

Copy link
Member

@D4N D4N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@piponazo
Copy link
Collaborator Author

@D4N Thanks to you for the test! Next time, just push me a bit for doing the testing. Sometimes it's difficult to keep the motivation to do the things right 😉

@piponazo piponazo merged commit 312a2d2 into Exiv2:0.27 Feb 26, 2019
@piponazo piponazo deleted the fix590_0.27 branch February 26, 2019 08:35
Copy link
Member

@tbeu tbeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok now.

piponazo added a commit that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants