-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix access to null pointer in TiffParser #706
Conversation
Codecov Report
@@ Coverage Diff @@
## 0.27 #706 +/- ##
=========================================
+ Coverage 62.44% 62.55% +0.1%
=========================================
Files 156 156
Lines 21507 21506 -1
=========================================
+ Hits 13431 13453 +22
+ Misses 8076 8053 -23
Continue to review full report at Codecov.
|
@tbeu if you are happy with the changes, could you approve? 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
@D4N Thanks to you for the test! Next time, just push me a bit for doing the testing. Sometimes it's difficult to keep the motivation to do the things right 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok now.
Automatic backport of pull request #706
Fix for the second issue reported in #590.
te->pValue()
could be0x0
with the toc file provided by the user.I did not add a test to reproduce the issue because I do not have much spare time lately, and I think the fix is obvious enough.