Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic backport of pull request #706 #717

Merged
merged 2 commits into from
Feb 28, 2019
Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 26, 2019

This is an automated backport of pull request #706 done by Mergify.io

@piponazo piponazo self-requested a review February 26, 2019 07:35
piponazo
piponazo previously approved these changes Feb 26, 2019
Copy link
Member

@D4N D4N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My commit is lacking my GPG signature. I'll fix the issues, just blocking the merging of this.

src/tiffimage_int.cpp Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 26, 2019

Codecov Report

Merging #717 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #717      +/-   ##
==========================================
+ Coverage   69.42%   69.54%   +0.11%     
==========================================
  Files         143      143              
  Lines       18981    18980       -1     
==========================================
+ Hits        13178    13200      +22     
+ Misses       5803     5780      -23
Impacted Files Coverage Δ
src/tiffimage_int.cpp 90.64% <100%> (+0.52%) ⬆️
src/tiffvisitor_int.cpp 87.34% <0%> (+1.39%) ⬆️
src/exiv2.cpp 70.71% <0%> (+1.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6707d1...4c94767. Read the comment docs.

@piponazo piponazo force-pushed the mergify/bp/master/pr-706 branch from f04dcdc to b2d9586 Compare February 27, 2019 18:11
@mergify mergify bot dismissed piponazo’s stale review February 27, 2019 18:11

Pull request has been modified.

@piponazo
Copy link
Collaborator

I just did the change of NULL to nullptr. I let you take care of your GPG signature and merging the PR 😉

@D4N D4N force-pushed the mergify/bp/master/pr-706 branch from b2d9586 to 4c94767 Compare February 27, 2019 22:06
@piponazo piponazo merged commit 177e20c into master Feb 28, 2019
@mergify mergify bot deleted the mergify/bp/master/pr-706 branch February 28, 2019 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants