build!: don't ship untranspiled code or commit transpiled code #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
RyanZim
force-pushed
the
ryan/build-package
branch
from
125b8c5 to
e6128b2
Compare
|
Rebased on #3; tests should pass now. |
fboucquez
reviewed
Nov 8, 2022
| "repository": { | ||
| "type": "git", | ||
| "url": "git+https://github.com/ExodusMovement/buffer-noise.git" | ||
| }, | ||
| "scripts": { | ||
| "build": "flow-remove-types ./src/index.js > ./lib/index.js", | ||
| "build": "make-dir lib && flow-remove-types ./src/index.js > ./lib/index.js", |
There was a problem hiding this comment.
If we are not shipping transpiling code, why are we building? Should lint be enough to detect any issue babel can detect? Can we remove babel? (if jest manage to run untranpiled code)
There are general questions, no just for this PR
ufff, missread the build. ignore this please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #3