Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: don't ship untranspiled code or commit transpiled code #4

Merged
merged 1 commit into from
Nov 8, 2022
Merged

build!: don't ship untranspiled code or commit transpiled code #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
lib/

# Logs
logs
*.log
Expand Down
17 changes: 0 additions & 17 deletions lib/index.js
View file
Open in desktop

This file was deleted.

7 changes: 6 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,17 @@
"license": "MIT",
"author": "Exodus Movement, Inc.",
"main": "./lib/index.js",
"files": [
"src/"
],
"repository": {
"type": "git",
"url": "git+https://github.com/ExodusMovement/buffer-noise.git"
},
"scripts": {
"build": "flow-remove-types ./src/index.js > ./lib/index.js",
"build": "make-dir lib && flow-remove-types ./src/index.js > ./lib/index.js",
Copy link

@fboucquez fboucquez Nov 8, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are not shipping transpiling code, why are we building? Should lint be enough to detect any issue babel can detect? Can we remove babel? (if jest manage to run untranpiled code)

There are general questions, no just for this PR

ufff, missread the build. ignore this please

"lint": "standard",
"prepare": "npm run build",
"pretest": "npm run build",
"test": "npm run lint && flow check && npm run unit",
"unit": "tape -r flow-remove-types/register ./test/index.js | tf-spec"
Expand All @@ -25,6 +29,7 @@
"babel-eslint": "^7.2.1",
"flow-bin": "^0.43.0",
"flow-remove-types": "^1.2.0",
"make-dir-cli": "^3.0.0",
"standard": "^10.0.0",
"tape": "^4.6.3"
},
Expand Down