-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #33225 from ikevin127/fix/33149
Desktop - Chat - Infinite loading displayed on selected chat when navigate to RHP with deeplink
- Loading branch information
Showing
3 changed files
with
22 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
import ROUTES from '@src/ROUTES'; | ||
|
||
export default function shouldSkipDeepLinkNavigation(route: string) { | ||
// When deep-linking to desktop app with `transition` route we don't want to call navigate | ||
// on the route because it will display an infinite loading indicator. | ||
// See issue: https://github.com/Expensify/App/issues/33149 | ||
if (route.includes(ROUTES.TRANSITION_BETWEEN_APPS)) { | ||
return true; | ||
} | ||
|
||
return false; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
// eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
export default function shouldSkipDeepLinkNavigation(route: string) { | ||
// no-op for all other platforms | ||
return false; | ||
} |