Desktop - Chat - Infinite loading displayed on selected chat when navigate to RHP with deeplink #33225

ikevin127 · 2023-12-18T13:10:44Z

Details

We make sure that the transition route passed from the main electron process (desktop app) is NOT called by the navigator once we are transitioned to the desktop app.

Fixed Issues

$ #33149
PROPOSAL: #33149 (comment)

Tests

Open http://staging.new.expensify.com in web browser and select any conversation in LHN
Navigate on http://staging.new.expensify.com/enable-payments
Click on "Allow" to open link the Desktop app
Click outside of the RHP to close it
Observe that there's no infinite loading spinner shown anymore

Verify that no errors appear in the JS console

QA Steps

Open http://staging.new.expensify.com in web browser and select any conversation in LHN
Navigate on http://staging.new.expensify.com/enable-payments
Click on "Allow" to open link the Desktop app
Click outside of the RHP to close it
Observe that there's no infinite loading spinner shown anymore

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2023-12-20.at.10.30.04.mov

Android: mWeb Chrome

android-mweb.mov

iOS: Native

Screen.Recording.2023-12-20.at.10.58.06.mov

iOS: mWeb Safari

Screen.Recording.2023-12-20.at.10.59.46.mov

MacOS: Chrome / Safari

Screen.Recording.2023-12-20.at.11.01.51.mov

MacOS: Desktop

Screen.Recording.2023-12-15.at.18.51.24.mov

melvin-bot · 2023-12-18T13:10:49Z

@narefyev91 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

narefyev91 · 2023-12-20T07:34:06Z

@ikevin127 can you please also add videos for other platforms - to be sure - that all of them running fine

narefyev91 · 2023-12-20T08:39:14Z

src/libs/actions/Report.ts

+                // When deep-linking to desktop app with `transition` route we don't want to call navigate
+                // on the route because it will display an infinite loading indicator.
+                // See issue: https://github.com/Expensify/App/issues/33149
+                if (getPlatform() === CONST.PLATFORM.DESKTOP && route.includes(ROUTES.TRANSITION_BETWEEN_APPS)) {


we should not use platform specific code
If you want to have something just only for desktop - you can create a function openReportFromDeepLink with .desktop.ts and index.ts - and use it in this file
ex. src/libs/getPlaidDesktopMessage

@narefyev91 Moved the logic to platform-dependent files:

@libs/actions/OpenReportFromDeepLink/index.ts

@libs/actions/OpenReportFromDeepLink/index.desktop.ts

they are located in @libs/actions/... because the openReportFromDeepLink function performs Onyx.set() which would throw lint error if placed in @libs/... because of the eslint rule:

eslint(rulesdir/prefer-actions-set-data)

_

I also added videos for all platforms as discussed.

Yup seems too many same logic goes in files
Can we just extract if (route.includes(ROUTES.TRANSITION_BETWEEN_APPS)) this for a specific function nameOfFunction.desktop.ts? and all other code will stay at it is? @ikevin127

@narefyev91 Sure, I think this way is better because there's no duplicated logic.
I created an action that checks if shouldSkipDeepLinkNavigation, platform-dependent:

@libs/shouldSkipDeepLinkNavigation/index.desktop.ts (implementation logic)

@libs/shouldSkipDeepLinkNavigation/index.ts (no-op, returns false)

Let me know if this needs any other changes!

…igate to RHP with deeplink

narefyev91 · 2023-12-20T11:06:59Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

8mb.video-ACm-FxfhX2n3.mp4

iOS

Android

narefyev91

LGTM!
🎀 👀 🎀 C+ reviewed

lakchote · 2023-12-20T13:08:24Z

LGTM 👍

OSBotify · 2023-12-20T13:13:11Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-21T05:31:32Z

🚀 Deployed to staging by https://github.com/lakchote in version: 1.4.15-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-12-22T05:20:15Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.4.15-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

ikevin127 requested a review from a team as a code owner December 18, 2023 13:10

melvin-bot bot requested review from narefyev91 and removed request for a team December 18, 2023 13:10

ikevin127 mentioned this pull request Dec 18, 2023

[HOLD for payment 2023-12-29] [$500] Desktop - Chat - Infinite loading displayed on selected chat when navigate to RHP with deeplink #33149

Closed

6 tasks

ikevin127 force-pushed the fix/33149 branch from 0018312 to 6666b1d Compare December 20, 2023 08:13

narefyev91 reviewed Dec 20, 2023

View reviewed changes

ikevin127 force-pushed the fix/33149 branch from 6666b1d to 9499d69 Compare December 20, 2023 09:41

Desktop - Chat - Infinite loading displayed on selected chat when nav…

3ac5af2

…igate to RHP with deeplink

ikevin127 force-pushed the fix/33149 branch from 9499d69 to 3ac5af2 Compare December 20, 2023 10:34

narefyev91 approved these changes Dec 20, 2023

View reviewed changes

melvin-bot bot requested a review from lakchote December 20, 2023 11:07

lakchote approved these changes Dec 20, 2023

View reviewed changes

lakchote merged commit 9ea6b39 into Expensify:main Dec 20, 2023
16 of 17 checks passed

github-actions bot mentioned this pull request Dec 21, 2023

Deploy Checklist: New Expensify 2023-12-21 #33391

Closed

51 tasks

rayane-djouah mentioned this pull request May 12, 2024

[HOLD for payment 2024-06-11] [$250] Android - Login - While login android app, a blank page slightly opens and closes #41333

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Desktop - Chat - Infinite loading displayed on selected chat when navigate to RHP with deeplink #33225

Desktop - Chat - Infinite loading displayed on selected chat when navigate to RHP with deeplink #33225

ikevin127 commented Dec 18, 2023 •

edited

Loading

melvin-bot bot commented Dec 18, 2023

narefyev91 commented Dec 20, 2023

narefyev91 Dec 20, 2023

ikevin127 Dec 20, 2023

narefyev91 Dec 20, 2023 •

edited

Loading

ikevin127 Dec 20, 2023

narefyev91 commented Dec 20, 2023

narefyev91 left a comment

lakchote commented Dec 20, 2023

OSBotify commented Dec 20, 2023

OSBotify commented Dec 21, 2023

OSBotify commented Dec 22, 2023

Desktop - Chat - Infinite loading displayed on selected chat when navigate to RHP with deeplink #33225

Desktop - Chat - Infinite loading displayed on selected chat when navigate to RHP with deeplink #33225

Conversation

ikevin127 commented Dec 18, 2023 • edited Loading

Details

Fixed Issues

Tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 18, 2023

narefyev91 commented Dec 20, 2023

narefyev91 Dec 20, 2023

Choose a reason for hiding this comment

ikevin127 Dec 20, 2023

Choose a reason for hiding this comment

narefyev91 Dec 20, 2023 • edited Loading

Choose a reason for hiding this comment

ikevin127 Dec 20, 2023

Choose a reason for hiding this comment

narefyev91 commented Dec 20, 2023

Reviewer Checklist

Screenshots/Videos

narefyev91 left a comment

Choose a reason for hiding this comment

lakchote commented Dec 20, 2023

OSBotify commented Dec 20, 2023

OSBotify commented Dec 21, 2023

OSBotify commented Dec 22, 2023

ikevin127 commented Dec 18, 2023 •

edited

Loading

narefyev91 Dec 20, 2023 •

edited

Loading