Merge pull request #2146 from Expensify/marcaaron-fixPropTypeWarnings

[No QA] Fix various propType warnings
Expensify · Mar 30, 2021 · bbbe320 · bbbe320
2 parents a192daf + 5554180
commit bbbe320
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/src/components/Tooltip/index.native.js b/src/components/Tooltip/index.native.js
@@ -1,6 +1,10 @@
+import PropTypes from 'prop-types';
+
 // We can't use the common component for the Tooltip as Web implementation uses DOM specific method to
 // render the View which is not present on the Mobile.
-import {propTypes, defaultProps} from './TooltipPropTypes';
+const propTypes = {
+    children: PropTypes.element,
+};
 
 /**
  * There is no native support for the Hover on the Mobile platform so we just return the enclosing childrens
@@ -10,6 +14,5 @@ import {propTypes, defaultProps} from './TooltipPropTypes';
 const Tooltip = props => props.children;
 
 Tooltip.propTypes = propTypes;
-Tooltip.defaultProps = defaultProps;
 Tooltip.displayName = 'Tooltip';
 export default Tooltip;
diff --git a/src/pages/home/ReportScreen.js b/src/pages/home/ReportScreen.js
@@ -16,7 +16,7 @@ const propTypes = {
 };
 
 const defaultProps = {
-    currentlyViewedReportID: 0,
+    currentlyViewedReportID: '0',
 };
 
 const ReportScreen = (props) => {

diff --git a/src/pages/home/sidebar/OptionRow.js b/src/pages/home/sidebar/OptionRow.js
@@ -130,12 +130,12 @@ const OptionRow = ({
                                         avatarImageURLs={option.icons}
                                         optionIsFocused={optionIsFocused}
                                         size={mode === 'compact' ? 'small' : 'default'}
-                                        styles={hovered && !optionIsFocused && {
+                                        styles={(hovered && !optionIsFocused) ? {
                                             secondAvatar: {
                                                 backgroundColor: themeColors.sidebarHover,
                                                 borderColor: themeColors.sidebarHover,
                                             },
-                                        }}
+                                        } : undefined}
                                     />
                                 )
                             }

diff --git a/src/styles/styles.js b/src/styles/styles.js
@@ -242,7 +242,6 @@ const styles = {
         color: themeColors.textReversed,
         fontSize: variables.fontSizeSmall,
         lineHeight: 16,
-        userSelect: 'none',
         ...whiteSpace.noWrap,
     },