[No QA] Fix various propType warnings #2146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomatoToaster
approved these changes
Mar 30, 2021
|
I think this looks good, just asked @Jag96 to double check me though. |
Jag96
reviewed
Mar 30, 2021
| secondAvatar: { | ||
| backgroundColor: themeColors.sidebarHover, | ||
| borderColor: themeColors.sidebarHover, | ||
| }, | ||
| }} | ||
| } : undefined} |
There was a problem hiding this comment.
Just wondering, what was the warning here? Having undefined here seems less clean
There was a problem hiding this comment.
We're validating that an Object is being passed, but using a short circuit so the order of operations will literally end up returning false. I guess another (perhaps more clear) way to do this would be
styles={(hovered && !optionIsFocused && styles.someStyle) || {}}There was a problem hiding this comment.
also asked Rajat to fix this up in another PR
Jag96
approved these changes
Mar 30, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
Fixes No Issue just many propTypes warnings making it hard to debug mobile
Tests / QA Steps
No QA
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android