[HOLD for payment 2022-10-20] [$250] Web - Reimbursable expense - The tooltip text doesn't change to copied @Puneet-here

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com
2. Go to settings > workspace
3. Reimburse page
4. Hover over clipboard icon
5. Tap on it

Expected Result:

The tooltip should change to copied like it does at other places

Actual Result:

The tooltip doesn't change

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.2.9.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.1268.mp4

Expensify/Expensify Issue URL:

Issue reported by: @Puneet-here

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1663268751574339

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @muttmuure (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[gadhiyamanan]

Proposal
replace text={this.props.translate('reportActionContextMenu.copyToClipboard')} with
text={ this.state.showCheckmark ? this.props.translate('reportActionContextMenu.copied') : this.props.translate('reportActionContextMenu.copyToClipboard') } to the below code

App/src/components/CopyTextToClipboard.js

Line 62 in 60d933e

<Tooltip text={this.props.translate('reportActionContextMenu.copyToClipboard')}>

After Fix

Screen.Recording.2022-09-29.at.11.34.16.PM.mov

[melvin-bot]

@muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[muttmuure]

Reproduced on my workspace. Seems like standardized behavior we want everywhere.

[arosiclair]

Also reproduced on staging and also in dev. Marking external.

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[melvin-bot]

Triggered auto assignment to @Gonals (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[jayeshmangwani]

Proposal

we need to add copied text when showCheckMark is enabled

-<Tooltip text={this.props.translate('reportActionContextMenu.copyToClipboard')}>
+<Tooltip text={this.state.showCheckmark ? this.props.translate('reportActionContextMenu.copied'):this.props.translate('reportActionContextMenu.copyToClipboard')}>

[Christinadobrzyn]

Eng confirmed this issue isn't a dupe of #9233 so creating a new job in Upwork.

Internal job posting: https://www.upwork.com/ab/applicants/1577536989593255936/job-details
External job posting: https://www.upwork.com/jobs/~01fdadeeba74809569

[melvin-bot]

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[eVoloshchak]

@jayeshmangwani, your proposal is identical to @gadhiyamanan's proposal

[eVoloshchak]

@gadhiyamanan's proposal looks great and works as expected

cc: @Gonals
🎀👀🎀 C+ reviewed!

[Gonals]

@gadhiyamanan's proposal looks good to me! Assigning you to the issue. Feel free to go ahead and create a PR

[melvin-bot]

📣 @gadhiyamanan You have been assigned to this job by @Gonals!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[gadhiyamanan]

@eVoloshchak PR raised

[Christinadobrzyn]

Hired @gadhiyamanan for the fix, @eVoloshchak as C+, and @Puneet-here as the reporter

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.13-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix tooltip text doesn't change to copied #11663

If no regressions arise, payment will be issued on 2022-10-20. 🎊

[Christinadobrzyn]

Paid!

$250 @gadhiyamanan for the fix
$250 @eVoloshchak as C+
$250 @Puneet-here as the reporter

Closed the job in Upwork and closing this GH.