[HOLD for payment 2022-10-05] [$250] Tapping on receipts@expensify.com email hides the clipboard icon next to it - reported by @aswin-s

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to workspace settings.
2. Tap on reimburse expense menu and tap on receipts@expensify.com link below Capture receipts section
3. Notice that the clipboard icon next to the email gets hidden and the check mark icon is not shown.

Expected Result:

Clipboard icon gets replaced with a check mark icon indicating email has successfully been copied to clipboard.

Actual Result:

Tapping on receipts@expensify.com email hides the clipboard icon next to it.

Workaround:

unknown

Platform:

Where is this issue occurring?

• iOS

Version Number: 1.169-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Record_2022-04-25-18-58-45_4f9154176b47c00da84e32064abf1c48.mp4

Expensify/Expensify Issue URL:
Issue reported by: @aswin-s
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1650894949713889

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @zanyrenney (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[thesahindia]

I couldn't repro this on Android and on ios when I tap on receipts@expensify.com the app crashes.

Screen.Recording.2022-05-31.at.6.37.22.PM.mov

[melvin-bot]

Whoops! This issue is 2 days overdue. Let's get this updated quick!

[thesahindia]

@zanyrenney, no one is assigned here.

[melvin-bot]

Still overdue 6 days?! Let's take care of this!

[melvin-bot]

8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

12 days overdue. Walking. Toward. The. Light...

[melvin-bot]

12 days overdue now... This issue's end is nigh!

[melvin-bot]

This issue has not been updated in over 14 days. eroding to Weekly issue.

[melvin-bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[dhairyasenjaliya]

Proposal

• We need to replace the <Text> component with <TouchableOpacity> as we need to have an onPress event on the component in order a copy email to the clipboard
• onPress on <Text> works as excepted on all the other platforms except the iOS app

App/src/components/CopyTextToClipboard.js

Lines 56 to 70 in d037a99

	<Text
	onPress={this.copyToClipboard}
	style={[styles.flexRow, styles.cursorPointer]}
	>
	<Text style={this.props.textStyles}>{this.props.text}</Text>
	<Tooltip text={this.props.translate('reportActionContextMenu.copyToClipboard')}>
	<Icon
	src={this.state.showCheckmark ? Expensicons.Checkmark : Expensicons.Clipboard}
	fill={this.state.showCheckmark ? themeColors.iconSuccessFill : themeColors.icon}
	width={variables.iconSizeSmall}
	height={variables.iconSizeSmall}
	inline
	/>
	</Tooltip>
	</Text>

Results

iOS App

iOS-App.mp4

Mobile Safari

mSafari.mp4

Chrome Web

chromeWeb.mov

Safari Web

safariWeb.mov

[dhairyasenjaliya]

@mvtglobally this issue is not assigned to anyone can we have a reviewer here?

[melvin-bot]

Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Still overdue 6 days?! Let's take care of this!

[melvin-bot]

10 days overdue. I'm getting more depressed than Marvin.

[melvin-bot]

12 days overdue now... This issue's end is nigh!

[dhairyasenjaliya]

@mananjadhav have you taken a look at my first proposal here #9233 (comment)
or which analysis/workaround do you agree on #9233 (comment)

[mananjadhav]

have you taken a look at my first proposal here

@dhairyasenjaliya I did, and I agreed with @aimane-chnaif's analysis.

I don't recommend wrapping TouchableOpacity inside a Text and it generally causes problems with styling, wrapping of texts, etc. Additionally, this issue is only in iOS and I've used supressedHighlighting with 0 side effects. Another way to achieve this is to use Pressable which really requires us to rewrite multiple things, so I wouldn't recommend that either.

[dhairyasenjaliya]

alright, I was just confirming thank you @mananjadhav

[kadiealexander]

@roryabraham happy to proceed here?

[melvin-bot]

📣 @aimane-chnaif You have been assigned to this job by @roryabraham!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

@mananjadhav, @roryabraham, @kadiealexander, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[roryabraham]

PR merged

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.8-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix "Tapping on receipts@expensify.com email hides the clipboard icon next to it" #11253

If no regressions arise, payment will be issued on 2022-10-05. 🎊

[melvin-bot]

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[mananjadhav]

@kadiealexander Quick bump on the upwork

[kadiealexander]

@mananjadhav @roryabraham could you please confirm this PR isn't linked to a regression?

[mananjadhav]

@kadiealexander I can confirm this isn't linked to the regression. Regression comment by the bot was due to this comment #11430 (comment)

[kadiealexander]

Sorry team, I didn't realise an Upwork post never got created for this job. I've sent everyone a contract, please let me know once it's accepted and I'll issue payment.
https://www.upwork.com/ab/applicants/1578236341784473600/job-details
https://www.upwork.com/jobs/~01f99f997919d5ab90

[kadiealexander]

Manan and Aswin have been paid! Thanks to you both.

[kadiealexander]

Everyone is paid!