[HOLD for payment 2022-12-05] mWeb- The Payment option is hidden after selecting one of the payment option

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with HT account (A) in wWeb/safari
3. Log in with different account (B) in Web and request money from Account A
4. Back to Account A in mWeb/safari
5. Select Pay button
6. Choose the option from drop down

Expected Result:

The Payment option should be visible after selecting one of the payment option

Actual Result:

The Payment option is hidden after selecting one of the payment option

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Mobile Web/Safari ONLY

Version Number: 1.2.31.5

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5835144_RPReplay_Final1669308376__1_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[luacmartins]

I can reproduce this, but it's also present in prod so I'll remove the deploy blocker label. I'll still look into a fix for the top scroll after selection.

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[luacmartins]

I'll investigate this week

[Puneet-here]

Same bug as #13011 (notice that the whole screen scrolls)

[luacmartins]

Revert was deployed. Closing issue.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.32-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert "refactor navigation modal card styles" #13014

If no regressions arise, payment will be issued on 2022-12-05. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@luacmartins] The PR that introduced the bug has been identified. Link to the PR: refactor navigation modal card styles #12366
• [@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Revert "refactor navigation modal card styles" #13014 (comment)
• [@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: discussion the reverting PR
• [@trjExpensify] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:

[trjExpensify]

@luacmartins confirming we have nothing to do here, right?

[luacmartins]

@trjExpensify Should I still fill the checklist in this case?

[trjExpensify]

Sorry, by "do", I meant payments etc. 😅 Yeah, let's still fill out the applicable items on the checklist where relevant.

[luacmartins]

Ah yea, no payments.

[trjExpensify]

Cool, so wrt to a regression test for this. I don't think it's required for a mWeb-only issue, would you agree?

[luacmartins]

I think that's fine and not seeing the button (like it happened here) will prevent the agent from going through with the flow. So I think we are good!