Revert "refactor navigation modal card styles" #13014

luacmartins · 2022-11-24T19:46:00Z

Details

Straight revert of #12366 since it caused a few regressions:

[HOLD for payment 2022-12-05] mWeb/Chrome - Split - Next button is missing when you split bill with participants #13011
[HOLD for payment 2022-12-05] mWeb- The Payment option is hidden after selecting one of the payment option #13009
[HOLD for payment 2022-12-05] [Performance] Mweb/safari - User can't tap participants in split bill on High Traffic Account. #13008

Thanks @Puneet-here for the investigation!

cc @aimane-chnaif @mananjadhav @marcochavezf

Fixed Issues

$ #13011
$ #13009
$ #13008

Tests

Sign in on mWeb
Tap on + > Split Bill > Proceed until you have to select the participants
Try and tap on the selected participants
Verify that you can select participants
Verify selecting participants makes the Next button
Log in with different account (B) in Web and request money from Account A
Back to Account A in mWeb
Select Pay button
Choose the option from drop down
Verify that the page doesn't scroll and the Pay button is sticky on the bottom

Verify that no errors appear in the JS console

QA Steps

Same as test steps

Verify that no errors appear in the JS console

PR Author Checklist

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

Screenshots

Web

web.mov

Mobile Web - Chrome

chrome.mov

Mobile Web - Safari

safari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

github-actions · 2022-11-24T20:01:46Z

⚠️ ⚠️ Heads up! This pull request has the CP Staging label ⚠️ ⚠️
If you applied the CP Staging label before the PR was merged, the PR will be be immediately deployed to staging even if the open StagingDeployCash deploy checklist is locked.
However if you applied the CP Staging after the PR was merged it's possible it won't be CP'ed automatically. If you need it to be CP'ed to staging, tag a member of @Expensify/mobile-deployers to CP it manually, otherwise you can wait for it to go out with the next deploy.

melvin-bot · 2022-11-24T20:04:51Z

@mollfpr @marcochavezf One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aimane-chnaif

Files changes for revert looks good to me. It exactly reverts what I did in #12366

marcochavezf · 2022-11-24T20:11:19Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

marcochavezf

LGTM, I'm having issues testing it on mWeb but approving it since @aimane-chnaif and @Puneet-here already confirmed the revert fixes the issues.

melvin-bot · 2022-11-24T20:46:05Z

@marcochavezf looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

marcochavezf · 2022-11-24T20:47:15Z

The tests already passed.

Revert "refactor navigation modal card styles" (cherry picked from commit c1cc42a)

…-13014 🍒 Cherry pick PR #13014 to staging 🍒

OSBotify · 2022-11-24T21:58:20Z

🚀 Cherry-picked to staging by @marcochavezf in version: 1.2.31-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

luacmartins · 2022-12-06T17:40:19Z

The production deploy comment failed for this PR, but this was deployed to production on v1.2.32-2 on Nov 28.

OSBotify · 2023-06-15T01:40:34Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-06-16T18:58:19Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Revert "refactor navigation modal card styles"

6b8b57a

luacmartins self-assigned this Nov 24, 2022

luacmartins added the CP Staging label Nov 24, 2022

luacmartins marked this pull request as ready for review November 24, 2022 20:04

luacmartins requested a review from a team as a code owner November 24, 2022 20:04

melvin-bot bot requested review from marcochavezf and mollfpr and removed request for a team November 24, 2022 20:04

aimane-chnaif approved these changes Nov 24, 2022

View reviewed changes

marcochavezf approved these changes Nov 24, 2022

View reviewed changes

marcochavezf merged commit c1cc42a into main Nov 24, 2022

marcochavezf deleted the revert-12366-fix-11336 branch November 24, 2022 20:46

melvin-bot bot added the Emergency label Nov 24, 2022

marcochavezf removed the Emergency label Nov 24, 2022

OSBotify pushed a commit that referenced this pull request Nov 24, 2022

Merge pull request #13014 from Expensify/revert-12366-fix-11336

2d3199e

Revert "refactor navigation modal card styles" (cherry picked from commit c1cc42a)

OSBotify mentioned this pull request Nov 24, 2022

🍒 Cherry pick PR #13014 to staging 🍒 #13020

Merged

OSBotify added a commit that referenced this pull request Nov 24, 2022

Merge pull request #13020 from Expensify/OSBotify-cherry-pick-staging…

94b82d4

…-13014 🍒 Cherry pick PR #13014 to staging 🍒

OSBotify mentioned this pull request Nov 24, 2022

Deploy Checklist: New Expensify 2022-11-23 #12976

Closed

38 tasks

OSBotify mentioned this pull request Nov 27, 2022

Deploy Checklist: New Expensify 2022-11-25 #13059

Closed

21 tasks

OSBotify mentioned this pull request May 2, 2023

Deploy Checklist: New Expensify 2023-05-02 #18315

Closed

OSBotify mentioned this pull request Jun 15, 2023

Deploy Checklist: New Expensify 2023-06-14 #20782

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert "refactor navigation modal card styles" #13014

Revert "refactor navigation modal card styles" #13014

luacmartins commented Nov 24, 2022 •

edited

Loading

github-actions bot commented Nov 24, 2022

melvin-bot bot commented Nov 24, 2022

aimane-chnaif left a comment

marcochavezf commented Nov 24, 2022 •

edited

Loading

marcochavezf left a comment •

edited

Loading

melvin-bot bot commented Nov 24, 2022

marcochavezf commented Nov 24, 2022

OSBotify commented Nov 24, 2022

luacmartins commented Dec 6, 2022

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

Revert "refactor navigation modal card styles" #13014

Revert "refactor navigation modal card styles" #13014

Conversation

luacmartins commented Nov 24, 2022 • edited Loading

Details

Fixed Issues

Tests

QA Steps

PR Author Checklist

PR Reviewer Checklist

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

github-actions bot commented Nov 24, 2022

melvin-bot bot commented Nov 24, 2022

aimane-chnaif left a comment

Choose a reason for hiding this comment

marcochavezf commented Nov 24, 2022 • edited Loading

Reviewer Checklist

Screenshots/Videos

marcochavezf left a comment • edited Loading

Choose a reason for hiding this comment

melvin-bot bot commented Nov 24, 2022

marcochavezf commented Nov 24, 2022

OSBotify commented Nov 24, 2022

luacmartins commented Dec 6, 2022

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

luacmartins commented Nov 24, 2022 •

edited

Loading

marcochavezf commented Nov 24, 2022 •

edited

Loading

marcochavezf left a comment •

edited

Loading