Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinning icon is not well aligned. #1728

Closed
parasharrajat opened this issue Mar 11, 2021 · 6 comments · Fixed by #1737
Closed

Pinning icon is not well aligned. #1728

parasharrajat opened this issue Mar 11, 2021 · 6 comments · Fixed by #1737

Comments

@parasharrajat
Copy link
Member

parasharrajat commented Mar 11, 2021

If you haven’t already, check out our contributing guidelines for onboarding!


Pin icon on the sidebar is not aligned correctly. Suspected PR #1721

Action Performed:

Pina chat and see the Sidebar

Platform:

Where is this issue occurring?

Web

image
#1728
cc @roryabraham

@parasharrajat
Copy link
Member Author

I think we should merge the TouchableOpacity and upper View into TouchableOpacity.
https://github.com/Expensify/Expensify.cash/blob/6e86f75f687bac0d88dbc09a7d7d8832d87c108b/src/pages/home/sidebar/OptionRow.js#L71-L89

@roryabraham
Copy link
Contributor

Seems reasonable to me, thanks for reporting @parasharrajat. @aliabbasmalik8, since your PR likely caused this regression, do you want to submit a PR to fix it?

@aliabbasmalik8
Copy link
Contributor

@roryabraham sure, I'll fix it.

@shawnborton
Copy link
Contributor

Just a heads up that the PR did not actually fix the issue - the entire row is not clickable. Left a comment over here: #1737 (comment)

@parasharrajat
Copy link
Member Author

@shawnborton I think #1728 (comment) has a point.

@aliabbasmalik8
Copy link
Contributor

@shawnborton I'm on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants