Pinning icon alignment #1737
Merged
Pinning icon alignment #1737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roryabraham
requested changes
Mar 12, 2021
roryabraham
approved these changes
Mar 12, 2021
Dal-Papa
approved these changes
Mar 12, 2021
|
Hmm actually I think this did not fix the issue. You can see from the outline that the entire row is not clickable: The outline should encompass the entire row, and the pin & pencil icons should be nested inside of the row and they should be clickable. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@roryabraham Please have a look
Details
Fixed regression that caused due to my PR
Fixed Issues
Fixes #1728
#1661
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android