[HOLD for payment 2023-09-20] [$1250] Cache Pods to speed up iOS deploys

[roryabraham]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Problem

Our slowest platform to deploy, by far, is iOS. Part of the reason for that is because we do a fresh install of all our pods on every deploy, which can take up to 12 minutes. This is a problem because it slows our release cycle, particularly when we want to cherry-pick fixes to our staging environment.

Solution

Use https://github.com/actions/cache to cache our cocoapods and hopefully speed up the iOS deploy. Even a 5 minute improvement would pay dividends in the long run.

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010c613f2c1b3960d0
• Upwork Job ID: 1655741689607213056
• Last Price Increase: 2023-09-10

[melvin-bot]

Triggered auto assignment to @zanyrenney (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010c613f2c1b3960d0

[melvin-bot]

Triggered auto assignment to @greg-schroeder (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[melvin-bot]

Current assignee @roryabraham is eligible for the External assigner, not assigning anyone new.

[roryabraham]

I'm not sure why we got both @zanyrenney and @greg-schroeder assigned here. Going to give it to unassign @greg-schroeder since @zanyrenney was assigned first.

[nbhargava]

Proposal

We're going to use the actions/cache action as mentioned in the original ticket and hash the existing Podfile in order to determine whether we can re-use the existing cache or whether we have to do a fresh install. We'll update App/.github/workflows/testBuild.yml to include something that looks like:

jobs:
  [...]
  iOS:
    steps:
    - [...]
    - uses: actions/cache@v2
      with:
        path: ios/Pods
        key: ${{ runner.os }}-pods-${{ hashFiles('**/Podfile.lock') }}
        restore-keys: |
          ${{ runner.os }}-pods-
    - name: Install cocoapods
      [...]

It may require a bit of fiddling to get the exact invocation right, but this should ensure that we have a cached set of Pods that we can recreate from when possible.

We should be able to test this pretty easily within the context of a single PR by issuing two subsequent builds. We should see a marked speed up in the second build after we issue the first one due to a cache hit.

[melvin-bot]

📣 @nbhargava! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[mananjadhav]

I think @nbhargava's proposal here is good enough.

@roryabraham All yours.

[melvin-bot]

📣 @nbhargava You have been assigned to this job by @roryabraham!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[nbhargava]

Just submitted on Upwork -- hoping to get this in by Friday EOD.

[nbhargava]

Hi all -- I still have not been granted the job on Upwork. I would love to get this in within the 3 business day timeline to be eligible for the bonus (and still believe I can do so) but am not going to continue working on this until I get some clarity in here in case I'm misunderstanding the process.

Thanks!

[myrs]

Perfect! Thank you, I will hand in the PR this Friday.

[myrs]

Hi @roryabraham and @mananjadhav, I've created the PR 🙂

I have also included the update to verifyPodfile.sh as suggested by @roryabraham here. If I understand correctly, including this update the bounty would be $1250.

Looking forward to your review!

[melvin-bot]

Upwork job price has been updated to $1250

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @myrs got assigned: 2023-09-04 15:11:13 Z
• when the PR got merged: 2023-09-11 09:22:30 UTC
• days elapsed: 4

On to the next one 🚀

[roryabraham]

PR was merged without C+ review, removing @mananjadhav. Thanks everyone!

[myrs]

@zanyrenney could you please help me with Upwork job, it still appears with the status "This job is no longer available". As far as I understand, I need to get assigned to this job in order to receive the payment. Thank you!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.68-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] Add CocoaPods caching to speed up iOS builds  #27102

If no regressions arise, payment will be issued on 2023-09-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @myrs requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[myrs]

@zanyrenney @roryabraham hi! Do you still need any information/actions from me to complete the payment? Thank you!

[zanyrenney]

for some reason the job is closed, i'll make another.

[zanyrenney]

Can't find you on upwork under

Misha Yaroshevskiy or Myrs. @myrs can you share your details so i can payout?

[zanyrenney]

https://www.upwork.com/jobs/~01d0e831f76674bb8f

[myrs]

Hi @zanyrenney , just submitted my application to the job

[zanyrenney]

Offer sent, please accept for payout @myrs

[zanyrenney]

Payment summary:

• contributor @myrs - $1250
• contributor plus - merged withuot C+ review
• issue reporter - N/A

[zanyrenney]

paid out and contract ended. thanks!