[HOLD for payment 2023-06-02] [$1000] Inconsistent spacing between amount and tick mark

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Send a money request from account A to account B
2. Settle the requested amount from account B
3. Look at the "settled up [amount]" and tick mark

Expected Result:

There should be a spacing between the amount and the tick mark

Actual Result:

There is no space between the amount and the tick mark

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.14-10
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-05-15.12.32.12.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684143189663259

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0172355caaa1314f42
• Upwork Job ID: 1658893137305018368
• Last Price Increase: 2023-05-17

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[ahmedGaber93]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistent spacing between amount and tick mark

What is the root cause of that problem?

In the first place, we surround the icon with <View style={styles.iouPreviewBoxCheckmark}> which have extra marginLeft, but not surround it in the second place.

in the first place

App/src/components/ReportActionItem/IOUPreview.js

Lines 209 to 214 in f013fe2

	<View style={styles.iouPreviewBoxCheckmark}>
	<Icon
	src={Expensicons.Checkmark}
	fill={themeColors.iconSuccessFill}
	/>
	</View>

in the second place

App/src/components/ReportActionItem/ReportPreview.js

Lines 123 to 127 in f013fe2

	<Icon
	style={[styles.ml10]}
	src={Expensicons.Checkmark}
	fill={themeColors.iconSuccessFill}
	/>

iouPreviewBoxCheckmark style

App/src/styles/styles.js

Lines 2415 to 2418 in f013fe2

	iouPreviewBoxCheckmark: {
	marginLeft: 4,
	alignSelf: 'center',
	},

What changes do you think we should make in order to solve the problem?

Surround icon in the second place with

<View style={styles.iouPreviewBoxCheckmark}>
    
</View>

What alternative solutions did you explore? (Optional)

N/A

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistent spacing between amount and tick mark

What is the root cause of that problem?

We are passing style to the Icon component in here:

App/src/components/ReportActionItem/ReportPreview.js

Line 124 in f013fe2

style={[styles.ml10]}

But inside Icon component we don't have style props, so we don't see any margin here.

What changes do you think we should make in order to solve the problem?

In stead of using style props we should use additionalStyles props for Icon component, we also need to make sure the margin is consistent with the Checkmark in IOUPreview.

              <Icon
// we should use additionalStyles instead of style here, we can use iouPreviewBoxCheckmark styles or ml1.
                     additionalStyles={[styles. iouPreviewBoxCheckmark]}
                     src={Expensicons.Checkmark}
                     fill={themeColors.iconSuccessFill}
                />

What alternative solutions did you explore? (Optional)

None

[Christinadobrzyn]

This seems to just be affecting the browser - I don't see the same padding issues on the other devices. Making External

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0172355caaa1314f42

[melvin-bot]

Current assignee @Christinadobrzyn is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[melvin-bot]

Triggered auto assignment to @jasperhuangg (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Christinadobrzyn]

Hey @ahmedGaber93 Please make sure to wait until the job is in Upwork before adding a proposal to the GH.

[grucare]

I think if you change code like this, the bug will disappear
App/tree/main/src/styles line 2486:

current :
iouPreviewBoxCheckmark: {
marginLeft: 4,
alignSelf: 'center',
}
Change it:
iouPreviewBoxCheckmark: {
marginLeft: 5,
alignSelf: 'center',
}

Is it easy, right ?

[melvin-bot]

📣 @lobcare! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[ahmedGaber93]

Hey @ahmedGaber93 Please make sure to wait until the job is in Upwork before adding a proposal to the GH.

Thanks @Christinadobrzyn.
But guideline here recently changed to allow proposal at any time

You can propose solutions on any issue at at any time, but if you propose solutions to jobs before the Help Wanted label is applied, you do so at your own risk. Proposals will not be reviewed until the label is added and there is always a chance that we might not add the label or hire an external contributor for the job.

[jasperhuangg]

I think if you change code like this, the bug will disappear App/tree/main/src/styles line 2486:

current : iouPreviewBoxCheckmark: { marginLeft: 4, alignSelf: 'center', } Change it: iouPreviewBoxCheckmark: { marginLeft: 5, alignSelf: 'center', }

Is it easy, right ?

Hey @lobcare, please follow the proposal template: https://github.com/Expensify/App/blob/main/contributingGuides/PROPOSAL_TEMPLATE.md

[melvin-bot]

📣 @ahmedGaber93 You have been assigned to this job by @jasperhuangg!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Santhosh-Sellavel]

Thanks @jasperhuangg for the Review!

@ahmedGaber93 Let us know when is PR is ready for Review!

[ahmedGaber93]

@Santhosh-Sellavel PR is ready for review.

[grucare]

I like finding bugs So I made PR yesterday But you need my upwork account I don't have it In this case, what should I do? Thanks.

…

On Thu, May 18, 2023 at 5:08 PM ahmedGaber93 ***@***.***> wrote: @Santhosh-Sellavel <https://github.com/Santhosh-Sellavel> PR <#19222> is ready for review. — Reply to this email directly, view it on GitHub <#19049 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A6N2ACDMIG7XGFPIO32R36LXG2MWJANCNFSM6AAAAAAYD7EEKY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[Santhosh-Sellavel]

@lobcare
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Post your questions on the channel, so people will address your queries.
For now, Upwork is mandatory for getting paid.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.18-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• add some margin between amount and tick mark in ReportPreview.js #19222

If no regressions arise, payment will be issued on 2023-06-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR:
• [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Santhosh-Sellavel] Determine if we should create a regression test for this bug.
• [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Christinadobrzyn]

Hired in Upwork - https://www.upwork.com/jobs/~0172355caaa1314f42

• @Nathan-Mulugeta as reporter
• @Santhosh-Sellavel as C+
• @ahmedGaber93 as contributor

@Santhosh-Sellavel what do you think of a regression test for this?

[Santhosh-Sellavel]

@Santhosh-Sellavel what do you think of a regression test for this?

Not needed here as it's a small UI polish cc: @jasperhuangg

[jasperhuangg]

Not needed here as it's a small UI polish cc: @jasperhuangg
agree!

[grucare]

Hi, Santhosh It's me Jack and a new member of Expensify Slack Channel. Actually I have some problems contributing to Expensify. I don't have my upwork account now because it is blocked. I know once it is blocked I can't recover it. And then I don't know exactly how to work for Expensify as a guest. If possible, kindly teach me. If possible, I wanna collaborate with you. I think I would be helpful to you. I am waiting for your reply. Thanks a lot for taking your time. Best regards. Jack

…

On Fri, May 19, 2023 at 5:41 AM Santhosh Sellavel ***@***.***> wrote: Thanks @jasperhuangg <https://github.com/jasperhuangg> for the Review! @ahmedGaber93 <https://github.com/ahmedGaber93> Let us know when is PR is ready for Review! — Reply to this email directly, view it on GitHub <#19049 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A6N2ACFLVNZ6ASQYG6AU6T3XG2CPLANCNFSM6AAAAAAYD7EEKY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[Santhosh-Sellavel]

@lobcare I've already replied here. Further queries post your questions on channel

[Christinadobrzyn]

Ready for payment but there are some additional convos on the PR - @Santhosh-Sellavel @luacmartins can you confirm if this can be paid or if we're working on something else first?

Do we need a regression test for this?

[luacmartins]

@Christinadobrzyn yes, we can pay that one. We're addressing those in a separate issue.

[Christinadobrzyn]

Awesome! Thanks for confirming @luacmartins

Looks like this isn't eligible for a speed bonus (PR created May 18th - merged May 23rd)

Paid in Upwork based on this - #19049 (comment)

Let me know about any regression tests!

[Santhosh-Sellavel]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR: Implement the RequestPreview component and update the IOUPreview #18486
• [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/18486/files#r1215085067
• [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A Should be caught based on the check list
• [@Santhosh-Sellavel] Determine if we should create a regression test for this bug. N/A
• [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: N/A

[Santhosh-Sellavel]

We are good to close this!