Implement the RequestPreview component and update the IOUPreview #18486

Julesssss · 2023-05-05T15:49:10Z

Details

Introduces a new ReportPreview component which shows the state of the report:

When outstanding: the outstanding balance, and name of person who owes will be displayed
When paid: the name of the payer, with a 'settled up' message, and a checkmark icon

Outstanding

Settled

NOTES:

This is pending a new reportAction. Today it is contained within the IOUPreview component. This means that no Avatar/Timestamp is shown to the left side of the component
Until we deprecate the IOUAction of type 'pay', there will be an additional IOUPreview shown beneath the ReportPreview once it is settled

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/278890

Tests

Test creating IOUS

Create Request from userA to userB
Both users should see 'UserB owes £1.23' beneath the IOUPreview
Create another request from userA to userB
The 'owes £1.23' message should only display beneath the most recent IOUPreview
UserB should see a pay button beneath the reportPreview message
When userB taps the payButton, it should take them to the IOUDetailsPage (this is still relevant ATM)
UserB should settle the IOU
The pay button should disappear
A new message should display in the ReportPreview: 'settled up £1.23'

Offline tests

Being handled separately for urgency

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

…instead of report total

… recent request

…portPreview # Conflicts: # src/components/ReportActionItem/IOUAction.js

Julesssss · 2023-05-09T14:52:02Z

src/components/ReportActionItem/IOUAction.js

-    const shouldShowIOUPreview = props.isMostRecentIOUReportAction || props.action.originalMessage.type === 'pay';
-


Note to self, there is more legacy code to delete related to this.

# Conflicts: # src/components/ReportActionItem/IOUAction.js # src/components/ReportActionItem/IOUQuote.js

…he report manager

Bondy pushed a commit to fix this.

rushatgabhane · 2023-05-12T08:25:32Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

rushatgabhane · 2023-05-12T09:13:42Z

A potential bug - https://expensify.slack.com/archives/C02NK2DQWUX/p1683882609625179?thread_ts=1683879641.844539&cid=C02NK2DQWUX

rushatgabhane

@Julesssss LGTM!

melvin-bot · 2023-05-12T09:30:43Z

🎯 @rushatgabhane, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #18831.

rushatgabhane · 2023-05-12T09:32:18Z

re-run checklist

Implement the RequestPreview component and update the IOUPreview (cherry picked from commit cb076db)

…-18486 🍒 Cherry pick PR #18486 to staging 🍒

OSBotify · 2023-05-12T14:42:28Z

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 1.3.13-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-05-15T08:23:36Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.13-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

aimane-chnaif · 2023-05-23T20:21:01Z

src/components/ReportActionItem/ReportPreview.js

+                    style={[styles.flexRow, styles.justifyContentBetween]}
+                    focusable
+                >
+                    <View>


There was a small regression here - IOU Description extends beyond the page if recipient name is long.
When parent component has flexDirection: 'row' style, don't forget to check if flex should be applied or not to child component style.

Noted, thanks for the helpful comment!

Santhosh-Sellavel · 2023-06-03T01:27:54Z

src/components/ReportActionItem/ReportPreview.js

+                                    <Icon
+                                        style={[styles.ml10]}
+                                        src={Expensicons.Checkmark}
+                                        fill={themeColors.iconSuccessFill}
+                                    />


This change caused a regression here.

OSBotify · 2023-06-15T01:30:39Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-06-16T18:48:28Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Julesssss added 6 commits May 5, 2023 14:41

when an iouAction is available, display the individual action amount …

fc98c90

…instead of report total

render the IOUQuote beneath the IOUPreview, but only if it's the most…

1b1b7a2

… recent request

provide iouQuote with iouReport data

9c978b7

make IOUQuote component UI a variable to make it more readable

2dd9a6e

start showing report currency in reportpreview

2646f5d

use correct currency for iouPreview depending on parent component

5303a67

Julesssss self-assigned this May 5, 2023

Julesssss changed the base branch from main to jules-iouPreview-showForBillSplit May 5, 2023 15:49

Merge branch 'jules-iouPreview-showForBillSplit' into jules-displayRe…

5bdaf09

…portPreview # Conflicts: # src/components/ReportActionItem/IOUAction.js

Base automatically changed from jules-iouPreview-showForBillSplit to main May 5, 2023 19:47

Julesssss added 6 commits May 9, 2023 11:31

Merge branch 'main' into jules-displayReportPreview

9486956

clear up code and resolve lint issues

12d9723

reintroduce formatted amount string for ReportPreview

7d0c14b

use report manager name for ReportPreview 'x owes' message

52a11db

show the 'settled' icon on a report preview if paid

bbf574c

report preview should show 'settled up' message if paid

c1bf09e

Julesssss commented May 9, 2023

View reviewed changes

Julesssss added 4 commits May 9, 2023 15:57

rename IOUQuote as ReportPreview

a28855f

update missing reference to the new report preview component name

1299309

fix minor lint issue

088bcbd

Merge branch 'main' into jules-displayReportPreview

4a75695

# Conflicts: # src/components/ReportActionItem/IOUAction.js # src/components/ReportActionItem/IOUQuote.js

Julesssss mentioned this pull request May 10, 2023

Request Money - Money request preview is displayed twice in chat if there are messages before payment #18696

Closed

6 tasks

Julesssss added 8 commits May 10, 2023 08:26

run npm prettier

f41dca8

add pay button to the report preview component

3ba7186

navigate to IOUDetails when pay button is pressed

4523766

only show pay button if the report is outstanding, and only show to t…

7f5a1fb

…he report manager

stop showing pay button in IOUPreview

bb13b69

add Spanish translation for request preview strings

d86fbbd

add missing session prop

8e5afd0

switch to prop, to avoid needing action data

cb2a047

Julesssss mentioned this pull request May 12, 2023

Web - Chat - IOU Preview is displayed only for last Split Bill in group chat #18743

Closed

6 tasks

luacmartins previously approved these changes May 12, 2023

View reviewed changes

apply style fixes

4237d03

Julesssss dismissed luacmartins’s stale review via 4237d03 May 12, 2023 08:41

luacmartins approved these changes May 12, 2023

View reviewed changes

rushatgabhane approved these changes May 12, 2023

View reviewed changes

melvin-bot bot mentioned this pull request May 12, 2023

Payment issue for E/App PR#18486 #18831

Closed

luacmartins merged commit cb076db into main May 12, 2023

luacmartins deleted the jules-displayReportPreview branch May 12, 2023 09:34

OSBotify pushed a commit that referenced this pull request May 12, 2023

Merge pull request #18486 from Expensify/jules-displayReportPreview

e071e1f

Implement the RequestPreview component and update the IOUPreview (cherry picked from commit cb076db)

This was referenced May 12, 2023

🍒 Cherry pick PR #18486 to staging 🍒 #18833

Merged

Deploy Checklist: New Expensify 2023-05-11 #18764

Closed

cristipaval added a commit that referenced this pull request May 12, 2023

Merge pull request #18833 from Expensify/OSBotify-cherry-pick-staging…

d18cdb8

…-18486 🍒 Cherry pick PR #18486 to staging 🍒

trjExpensify mentioned this pull request May 12, 2023

[HOLD for payment 2023-05-25] [HOLD for payment 2023-05-23] [$1000] [Manual Requests] Update the report preview message to use workspaceName, not the admin name. #18858

Closed

kbecciv mentioned this pull request May 12, 2023

[HOLD for payment 2023-05-25] [HOLD for payment 2023-05-23] [$1000] mWeb/Chrome - IOU - Description extends beyond the page if the recipient's name is long #18882

Closed

6 tasks

OSBotify mentioned this pull request May 15, 2023

Deploy Checklist: New Expensify 2023-05-15 #18938

Closed

67 tasks

Julesssss mentioned this pull request May 16, 2023

Display report preview using new reportAction data source #18423

Merged

55 tasks

aimane-chnaif reviewed May 23, 2023

View reviewed changes

Santhosh-Sellavel reviewed Jun 3, 2023

View reviewed changes

Santhosh-Sellavel mentioned this pull request Jun 3, 2023

[HOLD for payment 2023-06-02] [$1000] Inconsistent spacing between amount and tick mark #19049

Closed

6 tasks

OSBotify mentioned this pull request Jun 15, 2023

Deploy Checklist: New Expensify 2023-06-14 #20782

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement the RequestPreview component and update the IOUPreview #18486

Implement the RequestPreview component and update the IOUPreview #18486

Julesssss commented May 5, 2023 •

edited

Loading

Julesssss May 9, 2023

rushatgabhane commented May 12, 2023 •

edited

Loading

rushatgabhane commented May 12, 2023

rushatgabhane left a comment

melvin-bot bot commented May 12, 2023

rushatgabhane commented May 12, 2023

OSBotify commented May 12, 2023

OSBotify commented May 15, 2023

aimane-chnaif May 23, 2023

rushatgabhane May 23, 2023 •

edited

Loading

Santhosh-Sellavel Jun 3, 2023

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

		const shouldShowIOUPreview = props.isMostRecentIOUReportAction \|\| props.action.originalMessage.type === 'pay';

Implement the RequestPreview component and update the IOUPreview #18486

Implement the RequestPreview component and update the IOUPreview #18486

Conversation

Julesssss commented May 5, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Julesssss May 9, 2023

Choose a reason for hiding this comment

rushatgabhane commented May 12, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

rushatgabhane commented May 12, 2023

rushatgabhane left a comment

Choose a reason for hiding this comment

melvin-bot bot commented May 12, 2023

rushatgabhane commented May 12, 2023

OSBotify commented May 12, 2023

OSBotify commented May 15, 2023

aimane-chnaif May 23, 2023

Choose a reason for hiding this comment

rushatgabhane May 23, 2023 • edited Loading

Choose a reason for hiding this comment

Santhosh-Sellavel Jun 3, 2023

Choose a reason for hiding this comment

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

Julesssss commented May 5, 2023 •

edited

Loading

rushatgabhane commented May 12, 2023 •

edited

Loading

rushatgabhane May 23, 2023 •

edited

Loading