[HOLD for payment 2023-06-13] [$1000] Reply text is not aligned to emoji on edit message (aligned properly without edit)

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open any report
3. Hover on any message send by you, click on reply in thread and add new message in it
4. Revisit the original report and add emoji reaction to it (observe that emoji reaction and '1 Reply' message is aligned vertically)
5. Edit the parent message used in step 3 and observe that '1 Reply' message is not aligned to composer start as emoji reaction

Expected Result:

App should align '1 Reply' text to start of composer on edit as it does for reaction emoji

Actual Result:

App does not align '1 Reply' text to start of composer on edit of message as it does for reaction emoji

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.16.6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

not.aligned.reply.text.on.edit.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684486648715929

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0145a755aa7c56d944
• Upwork Job ID: 1661335016989315072
• Last Price Increase: 2023-05-24

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dhairyasenjaliya]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Reply text is not aligned to emoji on edit message (aligned properly without edit)

What is the root cause of that problem?

• The root cause is we have not adjusted styling if we have edit mode (draftMessage) on and we need to adjust styling for margin-left same as we did on the ReportActionItemReactions

What changes do you think we should make in order to solve the problem?

• On ReportActionItem.js on we need to wrap with a <ReportActionItemThread> with the same <View> with styling used of <ReportActionItemReactions> which is this.props.draftMessage ? styles.chatItemReactionsDraftRight : {}

• We can also pass draft props to <ReportActionItemThread> and handle style there

Result

[sonialiap]

Reproducible 👍

Screen.Recording.2023-05-24.at.1.39.02.PM.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0145a755aa7c56d944

[melvin-bot]

Current assignee @sonialiap is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[getusha]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Reply text is not correctly aligned to the reaction emoji

What is the root cause of that problem?

Currently the ReportActionItemThread component has maxWidth of 100% which will fill the entire width, initially when the avatar on the ReportItem is visible it is aligned to the emoji, but when we edit the message the avatar will not be visible then the ReportActionItemThread will take the whole width

What changes do you think we should make in order to solve the problem?

We should wrap the ReportActionItemThread component with <View style={this.props.draftMessage ? styles.chatItemReactionsDraftRight : {}}> to align the component correctly when the user is editing the message.

we are currently using this for ReportActionItemReactions here:

App/src/pages/home/report/ReportActionItem.js

Line 283 in b10f19d

<View style={props.draftMessage ? styles.chatItemReactionsDraftRight : {}}>

Additionally instead of repeating the code we can wrap both components with the view and put the conditions inside like this

Result:

Screen.Recording.2023-05-24.at.3.06.12.PM.mov

What alternative solutions did you explore? (Optional)

[MonilBhavsar]

Couple of proposals are there, @eVoloshchak if you could please take a look

[eVoloshchak]

@dhairyasenjaliya's proposal looks good to me. This is a pretty straight-forward fix, looks like this was just missed during the initial implementation

🎀👀🎀 C+ reviewed!
cc: @MonilBhavsar

[MonilBhavsar]

Thanks! Looks good to me too

[melvin-bot]

📣 @dhairyasenjaliya You have been assigned to this job by @MonilBhavsar!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[dhairyasenjaliya]

@MonilBhavsar @eVoloshchak PR ready for review

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.24-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix replay component position while editing message #19902

If no regressions arise, payment will be issued on 2023-06-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eVoloshchak] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[dhairyasenjaliya]

bump @sonialiap for the Upwork contract

[eVoloshchak]

Will finish up the checklist items tomorrow

[sonialiap]

@dhanashree-sawant offer sent for reporting issue - paid
@dhairyasenjaliya offer sent for fix (bonus will be applied for 3 day merge) - paid
@eVoloshchak offer pending checklist step completion sent for review (bonus will be applied for 3 day merge) - paid

[dhairyasenjaliya]

@sonialiap accepted thnx

[dhanashree-sawant]

Thanks @sonialiap, I have accepted the offer.

[eVoloshchak]

• The PR that introduced the bug has been identified. Link to the PR: Add ReportActionItemThread and Thread Replies UI  #18274

• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/18274/files#r1232363177

• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: This is a visual bug, I don't think there is an additional discussion needed

• Determine if we should create a regression test for this bug.
  Is it easy to test for this bug? Yes
  Is the bug related to an important user flow? Yes
  Is it an impactful bug? No
  It's not an impactful bug, but it's one of the most user-facing pages of the app and it's very easy to test, so I think regression test is worth having here.

[eVoloshchak]

Regression Test Proposal

1. Open any report
2. Hover on any message sent by you, click on reply in the thread and add a new message to it
3. Revisit the original report and add an emoji reaction to the parent message (observe the emoji reaction and '1 Reply' message are aligned vertically)
4. Edit the parent message used in step 3 and verify the '1 Reply' message is aligned with the composer

Do we agree 👍 or 👎

[sonialiap]

Thanks @eVoloshchak! Offer sent, bonus will be added once offer is accepted

[sonialiap]

Everyone has been paid