Add `ReportActionItemThread` and Thread Replies UI #18274

stitesExpensify · 2023-05-02T15:15:47Z

Details

Fixed Issues

$ #18754

Tests

Verify that no errors appear in the JS console

Tested with this snippet and changing values:

Onyx.merge('reportActions_<parentReportID>',
           {
               '<parentReportActionID>': {
                   'childReportID': 1,
                   'childOldestFourEmails': 'test@andrew.com,georgia@expensify.com',
                   'childCommenterCount': 6,
                   'childLastVisibleActionCreated': '2023-09-04 00:59:29.277',
                   'childVisibleActionCount': 2
               }
           });

Find the reportID on a report and get the reportActionID of a comment. (Look at the list in reportActions_<reportID> to find one). We will call these reportID and parentReportActionID respectively.
Run this snippet:

Onyx.merge('reportActions_<parentReportID>',
           {
               '<parentReportActionID>': {
                   'childReportID': 1,
                   'childOldestFourEmails': 'test@email.com',
                   'childCommenterCount': 6,
                   'childLastVisibleActionCreated': '2023-09-04 00:59:29.277',
                   'childVisibleActionCount': 1
               }
           });

Verify the result looks like:

Run this snippet:

Onyx.merge('reportActions_<parentReportID>',
           {
               '<parentReportActionID>': {
                   'childReportID': 1,
                   'childOldestFourEmails': 'test@email.com,test2@email.com',
                   'childCommenterCount': 6,
                   'childLastVisibleActionCreated': '2023-09-04 00:59:29.277',
                   'childVisibleActionCount': 2
               }
           });

Verify the result looks like:

Onyx.merge('reportActions_<parentReportID>',
           {
               '<parentReportActionID>': {
                   'childReportID': 1,
                   'childOldestFourEmails': 'test@email.com,test2@email.com,test3@email.com,test4@email.com,test5@email.com',
                   'childCommenterCount': 6,
                   'childLastVisibleActionCreated': '2023-09-04 00:59:29.277',
                   'childVisibleActionCount': 6,
               }
           });

Verify the result looks like:

Test any other cases by modifying the values.

Offline tests

QA Steps

Create a thread
Go back to the parent, and verify that you do not see a thread because no comments were posted
Add a comment to the thread and then go back to the parent
Verify that you see the thread like so:

- [ ] Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

emulator won't connect to wifi on web only, no screenshot for now

Desktop

iOS

Android

…taction

…ltipleAvatars

grgia · 2023-05-04T13:18:14Z

Tests for each number of users: (Note, 7 and 1:03pm time stamp are hard-coded)

1:

2:

3:

4:

greater than 4 :

grgia · 2023-05-04T13:57:40Z

src/pages/home/report/ReportActionItem.js

@@ -244,6 +246,7 @@ class ReportActionItem extends Component {
                        toggleReaction={this.toggleReaction}
                    />
                )}
+                <ReportActionItemThread numberOfReplies={7} mostRecentReply={'1:03pm'} icons={ReportUtils.getIcons(this.props.report, this.props.personalDetails)} />


@chiragsalian how are we handling the conditional rendering of this. Would we just check if this.props.action.childReportID exists?

ReportUtils.js isThread?

Discussed 1:1, yes just checking this.props.action.childReportID should suffice to render this item.

grgia · 2023-05-12T21:02:17Z

#18274 (comment)

this is definitely a bug, @shawnborton would you mind confirming this? How should we handle mobile sizes? Also, say you have 1000+ replies, should we cap at 100+?

chiragsalian · 2023-05-12T21:02:29Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

shawnborton · 2023-05-12T21:12:53Z

I don't mean to derail this but I'm not sure that I feel good about the avatar sizes used for threads. I feel like this feels a bit more friendly (avatars are 28px x 28px):

We can always adjust that in a follow up.

In terms of the date, is there anything we can do to use a more relative date in this preview? So something like "Last year" or "last month" or "last week"? Then we can use specific dates in the thread view?

I also think we should cap it off at say 99+ or something

stitesExpensify

LGTM!

chiragsalian · 2023-05-12T21:29:38Z

Awesome, in the interest of time i'm going to merge this. Its still only visible under beta so we can test it out properly before showing it to everyone. Since the code concerns were handled I'm going to go ahead and merge this. If there are any pending concerns feel free to raise them and we'll tackle them in a follow up.

shawnborton · 2023-05-12T21:31:42Z

@chiragsalian @stitesExpensify can you please create a follow up issue for my design comments above? Let's try to address that ASAP please!

shawnborton · 2023-05-12T21:32:22Z

Oh I saw @grgia already created the issue, woo!

OSBotify · 2023-05-12T21:35:44Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

parasharrajat · 2023-05-13T09:30:33Z

Yeah, do create the followup issues.

Add ReportActionItemThread and Thread Replies UI #18274 (comment)
Add ReportActionItemThread and Thread Replies UI #18274 (comment) I think this can be discussed further.

OSBotify · 2023-05-15T09:19:20Z

🚀 Deployed to staging by https://github.com/chiragsalian in version: 1.3.14-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mvtglobally · 2023-05-15T14:11:18Z

@stitesExpensify No QA needed here, correct?

stitesExpensify · 2023-05-16T19:35:13Z

Sorry I missed this, we should run the test steps as QA here

mvtglobally · 2023-05-16T22:12:32Z

@stitesExpensify see linked issue as we are still checking all the platforms

OSBotify · 2023-05-17T00:19:10Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.14-14 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

s77rt · 2023-05-25T09:08:57Z

This PR caused a bug #19142. The Text was not flexible and it overflows.

eVoloshchak · 2023-06-16T14:54:42Z

src/pages/home/report/ReportActionItem.js

@@ -254,6 +264,14 @@ class ReportActionItem extends Component {
                        />
                    </View>
                )}
+                {shouldDisplayThreadReplies && (
+                    <ReportActionItemThread


👋This has caused a small visual issue in #19398.
Reply text wasn't aligned with composer when editing, ReportActionItemThread should have the same styles applied as ReportActionItemReactions above: this.props.draftMessage ? styles.chatItemReactionsDraftRight : {}

stitesExpensify added 13 commits April 26, 2023 18:27

Add new button for replying in threads

982c97b

Add size prop

e09ee8b

Add imageSize method

1d40aa0

change all sizes based on prop

4b919fd

Add threads component

55aa13b

Create new component to display threads in reportActions

8162704

Add method for creating/opening threads

e7b3b9f

Pass the child reportactionID through the context menu

4db53da

Update API call to properly create optimistic thread report and repor…

8b31d03

…taction

go back instead of always home

7761696

Remove changes to navigation

bae93b4

Remove new openChildReport method

3b73583

Extract more code to other PRs

10fe957

stitesExpensify changed the title ~~Stites thread UI~~ Update reportAction UI to handle threads May 4, 2023

stitesExpensify self-assigned this May 4, 2023

stitesExpensify requested a review from chiragsalian May 4, 2023 02:52

grgia self-assigned this May 4, 2023

grgia added 4 commits May 4, 2023 11:25

Merge branch 'main' into stites-threadUI

7780871

Clean up thread styles, use Multiple Avatars

a05a95a

Undo changes to RoomHeaderAvatars that are already accomplished by Mu…

0de7775

…ltipleAvatars

Add translations

9afd2f2

grgia reviewed May 4, 2023

View reviewed changes

grgia added 6 commits May 8, 2023 15:28

Temporarily reference reportAction

c75840a

Clean up, icon helper function

cd52ecc

Allow to be pressed

b54a6b0

Merge branch 'main' into stites-threadUI

0f336e4

fix delimiter

00c1532

undo, my testing data was wrong

20bc93d

grgia marked this pull request as ready for review May 10, 2023 21:00

Don't show on thread preview (first chat in thread)

30f5eba

grgia requested a review from parasharrajat May 12, 2023 20:59

chiragsalian approved these changes May 12, 2023

View reviewed changes

grgia mentioned this pull request May 12, 2023

[HOLD for payment 2023-05-25] Clean up Inline Thread Replies Styles (+ handle mobile/small screen sizes) #18872

Closed

5 tasks

stitesExpensify commented May 12, 2023

View reviewed changes

chiragsalian merged commit 293f23b into main May 12, 2023

chiragsalian deleted the stites-threadUI branch May 12, 2023 21:29

OSBotify mentioned this pull request May 15, 2023

Deploy Checklist: New Expensify 2023-05-15 #18938

Closed

67 tasks

kbecciv mentioned this pull request May 16, 2023

Thread - Every new thread displays as a new chat in LHN #19077

Closed

6 tasks

melvin-bot bot mentioned this pull request May 16, 2023

[HOLD for payment 2023-05-23] UI updates to threaded reportActions #18754

Closed

s77rt mentioned this pull request May 25, 2023

[HOLD for payment 2023-06-01] Android - Threads - Date is not truncated and very close to screen border #19142

Closed

6 tasks

eVoloshchak reviewed Jun 16, 2023

View reviewed changes

eVoloshchak mentioned this pull request Jun 16, 2023

[HOLD for payment 2023-06-13] [$1000] Reply text is not aligned to emoji on edit message (aligned properly without edit) #19398

Closed

6 tasks

eVoloshchak mentioned this pull request Jul 25, 2023

[HOLD for payment 2023-07-21] [$1000] Long Pressing on reply opens the context menu for the ReportPreview action. #21292

Closed

6 tasks

MelvinBot mentioned this pull request Apr 6, 2024

[Snyk] Security upgrade eslint from 7.32.0 to 9.0.0 #39794

Closed

50 tasks

melvin-bot bot mentioned this pull request Apr 6, 2024

[Snyk] Security upgrade eslint from 7.32.0 to 9.0.0 #39795

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `ReportActionItemThread` and Thread Replies UI #18274

Add `ReportActionItemThread` and Thread Replies UI #18274

stitesExpensify commented May 2, 2023 •

edited

Loading

grgia commented May 4, 2023 •

edited

Loading

grgia May 4, 2023

grgia May 4, 2023

chiragsalian May 4, 2023

grgia commented May 12, 2023

chiragsalian commented May 12, 2023 •

edited

Loading

shawnborton commented May 12, 2023

stitesExpensify left a comment

chiragsalian commented May 12, 2023

shawnborton commented May 12, 2023

shawnborton commented May 12, 2023

OSBotify commented May 12, 2023

parasharrajat commented May 13, 2023 •

edited

Loading

OSBotify commented May 15, 2023

mvtglobally commented May 15, 2023

stitesExpensify commented May 16, 2023

mvtglobally commented May 16, 2023

OSBotify commented May 17, 2023

s77rt commented May 25, 2023

eVoloshchak Jun 16, 2023

Add ReportActionItemThread and Thread Replies UI #18274

Add ReportActionItemThread and Thread Replies UI #18274

Conversation

stitesExpensify commented May 2, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

grgia commented May 4, 2023 • edited Loading

grgia May 4, 2023

Choose a reason for hiding this comment

grgia May 4, 2023

Choose a reason for hiding this comment

chiragsalian May 4, 2023

Choose a reason for hiding this comment

grgia commented May 12, 2023

chiragsalian commented May 12, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

shawnborton commented May 12, 2023

stitesExpensify left a comment

Choose a reason for hiding this comment

chiragsalian commented May 12, 2023

shawnborton commented May 12, 2023

shawnborton commented May 12, 2023

OSBotify commented May 12, 2023

parasharrajat commented May 13, 2023 • edited Loading

OSBotify commented May 15, 2023

mvtglobally commented May 15, 2023

stitesExpensify commented May 16, 2023

mvtglobally commented May 16, 2023

OSBotify commented May 17, 2023

s77rt commented May 25, 2023

eVoloshchak Jun 16, 2023

Choose a reason for hiding this comment

Add `ReportActionItemThread` and Thread Replies UI #18274

Add `ReportActionItemThread` and Thread Replies UI #18274

stitesExpensify commented May 2, 2023 •

edited

Loading

grgia commented May 4, 2023 •

edited

Loading

chiragsalian commented May 12, 2023 •

edited

Loading

parasharrajat commented May 13, 2023 •

edited

Loading