[HOLD for payment 2023-06-12] [$1000] Console error on clicking on download icon on deleted message #19413

kavimuru · 2023-05-22T21:35:26Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to staging dot on web chrome
Open console
Send an image in a chat.
Click reply in the image to open a thread.
Delete the image while in the thread. Wait until the image deletes.
Hover over the deleted message and you can see the download option
Click on it and notice that nothing happens, and you see an error in the console.

Expected Result:

We shouldn't show download option after deleting a message.

Actual Result:

We show option to download the image after the image is deleted.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.16.7
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

error-2023-05-19_15.23.30.mp4

Recording.720.mp4

Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684489220942129

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f8f88bf5b41b887d
Upwork Job ID: 1661110256348393472
Last Price Increase: 2023-05-23

melvin-bot · 2023-05-22T21:35:31Z

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-05-22T21:35:33Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

bogoroh · 2023-05-23T01:16:37Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

When deleting an attachment there download button is still present which causes console.log errors.

What is the root cause of that problem?

ContextMenuActions.js has logic on if it should display the download button yes or no. The logic doesn't check if the attachment is still present. So a deleted attachment will still return true.

shouldShow: (type, reportAction) => {
            const message = _.last(lodashGet(reportAction, 'message', [{}]));
            const isAttachment = _.has(reportAction, 'isAttachment') ? reportAction.isAttachment : ReportUtils.isReportMessageAttachment(message);
            return isAttachment && reportAction.reportActionID && false;
        },

What changes do you think we should make in order to solve the problem?

Add some additional code checks to make sure the parentAction was actually removed.

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Line 91 in 846d593

return isAttachment && reportAction.reportActionID;

Should become :
return isAttachment && reportAction.reportActionID && !reportAction.originalMessage.isDeletedParentAction;

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

melvin-bot · 2023-05-23T01:16:41Z

📣 @bogoroh! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

bogoroh · 2023-05-23T01:22:39Z

Contributor details
Your Expensify account email: mrtedits@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01043555e50efb5444

melvin-bot · 2023-05-23T01:22:42Z

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

bogoroh · 2023-05-23T01:23:36Z

Contributor details
Your Expensify account email: mrtedits@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01043555e50efb5444

melvin-bot · 2023-05-23T01:23:38Z

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

Pujan92 · 2023-05-23T02:21:30Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Console error on trying to download the deleted attachment

What is the root cause of that problem?

On deleting the attachment we are cleaning the html prop of the message and on click of the delete it should throw an error here bcoz the sourceURL will be null here. So accessing the match on null will cause the issue.

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 94 to 99 in 846d593

    
           const message = _.last(lodashGet(reportAction, 'message', [{}])); 
        
           const html = lodashGet(message, 'html', ''); 
        
           const attachmentDetails = getAttachmentDetails(html); 
        
           const {originalFileName, sourceURL} = attachmentDetails; 
        
           const sourceURLWithAuth = addEncryptedAuthTokenToURL(sourceURL); 
        
           const sourceID = (sourceURL.match(CONST.REGEX.ATTACHMENT_ID) || [])[1];

What changes do you think we should make in order to solve the problem?

We should not show the delete option in the context actions as the image url is being removed from the html prop of the message. To achieve this we need to add 1 more condition && !message.isDeletedParentAction here.

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Line 91 in 846d593

return isAttachment && reportAction.reportActionID;

hungvu193 · 2023-05-23T04:30:29Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Console error on clicking on download icon on deleted message

What is the root cause of that problem?

When we deleted the attachment thread message, we remove the text and html. So when we tried to download the deleted attachment, it will be crashed since sourceURL will be null:

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Line 99 in 846d593

const sourceID = (sourceURL.match(CONST.REGEX.ATTACHMENT_ID) || [])[1];

What changes do you think we should make in order to solve the problem?

Since isAttachment inside reportAction isn't updated when we deleted the thread attachment message and we already had a function to check if the current message is attachment, I think we can hide the download button by updating the condition of isAttachment inside shouldShow function of Download button to this:

 const isAttachment = ReportUtils.isReportMessageAttachment(message);

// Optional: we can also update isReportMessageAttachment 
export default function isReportMessageAttachment({text, html, isDeletedParentAction}) {
    if (isDeletedParentAction || !text || !html) {
        return false;
    }

    const regex = new RegExp(` ${CONST.ATTACHMENT_SOURCE_ATTRIBUTE}="(.*)"`, 'i');
    return text === CONST.ATTACHMENT_MESSAGE_TEXT && !!html.match(regex);
}

What alternative solutions did you explore? (Optional)

We can also still allow the download button with deleted attachment, but we should add an early return and showing an error for user to let them know, this attachment is no longer exist, they can't download them:

// inside onPress function 
const {originalFileName, sourceURL} = attachmentDetails;
 if (!sourceURL) {
  Grow.show(' this attachment is no longer exist'....);
   hideContextMenu(true, ReportActionComposeFocusManager.focus);
}

LiaKim07 · 2023-05-23T11:14:01Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Console error on trying to download the deleted attachment

What is the root cause of that problem?

When click the download on deleting the attachment, sourceURL will be null value. That's why it shows console error when click the download icon.

What changes do you think we should make in order to solve the problem?

In fact, the tooltip part should not be shown for deleted attachments and deleted messages like Slack and other chatting apps.
We don't have any text and attachments to copy, delete or download so no need to show those icons.

I think, it's the right way in the chatting app.

We can implement that functionality based on whether the message or attachment is deleted.

joekaufmanexpensify · 2023-05-23T20:41:05Z

I was able to reproduce this on web. However, the bug here isn't the console error IMO. It's that we show a download icon after deleting the image. We shouldn't show this.

Also, this doesn't just apply to workspaces. It applies to any type of message in the app. Cleaned up the reproduction steps to reflect this.

melvin-bot · 2023-05-23T20:42:04Z

Job added to Upwork: https://www.upwork.com/jobs/~01f8f88bf5b41b887d

melvin-bot · 2023-05-23T20:42:06Z

Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new.

melvin-bot · 2023-05-23T20:42:12Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

melvin-bot · 2023-05-23T20:42:16Z

Triggered auto assignment to @bondydaa (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

joekaufmanexpensify · 2023-05-24T19:45:24Z

@0xmiroslav could you please review the above proposals when you have a chance?

0xmiros · 2023-05-24T19:51:57Z

reviewing now

0xmiros · 2023-05-24T20:32:53Z

It doesn't make sense at all to show these icons since deleted attachment is not downloadable, copiable or deletable.
@bondydaa do you agree?

melvin-bot · 2023-05-25T00:22:04Z

📣 @victornnaji! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

LiaKim07 · 2023-05-25T00:24:57Z

@0xmiroslav , and we need reactions and 'Mark as Unread' for the [Deleted Message]?

0xmiros · 2023-05-25T02:24:00Z

and we need reactions and 'Mark as Unread' for the [Deleted Message]?

I think no problem with it.
@bondydaa @joekaufmanexpensify what are your thoughts?

bondydaa · 2023-06-01T20:16:56Z

I merged the PR today so should get deployed soon, maybe tomorrow or next week. i haven't kept up with our deploy status this week.

joekaufmanexpensify · 2023-06-04T16:14:47Z

@jliexpensify I'm back from OOO, so removing your assignment. Thanks for covering!

melvin-bot · 2023-06-05T18:48:01Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-06-05T18:48:02Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.23-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

remove download attachment on deleted attachment #19769

If no regressions arise, payment will be issued on 2023-06-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-06-05T18:48:04Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR: [HOLD for payment 2023-06-12] [$1000] Console error on clicking on download icon on deleted message #19413 (comment)
[@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
[@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: [HOLD for payment 2023-06-12] [$1000] Console error on clicking on download icon on deleted message #19413 (comment)
[@0xmiroslav] Determine if we should create a regression test for this bug.
[@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: Proposed merging into regression test for related issue: [HOLD for payment 2023-06-28] [$1000] Web- Tread - Copy to clipboard on parent [deleted message] does not work #20074 (comment)

joekaufmanexpensify · 2023-06-12T13:18:26Z

@0xmiroslav Could you please complete your steps for the C+ checklist? Then, we can issue payment here.

0xmiros · 2023-06-12T16:39:41Z

No PRs caused regression but this case was missed while implementing thread feature. I think regression test needs to be migrated into #20074 which handles all context menu actions, not only download icon.

joekaufmanexpensify · 2023-06-12T19:01:24Z

I think regression test needs to be migrated into #20074 which handles all context menu actions, not only download icon.

@0xmiroslav Isn't that issue just for regular messages though? Vs this being images specifically. I agree they are related, but it feels like a slightly different case. Or do you mean just have the image case as a 1b regression test to the 1a in the above linked issue?

0xmiros · 2023-06-12T19:04:00Z

@joekaufmanexpensify that issue about parent [Deleted message] in thread. Same as this GH.

joekaufmanexpensify · 2023-06-12T19:06:20Z

It's not the same exact case though, no? Since this issue is specifically with images and the download button. And that one seems to be just text messages generally, and then other buttons on the clipboard menu. But LMK if that's not correct!

0xmiros · 2023-06-12T19:08:00Z

So comprehensive regression test step will be:

Send any message (or any attachment) in any chat room
Thread that message
Send any message on that thread
Delete parent message
Hover [Deleted message]
Verify that context menu shows only "Mark as unread" icon, no other icons show

joekaufmanexpensify · 2023-06-12T19:08:37Z

@bogoroh was assigned to this issue on May 29th at 10:49am ET. The PR was merged on June 1st at 12:50pm ET. This is slightly longer than 72 hours. However, @0xmiroslav approved the PR's changes on May 30th (which was considerably less than 72 hours.) We then approved the PR and merged it (without requesting any other changes).

@bondydaa and I chatted, and since the delay that pushed this past the 72 hour mark was internal, this still qualifies for a speed bonus. So we need to issue these payments:

@bogoroh $1,500 for PR.
@0xmiroslav $1,500 for C+ review.
@priya-zha $250 for reporting.

joekaufmanexpensify · 2023-06-12T19:09:10Z

So comprehensive regression test step will be:

Cool those steps makes sense. I commented them on the other issue to save them the work: #20074 (comment)

joekaufmanexpensify · 2023-06-12T19:22:48Z

BZ checklist is complete, all set to issue payment here!

joekaufmanexpensify · 2023-06-12T19:23:01Z

@bogoroh $1,500 sent and contract ended!

joekaufmanexpensify · 2023-06-12T19:23:58Z

@priya-zha $250 sent and contract ended!

joekaufmanexpensify · 2023-06-12T19:25:09Z

@0xmiroslav $1,500 sent and contract ended!

joekaufmanexpensify · 2023-06-12T19:25:22Z

Upwork job closed.

joekaufmanexpensify · 2023-06-12T19:25:46Z

Bug is fixed, BZ checklist complete, and all payment issued. Closing as this is all set. Thanks everyone!

kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 22, 2023

melvin-bot bot assigned joekaufmanexpensify May 22, 2023

joekaufmanexpensify added the External Added to denote the issue can be worked on by a contributor label May 23, 2023

melvin-bot bot changed the title ~~Console error on clicking on download icon on deleted message~~ [$1000] Console error on clicking on download icon on deleted message May 23, 2023

melvin-bot bot assigned 0xmiros May 23, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 23, 2023

melvin-bot bot assigned bondydaa May 23, 2023

bogoroh mentioned this issue May 29, 2023

remove download attachment on deleted attachment #19769

Merged

58 tasks

melvin-bot bot added the Reviewing Has a PR in review label May 29, 2023

joekaufmanexpensify unassigned jliexpensify Jun 4, 2023

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Jun 5, 2023

melvin-bot bot changed the title ~~[$1000] Console error on clicking on download icon on deleted message~~ [HOLD for payment 2023-06-12] [$1000] Console error on clicking on download icon on deleted message Jun 5, 2023

melvin-bot bot removed the Reviewing Has a PR in review label Jun 5, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 11, 2023

joekaufmanexpensify closed this as completed Jun 12, 2023

[HOLD for payment 2023-06-12] [$1000] Console error on clicking on download icon on deleted message #19413

[HOLD for payment 2023-06-12] [$1000] Console error on clicking on download icon on deleted message #19413

Comments

kavimuru commented May 22, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented May 22, 2023

melvin-bot bot commented May 22, 2023 • edited by joekaufmanexpensify Loading

Bug0 Triage Checklist (Main S/O)

bogoroh commented May 23, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot bot commented May 23, 2023

bogoroh commented May 23, 2023

melvin-bot bot commented May 23, 2023

bogoroh commented May 23, 2023

melvin-bot bot commented May 23, 2023

Pujan92 commented May 23, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

hungvu193 commented May 23, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

LiaKim07 commented May 23, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

joekaufmanexpensify commented May 23, 2023

melvin-bot bot commented May 23, 2023

melvin-bot bot commented May 23, 2023

melvin-bot bot commented May 23, 2023

melvin-bot bot commented May 23, 2023

joekaufmanexpensify commented May 24, 2023

0xmiros commented May 24, 2023

0xmiros commented May 24, 2023

melvin-bot bot commented May 25, 2023

LiaKim07 commented May 25, 2023 • edited Loading

0xmiros commented May 25, 2023

bondydaa commented Jun 1, 2023

joekaufmanexpensify commented Jun 4, 2023

melvin-bot bot commented Jun 5, 2023

melvin-bot bot commented Jun 5, 2023 • edited by joekaufmanexpensify Loading

melvin-bot bot commented Jun 5, 2023 • edited by joekaufmanexpensify Loading

joekaufmanexpensify commented Jun 12, 2023

0xmiros commented Jun 12, 2023

joekaufmanexpensify commented Jun 12, 2023

0xmiros commented Jun 12, 2023

joekaufmanexpensify commented Jun 12, 2023

0xmiros commented Jun 12, 2023

joekaufmanexpensify commented Jun 12, 2023

joekaufmanexpensify commented Jun 12, 2023 • edited Loading

joekaufmanexpensify commented Jun 12, 2023

joekaufmanexpensify commented Jun 12, 2023

joekaufmanexpensify commented Jun 12, 2023

joekaufmanexpensify commented Jun 12, 2023

joekaufmanexpensify commented Jun 12, 2023

joekaufmanexpensify commented Jun 12, 2023

kavimuru commented May 22, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented May 22, 2023 •

edited by joekaufmanexpensify

Loading

LiaKim07 commented May 23, 2023 •

edited

Loading

LiaKim07 commented May 25, 2023 •

edited

Loading

melvin-bot bot commented Jun 5, 2023 •

edited by joekaufmanexpensify

Loading

melvin-bot bot commented Jun 5, 2023 •

edited by joekaufmanexpensify

Loading

joekaufmanexpensify commented Jun 12, 2023 •

edited

Loading