[HOLD for payment 2023-06-21] [$1000] Mweb - Workspace - the "Next" button overlaps the input field for specific phone modal (Huawei P10 lite)

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the "Settings" menu.
2. Click on "Workspaces."
3. Open any Workspace.
4. Select "Manage Members."
5. Select "Invite."
6. Select "Invite New Members."
7. Tap on the input field.
8. Notice that the "Next" button overlaps the input field.

Expected Result:

The "Next" button should not overlap the input field.

Actual Result:

On small screen devices, the "Next" button overlaps the input field.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.19.2

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug.3.mp4

Expensify/Expensify Issue URL:

Issue reported by: @usmantariq96

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684994471559049

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a873f4cf420dcd10
• Upwork Job ID: 1663674368458465280
• Last Price Increase: 2023-06-06

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Ollyws]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The Next button overlaps the input field when the screen height is small enough.

What is the root cause of that problem?

The flex style configuration causes the textInput to shrink along with the parent container, which causes an overlap when the screen height is too small.

What changes do you think we should make in order to solve the problem?

We need to add flex1 and flexBasis: 0 styles to the OptionsList and replace flex1 with flexGrow1, flexShrink0 and flexBasisAuto in WorkspaceInvitePage.
This will cause the OptionsSelector/TextInput container to shrink up until it gets to the height of the textInput.

What alternative solutions did you explore? (Optional)

None

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a873f4cf420dcd10

[melvin-bot]

Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[melvin-bot]

Triggered auto assignment to @flodnv (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[mallenexpensify]

Was able to reproduce using the one Huawei phone available in Browserstack.

[mallenexpensify]

@mollfpr , can you review @Ollyws proposal above please?
#19740 (comment)

[mollfpr]

Reviewing now!

[mollfpr]

@Ollyws Could you attach a video result of your proposal? Thanks!

[Ollyws]

@mollfpr Sure, it's easier to demonstrate on web:

Before:
https://github.com/Expensify/App/assets/11609254/c12f1e85-4df0-496b-b8c6-7e3ed40fe208

After:
https://github.com/Expensify/App/assets/11609254/27770ce8-347c-4df7-b382-e7ec9913962c

[Ollyws]

Also, if you're having trouble reproducing it on mWeb. Try selecting a fairly short virtual device (Pixel 2 for example).
In Google keyboard Settings > Preferences set Keyboard height to 'extra tall', then tap the GIF button when the keyboard is open:

Before video

pressgif_before.mp4

After video

pressgif_after.mp4

[flodnv]

@mollfpr what are your thoughts?

[mollfpr]

The result looks good, but I want to try the proposal on my local. @Ollyws Could you attach the code diff?

[Ollyws]

@mollfpr Sure. We might want to pass the styles as props to BaseOptionsSelector from WorkspaceInvitePage so they only apply to this instance of the component.

I also just noticed I put flexShrink1 instead of flexShrink0 in my proposal, so if you were having trouble reproducing it, my bad.

Code diff

diff --git a/src/components/OptionsSelector/BaseOptionsSelector.js b/src/components/OptionsSelector/BaseOptionsSelector.js
index 312f5d386b..3e9d3a6d56 100755
--- a/src/components/OptionsSelector/BaseOptionsSelector.js
+++ b/src/components/OptionsSelector/BaseOptionsSelector.js
@@ -322,7 +322,7 @@ class BaseOptionsSelector extends Component {
                         this.props.onLayout();
                     }
                 }}
-                contentContainerStyles={shouldShowFooter ? undefined : [this.props.safeAreaPaddingBottomStyle]}
+                contentContainerStyles={shouldShowFooter ? undefined : [this.props.safeAreaPaddingBottomStyle, styles.flex1, {flexBasis: 0}]}
                 isLoading={!this.props.shouldShowOptions}
             />
         );
diff --git a/src/pages/workspace/WorkspaceInvitePage.js b/src/pages/workspace/WorkspaceInvitePage.js
index a69c3fa7ee..f7acf278bd 100644
--- a/src/pages/workspace/WorkspaceInvitePage.js
+++ b/src/pages/workspace/WorkspaceInvitePage.js
@@ -274,7 +274,7 @@ class WorkspaceInvitePage extends React.Component {
                             shouldShowBackButton
                             onBackButtonPress={() => Navigation.goBack()}
                         />
-                        <View style={[styles.flex1]}>
+                        <View style={[styles.flexGrow1, styles.flexShrink0, styles.flexBasisAuto]}>
                             <OptionsSelector
                                 autoFocus={false}
                                 canSelectMultipleOptions

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[mollfpr]

Thanks @Ollyws for the diff code, it solves the issue. Now I am confident to bring forward the proposal.

@flodnv the proposal looks good to me!

🎀 👀 🎀 C+ reviewed!

[flodnv]

Thanks! Go for it @Ollyws 👍

[melvin-bot]

📣 @Ollyws You have been assigned to this job by @flodnv!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Ollyws]

All yours @mollfpr!

[mallenexpensify]

@Ollyws @mollfpr hired for the job, @usmantariq96 hired for reporting. Please accept
https://www.upwork.com/jobs/~01a873f4cf420dcd10

[usmantariq96]

@mallenexpensify applied with thanks

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.27-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix for: Mweb - Workspace - the "Next" button overlaps the input field for specific phone modal (Huawei P10 lite) #20345

If no regressions arise, payment will be issued on 2023-06-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
• [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mollfpr] Determine if we should create a regression test for this bug.
• [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mallenexpensify]

@Ollyws , can you please accept the job and reply here once you have? (there's two offers cuz I didn't see there was a pending one when I invited ya again)
https://www.upwork.com/jobs/~01a873f4cf420dcd10

[Ollyws]

@mallenexpensify Accepted the first one. Thanks!

[mollfpr]

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

No offending PR is causing this bug and this is very edge-case.

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

I don't think any checklist will cover this bug since it's related to specific devices.

[@mollfpr] Determine if we should create a regression test for this bug.

Yes!

[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Open Settings > Workspaces > Manage members > Invite > Invite New Members
2. Select the text input to open the keyboard
3. Verify that the 'Next' button does not overlap the text input
4. 👍 or 👎

[flodnv]

IDK, this feels very specific.... What I'm saying is that if we already have a test that does

1. Open Settings > Workspaces > Manage members > Invite > Invite New Members
2. Select the text input to open the keyboard

Then it's already covered. Let's ask QA @mollfpr @mallenexpensify ?

[mallenexpensify]

Going to treat this one as an edge case. I'll add this to our issue list that will be tested on a monthly basis.

For more context on edge cases, please check this thread.
Closing the issue - please reopen if needed."

Everyone is paid, no bonus - Hire/assign date was the 6th, PR merged on the 12th.