-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for: Mweb - Workspace - the "Next" button overlaps the input field for specific phone modal (Huawei P10 lite) #20345
Conversation
@Ollyws I tested Android on an emulator 2.7 QVGA, but the issue persisted even though it fixes on Web and Desktop. |
@mollfpr All fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on this @Ollyws and tests well 👍
Just a comment regarding the prop types and naming and we are good to go.
Reviewer Checklist
Screenshots/VideosWeb20345.Web.movMobile Web - Chrome20345.mWeb.Chrome.webmDesktop20345.Desktop.mov |
Co-authored-by: Luthfi <luthfi.ufi14@gmail.com>
@mollfpr All done! Edit: hmm hang on getting an error after those defaultProps. |
@mollfpr Sorry about that! Should be good to go now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well and all yours @flodnv
@mollfpr Just one more tiny thing. The listContainerStyles defaultProps should include |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/flodnv in version: 1.3.27-0 🚀
|
🚀 Deployed to staging by https://github.com/flodnv in version: 1.3.27-0 🚀
|
We currently don't have the Android device model from the original issues in the tester team. Would it be possible for @usmantariq96 to assist us with the QA for this one on the originally reported device. We will verify these steps on the other platforms as well. |
@isagoico Yes, sure I can help you with that. Please let me know when / what you want me to test. |
@usmantariq96 Would you be able to test this now or when possible? This PR is included in the current active Checklist and needs to be tested before the production deploy is triggered. |
Leaving our testing results here while we wait for the final confirmation of @usmantariq96 that this PR was a pass on his device.
|
VID-20230614-WA0027.mp4@isagoico please find attached required video. |
Nice! Looks like the overlapping is gone. Checking the PR off. |
🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.27-7 🚀
|
Details
Fixed Issues
$ #19740
PROPOSAL: #19740 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Linux_Chrome.mp4
Mobile Web - Chrome
Android_Chrome.mp4
Mobile Web - Safari
iOS_Safari.mp4
Desktop
MacOS_Desktop.mp4
iOS
iOS_Native.mp4
Android
Android_Native.mp4