Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-06-02 #20042

Closed
32 tasks done
OSBotify opened this issue Jun 2, 2023 · 16 comments
Closed
32 tasks done

Deploy Checklist: New Expensify 2023-06-02 #20042

OSBotify opened this issue Jun 2, 2023 · 16 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Jun 2, 2023

Release Version: 1.3.23-7
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jun 2, 2023
@OSBotify
Copy link
Contributor Author

OSBotify commented Jun 2, 2023

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.23-4 🚀

@OSBotify
Copy link
Contributor Author

OSBotify commented Jun 2, 2023

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.23-4 has been deployed to staging 🎉

@Julesssss
Copy link
Contributor

FYI to the lucky deployer next week, we faced some issues with the prod build release.

Please be aware that as of Friday the prod build is not running 1.3.23 but is two versions behind at 1.3.21 -- this is important to know when looking for potential bllockers, as the PR could also have been added here.

@mvtglobally
Copy link

@Julesssss We will still label anything we think could be blocker to be on the safer side and let new Deployer review it. This checklist will most likely be done by through the weekend

@mvtglobally
Copy link

Please tag us as the builds are completed. We are waiting for the build to start QA

@OSBotify
Copy link
Contributor Author

OSBotify commented Jun 2, 2023

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.23-5 🚀

@OSBotify
Copy link
Contributor Author

OSBotify commented Jun 2, 2023

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.23-5 has been deployed to staging 🎉

@OSBotify
Copy link
Contributor Author

OSBotify commented Jun 2, 2023

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.23-6 🚀

@OSBotify
Copy link
Contributor Author

OSBotify commented Jun 2, 2023

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.23-6 has been deployed to staging 🎉

@Julesssss
Copy link
Contributor

Julesssss commented Jun 5, 2023

Hey @mvtglobally, I think @AndrewGable has resolved the build issues now (based on this discussion), but please let us know if any builds remain missing!

@OSBotify
Copy link
Contributor Author

OSBotify commented Jun 5, 2023

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.23-7 🚀

@OSBotify
Copy link
Contributor Author

OSBotify commented Jun 5, 2023

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.23-7 has been deployed to staging 🎉

@mvtglobally
Copy link

@Julesssss we started with the build 1.3.23-6. Checking CPs now

@mvtglobally
Copy link

mvtglobally commented Jun 5, 2023

PR #19260 failing #20136
PR #19829 is failing #20135
PR #19851 is failing #19438 older ki

@Julesssss
Copy link
Contributor

Thank you!

Morning @roryabraham. Thankfully the CI issues from last week seem to be resolved 😍

Also, the only blocker has already been fixed and CP'd. But I'll leave it to you to check it off. More context here in Slack.

@roryabraham
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

5 participants