Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[No QA]Speed up deploys by turning on large runners" #20029

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Revert "[No QA]Speed up deploys by turning on large runners" #20029

merged 1 commit into from
Jun 2, 2023

Conversation

AndrewGable
Copy link
Contributor

Reverts #20015

@AndrewGable AndrewGable requested a review from roryabraham June 2, 2023 01:21
@AndrewGable AndrewGable requested a review from a team as a code owner June 2, 2023 01:21
@AndrewGable AndrewGable self-assigned this Jun 2, 2023
@melvin-bot melvin-bot bot removed the request for review from a team June 2, 2023 01:21
@melvin-bot
Copy link

melvin-bot bot commented Jun 2, 2023

@jasperhuangg Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested a review from jasperhuangg June 2, 2023 01:21
@AndrewGable
Copy link
Contributor Author

Skipping checklists to fix deploys as this previous PR breaks them.

@AndrewGable AndrewGable merged commit 37644c5 into main Jun 2, 2023
@AndrewGable AndrewGable deleted the revert-20015-andrew-turbo-button branch June 2, 2023 01:27
@melvin-bot
Copy link

melvin-bot bot commented Jun 2, 2023

@AndrewGable looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot bot added the Emergency label Jun 2, 2023
@AndrewGable
Copy link
Contributor Author

Straight revert and checklists were skipped to fix deploys as this previous PR breaks them.

@OSBotify
Copy link
Contributor

OSBotify commented Jun 2, 2023

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Jun 2, 2023
Closed
32 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Jun 2, 2023

🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.3.23-0 🚀

platform result
🤖 android 🤖 cancelled 🔪
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 cancelled 🔪

1 similar comment
@OSBotify
Copy link
Contributor

OSBotify commented Jun 2, 2023

🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.3.23-0 🚀

platform result
🤖 android 🤖 cancelled 🔪
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 cancelled 🔪

@OSBotify
Copy link
Contributor

OSBotify commented Jun 5, 2023

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.23-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

1 similar comment
@OSBotify
Copy link
Contributor

OSBotify commented Jun 5, 2023

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.23-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roryabraham roryabraham roryabraham approved these changes

@jasperhuangg jasperhuangg Awaiting requested review from jasperhuangg

Assignees

@AndrewGable AndrewGable

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndrewGable @OSBotify @roryabraham