-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove threads beta #19829
Remove threads beta #19829
Conversation
@abdulrahuman5196 @cristipaval One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
I don't have access to the issue in author's checklist. So just wanted to re-confirm as part of reviewers checklist, is the correct issue linked? And is threads already live everyone? And also could you mark if no console errors are present |
Yes, but I will create another one so that we can pay you through the normal process.
Yes
Done! |
Updated the issue to be public |
Thank you. Will work on review. |
Reviewer Checklist
Screenshots/VideosWebUntitled.43.mp4Mobile Web - Chromeaz_recorder_20230602_012243.mp4Mobile Web - SafariScreenRecording.movDesktopUntitled.41.mp4iOSUntitled.42.mp4AndroidUntitled.44.mp4 |
@stitesExpensify Kindly check the below in QA steps as well
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good and works well.
Reviewer's checklist is also complete
@cristipaval All yours.
🎯 @abdulrahuman5196, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #19999. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/cristipaval in version: 1.3.23-0 🚀
|
1 similar comment
🚀 Deployed to staging by https://github.com/cristipaval in version: 1.3.23-0 🚀
|
🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.23-7 🚀
|
1 similar comment
🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.23-7 🚀
|
Details
Just cleaning up now that threads are live for everyone
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/287240
$ #19840
PROPOSAL: n/a
Tests
Offline tests
n/a
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
2023-05-30_11-58-13.mp4
Mobile Web - Chrome
2023-05-30_12-07-41.mp4
Mobile Web - Safari
2023-05-30_12-02-51.mp4
Desktop
2023-05-30_11-59-42.mp4
iOS
2023-05-30_12-05-40.mp4
Android
2023-05-30_12-12-21.mp4