[HOLD for payment 2023-06-23] [HOLD for payment 2023-06-21] [$1000] mWeb - Chat - Cancel button must be pressed two times

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #20082

Action Performed:

1. Open http://staging.new.expensify.com/
2. Log in
3. Enter the chat with somebody
4. Edit message and change text
5. Close keyboard
6. Click the cancel button

Expected Result:

Cancel button must be pressed one time

Actual Result:

Cancel button must be pressed two times

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.27.2

Reproducible in staging?: yes

Reproducible in production?: no

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6091370_Screen_Recording_20230613_170710_Chrome.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01163231d12c885dff
• Upwork Job ID: 1668684207716220928
• Last Price Increase: 2023-06-13

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @thienlnam (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[HezekielT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat’s cancel button must be pressed twice to close it.

What is root cause of that problem?

It was introduced by #20082. The PR removed nativeID for cancel button while migrating the component to pressable feedback.

So when we click on the cancel button, the edit input loses focus and inside onBlur method we have the following condition which fails because the cancel button doesn’t have the native id meaning the onPress event of the cancel button will not be called as shown below.

App/src/pages/home/report/ReportActionItemMessageEdit.js

Lines 335 to 338 in 93957f0

	// Return to prevent re-render when save/cancel button is pressed which cancels the onPress event by re-rendering
	if (_.contains([this.saveButtonID, this.cancelButtonID, this.emojiButtonID], relatedTargetId)) {
	return;
	}

What Changes do you think we should make in order to solve the problem?

Add nativeID={this.cancelButtonID} in PressableWithFeedback of cancel button.

App/src/pages/home/report/ReportActionItemMessageEdit.js

Lines 284 to 286 in ede113d

	<PressableWithFeedback
	onPress={this.deleteDraft}
	style={styles.chatItemSubmitButton}

What alternative solutions did you explore? (Optional)

[thienlnam]

Thanks for the proposal @HezekielT - solution looks good to me and tests well. Could you get a PR up?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01163231d12c885dff

[melvin-bot]

Triggered auto assignment to @maddylewis (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[melvin-bot]

Current assignee @thienlnam is eligible for the External assigner, not assigning anyone new.

[HezekielT]

@thienlnam Yes, I will do that now.

[HezekielT]

@thienlnam PR is ready for review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.27-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix-mweb-chat-cancel-button-must-be-pressed-two-times #20704

If no regressions arise, payment will be issued on 2023-06-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[maddylewis]

moving to daily since payment is coming up!

[maddylewis]

apologies for the delay! reviewing this one now.

[maddylewis]

Payments:

• @allroundexperts C+ - $1000 (offer: https://www.upwork.com/nx/wm/offer/25226374)
• @HezekielT contributor - $1000 (offer: https://www.upwork.com/nx/wm/offer/25226405)

[maddylewis]

payments sent - is there anything else needed on this one before I close it out?

[HezekielT]

@maddylewis am i not eligible for the timeline bonus?

[allroundexperts]

@maddylewis This was merged the same day so the bonus is applicable here.

[maddylewis]

shoot - i wish you would've mentioned being eligible for a reporting bonus when i listed out the payment amounts here - #20682 (comment)

to clarify, @HezekielT was assigned on June 13 and the PR was merged on June 16, correct?

[HezekielT]

@maddylewis It was merged on June 14.

[maddylewis]

sent bonuses!

[HezekielT]

@maddylewis Thank you!

[maddylewis]

payments sent - i think we're all set here? closing.