-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix-mweb-chat-cancel-button-must-be-pressed-two-times #20704
Fix-mweb-chat-cancel-button-must-be-pressed-two-times #20704
Conversation
…must-be-pressed-two-times
@thienlnam @allroundexperts One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-06-14.at.12.27.57.AM.movMobile Web - ChromeScreen.Recording.2023-06-14.at.12.25.41.AM.movMobile Web - SafariScreen.Recording.2023-06-14.at.12.27.32.AM.movDesktopScreen.Recording.2023-06-14.at.12.30.37.AM.moviOSScreen.Recording.2023-06-14.at.12.26.06.AM.movAndroidScreen.Recording.2023-06-14.at.12.24.57.AM.mov |
|
@HezekielT Can you please upload the screen recordings on all the platforms? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add nativeId
as a prop to PressableWithFeedback
?
@allroundexperts Currently, I don't have access to mac that's why I didn't include iOS mWeb safari screen cast.Since the issue is deploy blocker I didn't want to wait.I would be grateful if I can use the screen cast of yours If that is acceptable. One more thing, since the issue is only occuring in mWeb, do we have to add a screen cast of native devices? |
do you mean in PressableWithFeedback.js ? |
This issue is occurring on native as well. |
Yes. |
Ok, I will add it. |
Ok, I will include the screen cast of android native. |
Please add the SS for web as well. You have to test on all platforms even if the issue occurs only on a single platform. We'll be skipping iOS screenshots for now since this is a deploy blocker but before taking on more issues, please make sure that you can test on ALL devices. |
Ok, I will do that. Thanks @allroundexperts |
@allroundexperts I have added the screen casts. |
@allroundexperts I have also added the props to PressableWithFeedback.js Please correct me if I'm wrong |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good.
cc @thienlnam
@allroundexperts I've updated the ios(native and safari) screencast part by using yours. |
…must-be-pressed-two-times
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
@thienlnam looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
Author does not have a mac and so we had C+ review those platforms since this is a blocker |
…utton-must-be-pressed-two-times (cherry picked from commit fb1aec2)
…-20704 🍒 Cherry pick PR #20704 to staging 🍒
🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.3.27-5 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.27-7 🚀
|
🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀
|
1 similar comment
🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀
|
Details
Fixed Issues
$ #20682
PROPOSAL: #20682 (comment)
Tests
Offline tests
Same as Tests Section
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
ScreencastWeb.mov
Mobile Web - Chrome
ScreenCast.mov
Mobile Web - Safari
iOS-Safari.mov
Desktop
ScreenCastDesktop.mov
iOS
iOS.mov
Android
ScreenCastAndroidNative.mov