The "Hmm... it's not here" page is displayed when attempting to view a profile after splitting the bill.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app and click on the plus sign, then choose "split bill".
2. Enter the desired amount and click on "Next".
3. Choose who you want to split with
4. Click on "split the bill" and click on the Profile. The detail section will appear on the right.
5. Click on the profile, but instead of displaying the profile details, the "Hmm... it's not here" page appears.

Expected Result:

Clicking on a profile after splitting the bill should display the profile details or images.

Actual Result:

Clicking on a profile after splitting the bill displays the "Hmm... it's not here" page instead of the profile details.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.29-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

screen-capture.15.webm

Recording.999.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686899440198109

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[BhuvaneshPatil]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The "Hmm... it's not here" page is displayed when attempting to view a profile after splitting the bill

What is the root cause of that problem?

We are using login in MoneyRequestConfirmationList.

App/src/components/MoneyRequestConfirmationList.js

Lines 236 to 241 in 83ab016

	const navigateToUserDetail = (option) => {
	if (!option.login) {
	return;
	}
	Navigation.navigate(ROUTES.getProfileRoute(ReportUtils.getAccountIDForLogin(option.login)));
	};

What changes do you think we should make in order to solve the problem?

We shall update the login to accountID as per new implementations.

What alternative solutions did you explore? (Optional)

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The "Hmm... it's not here" page is displayed when attempting to view a profile after splitting the bill.

What is the root cause of that problem?

Empty string gets passed for ReportUtils.getAccountIDForLogin(option.login) here as that function call won't work bcoz we are passing loginId here and inside function getAccountIDForLogin it is fetching from personalDetailsList onyx key which has the mapping with accountID's.

App/src/components/MoneyRequestConfirmationList.js

Lines 236 to 241 in bee8fd3

	const navigateToUserDetail = (option) => {
	if (!option.login) {
	return;
	}
	Navigation.navigate(ROUTES.getProfileRoute(ReportUtils.getAccountIDForLogin(option.login)));
	};

What changes do you think we should make in order to solve the problem?

We have the accountID here for the option object which we can use directly.

https://github.com/Expensify/App/blob/bee8fd3e1634fa11761435ef405a3d3efd654b07/src/components/MoneyRequestConfirmationList.js#LL240C2-L240C2

Navigation.navigate(ROUTES.getProfileRoute(option.accountID));

Also this condition can be updated with accountID.

App/src/components/MoneyRequestConfirmationList.js

Line 237 in bee8fd3

if (!option.login) {

!option.accountID

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[0xmiros]

@Beamanator this is the one I found while testing PR. Should be fixed now.

[Beamanator]

@0xmiroslav sorry it looks like you linked the PR twice, did you mean to link an issue?

[0xmiros]

@0xmiroslav sorry it looks like you linked the PR twice, did you mean to link an issue?

well first one is my comment which reported this issue
2nd one is PR which fixes this issue
comment is inside that PR 😀

[Beamanator]

Aahhh this is the "Also, there was another new issue happening on main" issue, yeah? Great, i'll make this not a deploy blocker 😬

@luacmartins whenever you see this, feel free to close if it's not reproducible (since it shouldn't be 🙏 )

[luacmartins]

I can't reproduce this, but I also see no emails/display names in the list

[0xmiros]

@luacmartins do you have clear reproducible step? I am not able to reproduce.

[luacmartins]

@0xmiroslav same as the OP.

[0xmiros]

I am not able to reproduce but instead __fake__ user appears. @Beamanator Is this being fixed somewhere?

Screen.Recording.2023-06-20.at.5.07.13.PM.mov

[0xmiros]

@luacmartins I think your issue has the same root cause as #21127

[Beamanator]

FYI...

I also see no emails/display names in the list

This was fixed earlier in PR: #21113

[luacmartins]

This specific issue has been fixed. We had other issues for the missing display names, etc. Closing.