[HOLD for payment 2023-07-12] [$1000] Web - Send money - The tab with Bank account and Debit card is in the middle Cash page #21259

lanitochka17 · 2023-06-21T20:04:22Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to staging.new.expensify.com
Log in any account
Open any chat
Click on the + button in the compose box
Choose Send money
Enter amount
Click Pay with Expensify

Expected Result:

The tab should be at the bottom

Actual Result:

The tab with Bank account and Debit card is in the middle Cash page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.30.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6101806_Recording__2683.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0164181e7781294f63
Upwork Job ID: 1673785107250982912
Last Price Increase: 2023-06-27

melvin-bot · 2023-06-21T20:04:27Z

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-06-21T20:04:29Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Pujan92 · 2023-06-21T20:30:53Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Send money - The popover with Bank account and Debit card is in the middle Cash page

What is the root cause of that problem?

Seems the anchorPositionVertical here assigned the wrong value here.

App/src/components/KYCWall/BaseKYCWall.js

Line 72 in 9e8a151

anchorPositionVertical: domRect.top - 150,

What changes do you think we should make in order to solve the problem?

We should take out the - 150 from the anchorPositionVertical or reduce it to - 8 which will reduce the distance from the top.
anchorPositionVertical: domRect.top, OR anchorPositionVertical: domRect.top - 8,

alexpensify · 2023-06-23T15:47:35Z

This is on my test list

alexpensify · 2023-06-26T04:46:54Z

I've requested a test account to be added to the beta and will test it soon

melvin-bot · 2023-06-27T20:07:23Z

Job added to Upwork: https://www.upwork.com/jobs/~0164181e7781294f63

melvin-bot · 2023-06-27T20:07:27Z

Current assignee @alexpensify is eligible for the External assigner, not assigning anyone new.

melvin-bot · 2023-06-27T20:07:32Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

alexpensify · 2023-06-27T20:07:57Z

Assigning External, Tom helped me confirm that this is an issue:

melvin-bot · 2023-06-27T20:08:43Z

Triggered auto assignment to @shawnborton (Design), see these Stack Overflow questions for more details.

alexpensify · 2023-06-27T20:09:21Z

Adding the Design label too for feedback to confirm this should be above the button -- thank you!

alexpensify · 2023-06-27T20:09:50Z

For reference, when you click the downcaret in the button for the settlement options menu it's here:

shawnborton · 2023-06-27T20:10:58Z

I think the menu should launch just right above the green button, like 8px above it or something.

alexpensify · 2023-06-27T20:12:33Z

Ok, I'll remove your assignment since we are set on the Design feedback.

alexpensify · 2023-06-27T20:14:58Z

@Santhosh-Sellavel - when you get a chance, can you review the proposal that was shared here:

#21259 (comment)

Thank you!

alitoshmatov · 2023-06-29T15:13:01Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Send money - The tab with Bank account and Debit card is in the middle Cash page

What is the root cause of that problem?

When ac1a3ef was applied expected behavior changed, before it was anchorPositionTop and was was changed to anchorPositionVertical which resulted in different behavior since default anchorAlignment was bottom.

App/src/components/PopoverMenu/index.js

Lines 35 to 38 in 05f289b

    
           anchorAlignment: { 
        
               horizontal: CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.LEFT, 
        
               vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.BOTTOM, 
        
           },

To sum up anchor position was in top of element before and after changes it was in bottom of element.

What changes do you think we should make in order to solve the problem?

We should rewrite computation of anchor position considiring above matter

App/src/components/KYCWall/BaseKYCWall.js

Lines 72 to 73 in ef52c5d

    
           anchorPositionVertical: domRect.top - 150, 
        
           anchorPositionHorizontal: domRect.left,

anchorPositionVertical: domRect.top - 8,

What alternative solutions did you explore? (Optional)

Santhosh-Sellavel · 2023-06-29T20:43:12Z

@Pujan92's proposal looks good to me!

C+ Reviewed
🎀 👀 🎀

melvin-bot · 2023-07-05T16:58:04Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-07-05T16:58:05Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.36-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix: Web - Send money - The tab with Bank account and Debit card is in the middle Cash page #21980

If no regressions arise, payment will be issued on 2023-07-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-07-05T16:58:07Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR:
[@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@Santhosh-Sellavel] Determine if we should create a regression test for this bug.
[@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@alexpensify / @lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

alexpensify · 2023-07-10T21:02:45Z

Alright, removing the other 🐛 team member. I'm back online and see that this is our current state:

Prepare for payment

alexpensify · 2023-07-11T19:29:50Z

@Santhosh-Sellavel / @Pujan92 - to prepare for payment tomorrow, please apply for this job:

https://www.upwork.com/jobs/~0164181e7781294f63

Thank you!

Pujan92 · 2023-07-11T19:34:36Z

Applied @alexpensify , Thanks!

Santhosh-Sellavel · 2023-07-11T19:41:25Z

@alexpensify I will collect via NewDot!

alexpensify · 2023-07-12T22:42:59Z

@Pujan92 - I've prepared the payment in Upwork.

Pujan92 · 2023-07-13T01:55:35Z

@Pujan92 - I've prepared the payment in Upwork.

@alexpensify accepted, Thanks.

alexpensify · 2023-07-13T19:12:06Z

Alright, @Pujan92 has been paid via Upwork!

alexpensify · 2023-07-13T19:13:12Z

@Santhosh-Sellavel - can you please complete the check list and then I can close this GH. Thank you!

#21259 (comment)

dostongulmatov · 2023-07-13T19:24:14Z

Could you please somebody answer my question here, #21259 (comment)

Santhosh-Sellavel · 2023-07-13T20:32:20Z

@alexpensify I will complete it over the weekend, and collect my dues. Caught up with other Priority items. Thanks!

Santhosh-Sellavel · 2023-07-13T20:35:29Z

Could you please somebody answer my question here, #21259 (comment)

@alexpensify I think they are eligible for reporting bonus, please have a look and issue them thanks!

alexpensify · 2023-07-13T21:12:59Z

Thanks for flagging, I'm reviewing the timeline and will follow up tomorrow regarding the reporting bonus concerns.

dostongulmatov · 2023-07-13T23:52:57Z

@alexpensify thank you

Santhosh-Sellavel · 2023-07-14T20:02:30Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR: Add pay button to money request header #18692

[@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/18692/files#r1264102939

[@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No updated need, should have been caught during reviewer testing based on the checklist.

[@Santhosh-Sellavel] Determine if we should create a regression test for this bug. No need, applause had caught this, they might cases for this already!

[@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

[@alexpensify / @lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

cc: @cristipaval Let me know if you differ on any of the above!

alexpensify · 2023-07-14T20:57:41Z

@dostongulmatov - I've started the process in Upwork for the payment since I see you did report this one. It might have gotten lost in the shuffle but please accept. After, I can complete the payment process. Thanks!

dostongulmatov · 2023-07-14T21:21:14Z

@alexpensify thank you very much accepted the payment

alexpensify · 2023-07-14T21:51:32Z

Awesome, I've completed the payment process via Upwork!

Santhosh-Sellavel · 2023-07-14T21:53:37Z

Requested Payment on ND

alexpensify · 2023-07-16T16:29:36Z

Thank you for that update. I closed the job in Upwork and am going to close this GH. Great work team!

anmurali · 2023-07-18T18:06:06Z

Approved $1500 (with bonus) for Santhosh

lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 21, 2023

melvin-bot bot assigned alexpensify Jun 21, 2023

alexpensify added the External Added to denote the issue can be worked on by a contributor label Jun 27, 2023

melvin-bot bot changed the title ~~Web - Send money - The tab with Bank account and Debit card is in the middle Cash page~~ [$1000] Web - Send money - The tab with Bank account and Debit card is in the middle Cash page Jun 27, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 27, 2023

melvin-bot bot assigned Santhosh-Sellavel Jun 27, 2023

alexpensify added the Design label Jun 27, 2023

melvin-bot bot assigned shawnborton Jun 27, 2023

alexpensify removed the Design label Jun 27, 2023

alexpensify unassigned shawnborton Jun 27, 2023

Pujan92 mentioned this issue Jun 29, 2023

Web- Send money - Pay with expensify Popover is positioned in correctly #21868

Closed

6 tasks

melvin-bot bot assigned cristipaval Jun 29, 2023

melvin-bot bot removed the Reviewing Has a PR in review label Jul 5, 2023

alexpensify unassigned lschurr Jul 10, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 11, 2023

Santhosh-Sellavel mentioned this issue Jul 14, 2023

Add pay button to money request header #18692

Merged

56 tasks

alexpensify closed this as completed Jul 16, 2023

Nikhil-Vats mentioned this issue Jul 19, 2023

[HOLD for payment 2023-08-16] [$1000] On request money report clicking the down arrow on options to pay with expensify hides the entire button #23140

Closed

6 tasks

[HOLD for payment 2023-07-12] [$1000] Web - Send money - The tab with Bank account and Debit card is in the middle Cash page #21259

[HOLD for payment 2023-07-12] [$1000] Web - Send money - The tab with Bank account and Debit card is in the middle Cash page #21259

Comments

lanitochka17 commented Jun 21, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Jun 21, 2023

melvin-bot bot commented Jun 21, 2023

Bug0 Triage Checklist (Main S/O)

Pujan92 commented Jun 21, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

alexpensify commented Jun 23, 2023

alexpensify commented Jun 26, 2023 • edited Loading

melvin-bot bot commented Jun 27, 2023

melvin-bot bot commented Jun 27, 2023

melvin-bot bot commented Jun 27, 2023

alexpensify commented Jun 27, 2023

melvin-bot bot commented Jun 27, 2023

alexpensify commented Jun 27, 2023

alexpensify commented Jun 27, 2023

shawnborton commented Jun 27, 2023

alexpensify commented Jun 27, 2023

alexpensify commented Jun 27, 2023

alitoshmatov commented Jun 29, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Santhosh-Sellavel commented Jun 29, 2023

melvin-bot bot commented Jul 5, 2023

melvin-bot bot commented Jul 5, 2023

melvin-bot bot commented Jul 5, 2023 • edited by alexpensify Loading

alexpensify commented Jul 10, 2023

alexpensify commented Jul 11, 2023

Pujan92 commented Jul 11, 2023

Santhosh-Sellavel commented Jul 11, 2023

alexpensify commented Jul 12, 2023

Pujan92 commented Jul 13, 2023

alexpensify commented Jul 13, 2023

alexpensify commented Jul 13, 2023

dostongulmatov commented Jul 13, 2023

Could you please somebody answer my question here, #21259 (comment)

Santhosh-Sellavel commented Jul 13, 2023

Santhosh-Sellavel commented Jul 13, 2023

Could you please somebody answer my question here, #21259 (comment)

alexpensify commented Jul 13, 2023

dostongulmatov commented Jul 13, 2023

Santhosh-Sellavel commented Jul 14, 2023 • edited Loading

alexpensify commented Jul 14, 2023

dostongulmatov commented Jul 14, 2023

alexpensify commented Jul 14, 2023

Santhosh-Sellavel commented Jul 14, 2023

alexpensify commented Jul 16, 2023

anmurali commented Jul 18, 2023

lanitochka17 commented Jun 21, 2023 •

edited by melvin-bot bot

Loading

Pujan92 commented Jun 21, 2023 •

edited

Loading

alexpensify commented Jun 26, 2023 •

edited

Loading

melvin-bot bot commented Jul 5, 2023 •

edited by alexpensify

Loading

Santhosh-Sellavel commented Jul 14, 2023 •

edited

Loading