Add pay button to money request header #18692

iwiznia · 2023-05-09T22:37:06Z

Details

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/270704
PROPOSAL: GH_LINK_ISSUE(COMMENT)

Tests

Create a workspace and invite a user
With the invited user, request money in the workspace chat
Go to the report that was created for this request, check the header does not show the pay button:

- With the owner of the workspace, open the request report and check the pay button is there:

- Check you can see the 2 options to pay it:

- Click `Pay with expensify`, check you get redirected to add a bank account

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

N/A Merging to get it deployed for EC3. I did a lot of testing while developing.

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

src/libs/actions/IOU.js

src/components/MoneyRequestHeader.js

src/libs/actions/IOU.js

Fix measureInWindow

src/components/ButtonWithDropdownMenu.js

…-18692 🍒 Cherry pick PR #18692 to staging 🍒

mvtglobally · 2023-05-18T01:30:16Z

@iwiznia @yuwenmemon Is this expected? as per steps the header should now show "Go to the report that was created for this request, check the header does NOT show the pay button:"

Recording.2755.mp4

luacmartins · 2023-05-18T01:40:08Z

@mvtglobally that is expected since the user in the video is the owner/admin of that workspace (they created the workspace). The invited user is the one who shouldn't see the pay button.

mvtglobally · 2023-05-18T01:56:00Z

Is this expected?

luacmartins · 2023-05-18T02:01:53Z

answered in Slack

OSBotify · 2023-05-18T02:26:38Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.3.15-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

aimane-chnaif · 2023-05-18T04:44:14Z

This PR caused several invalid prop type errors. Need to be fixed as a follow-up

Screen.Recording.2023-05-18.at.5.41.50.AM.mov

OSBotify · 2023-05-18T06:49:38Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.15-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Julesssss · 2023-05-18T08:05:26Z

This PR caused several invalid prop type errors. Need to be fixed as a follow-up

Hey @aimane-chnaif, did you report this as a bug? I'll assign you this follow up PR if you'd like.

aimane-chnaif · 2023-05-18T08:07:20Z

Hey @aimane-chnaif, did you report this as a bug? I'll assign you this follow up PR if you'd like.

@Julesssss Not reported yet. yes, I'd like to fix

Julesssss · 2023-05-18T08:15:33Z

Cool, just post it in the #expensify-bugs Slack channel and link me. I'll create the issue

Update: issue

mountiny · 2023-05-23T19:30:30Z

src/libs/actions/IOU.js

-function payMoneyRequestWithWallet(chatReport, iouReport, recipient) {
-    const {params, optimisticData, successData, failureData} = getPayMoneyRequestParams(chatReport, iouReport, recipient, CONST.IOU.PAYMENT_TYPE.EXPENSIFY);
-
-    API.write('PayMoneyRequestWithWallet', params, {optimisticData, successData, failureData});
-
-    Navigation.navigate(ROUTES.getReportRoute(chatReport.reportID));
-}


This should not have been removed

More context please? This function among others were simplified into one payMoneyRequest.

That's what the design doc said: https://docs.google.com/document/d/17jFcMsAotXvsMhXivoF3u7fyzeyXkKpRGXR88Ud0oWY/edit#bookmark=kix.injnd2mh0afm

I'm re-adding it as a part of https://github.com/Expensify/Expensify/issues/285824, will have a PR up on there today

rushatgabhane · 2023-05-30T10:36:22Z

src/components/PopoverMenu/index.js

+    const selectItem = (index) => {
+        const selectedItem = props.menuItems[index];
+        props.onItemSelected(selectedItem);
+        selectedItem.onSelected();


Beep boop 🤖 🐧

Dropping a friendly note here that we caused a regression - iOS - Some Popover buttons not) working

We're calling selectedItem.onSelected() here, which is called when the MenuItem is pressed.

For the case of 'Upload photo', 'Add attachment' etc menu items, when the button is pressed it will open another modal.

When the current PopoverMenu modal doesn't hide completely yet, 2 modals opening at the same time will cause screen freezing in iOS, and the second modal will not show.

The fix was to call this function when the menu closes.

OSBotify · 2023-06-15T01:28:21Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-06-16T18:46:10Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Santhosh-Sellavel · 2023-06-20T17:28:37Z

src/components/PopoverMenu/index.js

+            anchorPosition={props.anchorPosition}
+            anchorAlignment={props.anchorOrigin}


This PR caused a regression #19453
We are passing the wrong prop here anchorAlignment={props.anchorOrigin} should be anchorAlignment={props.anchorAlignment} More detail #19453 (comment)

s77rt · 2023-06-21T19:11:31Z

src/components/ButtonWithDropdownMenu.js

+    useEffect(() => {
+        if (!caretButton.current) {
+            return;
+        }
+        caretButton.current.measureInWindow((x, y, w, h) => {
+            setPopoverAnchorPosition({
+                horizontal: x + w,
+                vertical: y + h,
+            });
+        });
+    }, [windowWidth, windowHeight]);
+


This caused a regression #20262. The popover position is calculated too early at the first render where animation is not done yet (position is not stable yet).

Santhosh-Sellavel · 2023-07-14T20:00:18Z

src/components/KYCWall/BaseKYCWall.js

+            anchorPositionVertical: domRect.top - 150,
+            anchorPositionHorizontal: domRect.left,
        };


This change caused a regression here. anchorPositionVertical value was not set correctly here after moving from anchorPositionTop, we updated it correctly here

Start working on money request header

0d9213e

iwiznia self-assigned this May 9, 2023

iwiznia added 4 commits May 11, 2023 18:46

Merge branch 'main' into ionatan_payheader

bd575fb

Refactor calls to api

5e93f1f

Pass policyID when needed

0d9a80d

Add missing prop

e60ff26

iwiznia commented May 11, 2023

View reviewed changes

src/libs/actions/IOU.js Outdated Show resolved Hide resolved

iwiznia requested review from luacmartins and mountiny May 11, 2023 23:32

luacmartins requested changes May 12, 2023

View reviewed changes

Lint, hide button for the person that's owed

7af54a9

iwiznia changed the title ~~Start working on money request header~~ [HOLD web] Start working on money request header May 12, 2023

iwiznia changed the title ~~[HOLD web] Start working on money request header~~ [HOLD web] Add pay button to money request header May 12, 2023

iwiznia and others added 5 commits May 12, 2023 16:12

Remove useless componentButtonWithDropdown

8f41a21

Convert to functional and try to use measureInWindow

dbe3ad3

Merge main

17d4d80

Fix measureInWindow

6b3f7b2

Merge pull request #18868 from Expensify/Rory-FixMeasureInWindowV2

7e189ea

Fix measureInWindow

roryabraham reviewed May 12, 2023

View reviewed changes

src/components/ButtonWithDropdownMenu.js Outdated Show resolved Hide resolved

iwiznia and others added 11 commits May 12, 2023 18:46

Tweak logic and positioning

3f7b823

Trying to positiong the popover correctly

1f196bc

Create useArrowKeyFocusManager hook

9de7b5f

Make useArrowKeyFocusManager more powerful and easy to use

c35e14d

Add isActive prop to useKeyboardShortcut

887a89c

Create useWindowDimensions hook

43b07b2

Get popover displaying in the correct place

a64b767

fix useKeyboardShortcut cleanup

25d53a7

Remove unnecessary measureContent prop from PopoverWithMeasuredContent

659d888

Fix comment indentation

630a358

Add JSdocs in useArrowKeyFocusManager

4c548fb

OSBotify added a commit that referenced this pull request May 18, 2023

Merge pull request #19169 from Expensify/OSBotify-cherry-pick-staging…

1225c39

…-18692 🍒 Cherry pick PR #18692 to staging 🍒

OSBotify mentioned this pull request May 18, 2023

Deploy Checklist: New Expensify 2023-05-16 #19088

Closed

71 tasks

mvtglobally mentioned this pull request May 18, 2023

IOU - App is crashing when Settle Elsewhere #19171

Closed

6 tasks

Prince-Mendiratta mentioned this pull request May 18, 2023

[HOLD for payment 2023-06-02] [$1000] Remove IOUDetailsModal component #19167

Closed

OSBotify mentioned this pull request May 18, 2023

Deploy Checklist: New Expensify 2023-05-18 #19175

Closed

39 tasks

mountiny reviewed May 23, 2023

View reviewed changes

huzaifa-99 mentioned this pull request May 23, 2023

[HOLD for payment via Newdot] [$1000] Web - Popover is covering the profile photo #19453

Closed

6 tasks

rushatgabhane reviewed May 30, 2023

View reviewed changes

rushatgabhane mentioned this pull request May 30, 2023

[HOLD for payment 2023-05-29] [$1000] iOS/iPad - Buttons to add attachments, delete workspace, and upload an avatar are unrepsonsive #19310

Closed

6 tasks

s77rt mentioned this pull request Jun 9, 2023

[HOLD for payment 2023-06-28] [$1000] Web - Web- Send money - Green payment button is partially visible #20262

Closed

6 tasks

OSBotify mentioned this pull request Jun 15, 2023

Deploy Checklist: New Expensify 2023-06-14 #20782

Closed

Santhosh-Sellavel reviewed Jun 20, 2023

View reviewed changes

s77rt reviewed Jun 21, 2023

View reviewed changes

Santhosh-Sellavel reviewed Jul 14, 2023

View reviewed changes

Santhosh-Sellavel mentioned this pull request Jul 14, 2023

[HOLD for payment 2023-07-12] [$1000] Web - Send money - The tab with Bank account and Debit card is in the middle Cash page #21259

Closed

6 tasks

fedirjh mentioned this pull request Jul 30, 2023

[HOLD for payment 2023-07-28] Payment method not sticky in the expenseReport view. #22585

Closed

6 tasks

s77rt mentioned this pull request Oct 23, 2023

[HOLD for payment 2023-10-30] [$500] [P2P Activation] [HIGH] Pay button in the workspace / DM view is different from the report view #29735

Closed

6 tasks

allroundexperts mentioned this pull request Feb 17, 2024

[$500] Web - Expense - Approve button is displayed on the conversation preview, but not on report #34853

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add pay button to money request header #18692

Add pay button to money request header #18692

iwiznia commented May 9, 2023 •

edited by luacmartins

Loading

mvtglobally commented May 18, 2023 •

edited

Loading

luacmartins commented May 18, 2023

mvtglobally commented May 18, 2023

luacmartins commented May 18, 2023

OSBotify commented May 18, 2023

aimane-chnaif commented May 18, 2023

OSBotify commented May 18, 2023

Julesssss commented May 18, 2023

aimane-chnaif commented May 18, 2023

Julesssss commented May 18, 2023 •

edited

Loading

mountiny May 23, 2023

s77rt May 23, 2023

iwiznia May 23, 2023

bondydaa May 23, 2023

rushatgabhane May 30, 2023 •

edited

Loading

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

Santhosh-Sellavel Jun 20, 2023

s77rt Jun 21, 2023

Santhosh-Sellavel Jul 14, 2023

		anchorPosition={props.anchorPosition}
		anchorAlignment={props.anchorOrigin}

Add pay button to money request header #18692

Add pay button to money request header #18692

Conversation

iwiznia commented May 9, 2023 • edited by luacmartins Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

mvtglobally commented May 18, 2023 • edited Loading

luacmartins commented May 18, 2023

mvtglobally commented May 18, 2023

luacmartins commented May 18, 2023

OSBotify commented May 18, 2023

aimane-chnaif commented May 18, 2023

OSBotify commented May 18, 2023

Julesssss commented May 18, 2023

aimane-chnaif commented May 18, 2023

Julesssss commented May 18, 2023 • edited Loading

mountiny May 23, 2023

Choose a reason for hiding this comment

s77rt May 23, 2023

Choose a reason for hiding this comment

iwiznia May 23, 2023

Choose a reason for hiding this comment

bondydaa May 23, 2023

Choose a reason for hiding this comment

rushatgabhane May 30, 2023 • edited Loading

Choose a reason for hiding this comment

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

Santhosh-Sellavel Jun 20, 2023

Choose a reason for hiding this comment

s77rt Jun 21, 2023

Choose a reason for hiding this comment

Santhosh-Sellavel Jul 14, 2023

Choose a reason for hiding this comment

iwiznia commented May 9, 2023 •

edited by luacmartins

Loading

mvtglobally commented May 18, 2023 •

edited

Loading

Julesssss commented May 18, 2023 •

edited

Loading

rushatgabhane May 30, 2023 •

edited

Loading