[HOLD for payment 2023-07-10] [$1000] Profile- Hidden profile name displayed for few seconds

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #21081

Action Performed:

1. From test account A, click the user avatar icon (a.k.a. Settings button) and select "Share code > Copy URL to Clipboard"
2. In an incognito window, paste the URL, making sure to change it to staging. Log in as test user B
3. Verify that test user B see's test user A's profile and avatar

Expected Result:

Test user B see's test user A's profile and avatar

Actual Result:

Hidden profile displayed for few seconds and later profile displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.32.5

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6106775_21081_mWeb.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010882a383cd90ec38
• Upwork Job ID: 1673620519289159680
• Last Price Increase: 2023-06-27

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[thienlnam]

cc @Beamanator Looks related to the privacy / changes

[Beamanator]

Looks like this has to do with #21081 or #21286

Not caused by Onyx re-key though 😬 I'm happy to take this one & mark external though, should probably be an easy fix

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010882a383cd90ec38

[melvin-bot]

Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[rain2o]

Proposal

Please re-state the problem that we are trying to solve in this issue.

While loading a profile, we display "Hidden" instead of a loading indicator.

What is the root cause of that problem?

As mentioned in this comment, this is a result of #21286 . Specifically, this line in ProfilePage.js

const details = lodashGet(props.personalDetails, accountID, {isLoading: ValidationUtils.isValidAccountRoute(accountID)});

We are overwriting isLoading from personalDetails.

What changes do you think we should make in order to solve the problem?

We should update that line to only overwrite isLoading if the account ID is invalid, not always.

const details = lodashGet(
    props.personalDetails,
    accountID,
    ValidationUtils.isValidAccountRoute(accountID) ? {} : {isloading: false},
);

[narefyev91]

Proposal from @rain2o looks good to me #21571 (comment)
🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @stitesExpensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[stitesExpensify]

LGTM!

[melvin-bot]

📣 @rain2o You have been assigned to this job by @stitesExpensify!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[rain2o]

Applied in Upwork.

I should have a PR ready for review by tomorrow. I expect today, but as this is my first one for Expensify, I'm giving myself some padding to make sure I can get through all the steps correctly.

[melvin-bot]

🎯 ⚡️ Woah @narefyev91 / @rain2o, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @rain2o got assigned: 2023-06-27 15:27:43 Z
• when the PR got merged: 2023-06-28 15:49:07 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.35-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Override isLoading only if accountID is invalid #21722

If no regressions arise, payment will be issued on 2023-07-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@narefyev91] The PR that introduced the bug has been identified. Link to the PR:
• [@narefyev91] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@narefyev91] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@narefyev91] Determine if we should create a regression test for this bug.
• [@narefyev91] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[stitesExpensify]

Looks like we just need the checklists done and then we can pay this out!

[mallenexpensify]

@narefyev91 , can you complete the checklist above plz?
@rain2o , can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~010882a383cd90ec38

[narefyev91]

• The PR that introduced the bug has been identified. Link to the PR - Override isLoading only if accountID is invalid #21722
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment - no comments addressed
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion - no discussion happened
• Determine if we should create a regression test for this bug - we are good with QA steps in the issue

[rain2o]

@rain2o , can you please accept the job and reply here once you have? https://www.upwork.com/jobs/~010882a383cd90ec38

@mallenexpensify I just have 1 question (sent in Upwork too), as this is my first time working with Expensify I want to make sure I understand correctly. As far as I'm aware, this bug qualifies for the 50% urgency bonus. Should the offer be for the total including that bonus?

[rain2o]

@mallenexpensify got my question answered on slack and accepted the offer.

[melvin-bot]

@rain2o, @mallenexpensify, @narefyev91, @stitesExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mallenexpensify]

@rain2o paid $1500, inc. timeliness bonus.

TestRail update GH https://github.com/Expensify/Expensify/issues/300492

@narefyev91 in the future can you copy/paste the QA steps into the issue comment? It'll save a bit of time (and I'm assuming you're checking them to ensure they're accurate), thanks.