Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-10-24] [ECard Settings] - Allow users to update the card address via “Update address” link #22876

Closed
grgia opened this issue Jul 14, 2023 · 23 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2

Comments

@grgia
Copy link
Contributor

grgia commented Jul 14, 2023

HOLD ON #22875

Design Doc Section

https://docs.google.com/document/d/1rFxJ78vz5On6zSWzYa51B9v-tyLdC5pUsBeLOLig0t4/edit#bookmark=id.22f8lolqi418

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c19b21da848eb3a6
  • Upwork Job ID: 1679791069863567360
  • Last Price Increase: 2023-07-14
@grgia grgia added the Internal Requires API changes or must be handled by Expensify staff label Jul 14, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 14, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01c19b21da848eb3a6

@melvin-bot
Copy link

melvin-bot bot commented Jul 14, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @narefyev91 (Internal)

@melvin-bot melvin-bot bot added the Monthly KSv2 label Jul 17, 2023
@grgia
Copy link
Contributor Author

grgia commented Aug 31, 2023

cc @pac-guerreiro

@melvin-bot melvin-bot bot added the Overdue label Aug 31, 2023
@pac-guerreiro
Copy link
Contributor

Could you assign me to this @grgia ? 😄

@marcaaron marcaaron added the Daily KSv2 label Aug 31, 2023
@melvin-bot melvin-bot bot removed the Overdue label Aug 31, 2023
@marcaaron marcaaron removed the Monthly KSv2 label Aug 31, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 4, 2023

@narefyev91, @pac-guerreiro Whoops! This issue is 2 days overdue. Let's get this updated quick!

@MrMuzyk
Copy link
Contributor

MrMuzyk commented Sep 12, 2023

I am Michał from Callstack - expert contributor group. I’d like to work on this job.

@melvin-bot
Copy link

melvin-bot bot commented Sep 12, 2023

📣 @MrMuzyk! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@melvin-bot
Copy link

melvin-bot bot commented Sep 12, 2023

@narefyev91, @pac-guerreiro 10 days overdue. Is anyone even seeing these? Hello?

@melvin-bot
Copy link

melvin-bot bot commented Sep 18, 2023

@MrMuzyk, @narefyev91 Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Sep 18, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 20, 2023

@MrMuzyk, @narefyev91 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@melvin-bot
Copy link

melvin-bot bot commented Sep 22, 2023

@MrMuzyk, @narefyev91 Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

@melvin-bot
Copy link

melvin-bot bot commented Sep 26, 2023

@MrMuzyk, @narefyev91 12 days overdue now... This issue's end is nigh!

@grgia grgia self-assigned this Sep 27, 2023
@grgia
Copy link
Contributor Author

grgia commented Sep 27, 2023

In progress

@melvin-bot melvin-bot bot removed the Overdue label Oct 4, 2023
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Oct 5, 2023
@joekaufmanexpensify joekaufmanexpensify changed the title [HOLD #22875][ECard Settings] - Allow users to update the card address via “Update address” link [ECard Settings] - Allow users to update the card address via “Update address” link Oct 5, 2023
@joekaufmanexpensify
Copy link
Contributor

@narefyev91 do you think you'll be able to review this today?

@narefyev91
Copy link
Contributor

@narefyev91 do you think you'll be able to review this today?

Today unfortunately no - it's already late in my timezone - i can prioritise as a first item in the morning tomorrow

@joekaufmanexpensify
Copy link
Contributor

Sounds good, ty!

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 17, 2023
@melvin-bot melvin-bot bot changed the title [ECard Settings] - Allow users to update the card address via “Update address” link [HOLD for payment 2023-10-24] [ECard Settings] - Allow users to update the card address via “Update address” link Oct 17, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 17, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 17, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Oct 17, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.85-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-24. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

  • @MrMuzyk does not require payment (Contractor)
  • @narefyev91 does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Oct 24, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 27, 2023

@MrMuzyk, @narefyev91, @grgia Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot
Copy link

melvin-bot bot commented Oct 31, 2023

@MrMuzyk, @narefyev91, @grgia 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@grgia grgia closed this as completed Oct 31, 2023
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Overdue Daily KSv2 Weekly KSv2 labels Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants