forked from Expensify/App
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 22876 allow users to update the card address via update address link #7
Closed
MrMuzyk
wants to merge
1,826
commits into
JKobrynski:addRevealDetails
from
MrMuzyk:feat-22876-allow-users-to-update-the-card-address-via-update-address-link
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
157d190
to
8adb129
Compare
…t-another-country
update 'chooseFile' translation in en.ts
…eld-is-not-clear-when-select-another-country Fix/28007: City field is not clear when choosing new country
added coordinates in get bounds
…ign-in-console-error Fix console error on visiting /sign-in-with-google
Removed comments
…e-IdologyQuestions-to-function-component refactor: migrated IdologyQuestions to the function component
…usto.md Co-authored-by: Rocio Perez-Cano <pecanoro@users.noreply.github.com>
…x_outline Fix checkbox outline in TaskView
[HelpDot] Fix redirect on github pages
Make the logic for money request options in composer quick actions more robust
…ase-inverted-flat-list-file-to-function-component
Add images to ExpensifyHelp
…or/16161/hoverable-class-to-functional
fix: Web - Members page search bar does not get focused
…ill-can-remove-invalid-phone-number Fix/27773: User still can remove invalid member
…er-warning Fix useFlipper warning
Add margin between unread marker and the created action
…ce-persistedRequests [CP Staging] fix persisted request
…eipt [CP Staging] fix: Distance - App crashes when tapping on the receipt thumbnail while receipt is generating
Fix LHN popover showing in Report screen
[NoQA] Access the paymentType of report action safely
Fix regression task preview
Setup Cloudflare Pages for Docs Preview
Fix auto scroll when the display name is changed
…gestion-list Fix scroll behind suggestion list when scrolling on suggestion popup
…alidate-blur-password-pdf remove validate when blur
…g-popover-again Fix: Hover effect lost after opening popover again before closing it
Fix: Approved requests shouldn't have a delete option
…tch-1 Update Consolidated-Domain-Billing.md
…for-prettier Remove part that says Expensify doesn't use Prettier in README
fix: 28354 Report screen becomes empty when resizing to big size from LHN
Fix LHN is disappeared when leaving thread
…sers-to-update-the-card-address-via-update-address-link
JKobrynski
pushed a commit
that referenced
this pull request
Oct 18, 2023
Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Draft PR for 22876
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android