-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-11-02] [ECARD] CRITICAL: Settings - Add API Calls when clicking “Reveal details” buttons. #22875
Comments
Job added to Upwork: https://www.upwork.com/jobs/~01bd97f7877e21ceed |
Triggered auto assignment to Contributor Plus for review of internal employee PR - @rushatgabhane ( |
Could you assign me to this @grgia ? 😄 |
I think the hold is valid here. But we can start building out the component in #22874 |
@rushatgabhane, @pac-guerreiro Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Lucas from Callstack. Working on that one. |
@rushatgabhane, @pac-guerreiro 10 days overdue. I'm getting more depressed than Marvin. |
@rushatgabhane, @lukemorawski Eep! 4 days overdue now. Issues have feelings too... |
@rushatgabhane, @lukemorawski Still overdue 6 days?! Let's take care of this! |
@rushatgabhane, @lukemorawski 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it! |
@rushatgabhane, @lukemorawski 12 days overdue. Walking. Toward. The. Light... |
In progress |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.91-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-11-02. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
|
Triggered auto assignment to @jliexpensify ( |
This comment was marked as off-topic.
This comment was marked as off-topic.
@jliexpensify would you please ensure that @rushatgabhane received C+ review payment for #29017 |
Payment Summary
|
@grgia there's no payment on my end (J.Mills will use the summary above to pay Rushat). Feel free to close this GH if it's done! |
request here - https://staging.new.expensify.com/r/8726366235397545 |
$500 payment approved for @rushatgabhane based on this comment. |
@grgia @joekaufmanexpensify payment for Rushat has been approved, can we close this GH? (sorry I got assigned just to handle payment so am unsure if anything else needs to be done here) |
Yep, this one should be all set! |
HOLD ON #22874 #22876 #22877
Design Doc Section
https://docs.google.com/document/d/1rFxJ78vz5On6zSWzYa51B9v-tyLdC5pUsBeLOLig0t4/edit#bookmark=id.5n1jn0riblut
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: