Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-11-02] [ECARD] CRITICAL: Settings - Add API Calls when clicking “Reveal details” buttons. #22875

Closed
grgia opened this issue Jul 14, 2023 · 31 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 ECard Wave5-free-submitters Internal Requires API changes or must be handled by Expensify staff

Comments

@grgia
Copy link
Contributor

grgia commented Jul 14, 2023

HOLD ON #22874 #22876 #22877

Design Doc Section

https://docs.google.com/document/d/1rFxJ78vz5On6zSWzYa51B9v-tyLdC5pUsBeLOLig0t4/edit#bookmark=id.5n1jn0riblut

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01bd97f7877e21ceed
  • Upwork Job ID: 1679790846718205952
  • Last Price Increase: 2023-07-14
@grgia grgia added the Internal Requires API changes or must be handled by Expensify staff label Jul 14, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 14, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01bd97f7877e21ceed

@melvin-bot
Copy link

melvin-bot bot commented Jul 14, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @rushatgabhane (Internal)

@grgia
Copy link
Contributor Author

grgia commented Aug 31, 2023

cc @pac-guerreiro

@melvin-bot melvin-bot bot added the Overdue label Aug 31, 2023
@pac-guerreiro
Copy link
Contributor

Could you assign me to this @grgia ? 😄

@marcaaron marcaaron added Daily KSv2 and removed Monthly KSv2 labels Aug 31, 2023
@melvin-bot melvin-bot bot removed the Overdue label Aug 31, 2023
@marcaaron
Copy link
Contributor

I think the hold is valid here. But we can start building out the component in #22874

@melvin-bot
Copy link

melvin-bot bot commented Sep 4, 2023

@rushatgabhane, @pac-guerreiro Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Sep 4, 2023
@grgia grgia changed the title [HOLD #22874][ECard Settings] - Add “Reveal details” button. Conditionally render Digital card details. [HOLD #22874][ECard Settings] - Add API Calls when clicking “Reveal details” buttons. Sep 5, 2023
@grgia grgia changed the title [HOLD #22874][ECard Settings] - Add API Calls when clicking “Reveal details” buttons. [HOLD #22874, #26776, #26777][ECard Settings] - Add API Calls when clicking “Reveal details” buttons. Sep 5, 2023
@lukemorawski
Copy link
Contributor

Lucas from Callstack. Working on that one.

@melvin-bot
Copy link

melvin-bot bot commented Sep 12, 2023

@rushatgabhane, @pac-guerreiro 10 days overdue. I'm getting more depressed than Marvin.

@melvin-bot
Copy link

melvin-bot bot commented Sep 18, 2023

@rushatgabhane, @lukemorawski Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label Sep 18, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 20, 2023

@rushatgabhane, @lukemorawski Still overdue 6 days?! Let's take care of this!

@melvin-bot
Copy link

melvin-bot bot commented Sep 22, 2023

@rushatgabhane, @lukemorawski 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@melvin-bot
Copy link

melvin-bot bot commented Sep 26, 2023

@rushatgabhane, @lukemorawski 12 days overdue. Walking. Toward. The. Light...

@grgia grgia self-assigned this Sep 27, 2023
@grgia
Copy link
Contributor Author

grgia commented Sep 27, 2023

In progress

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 26, 2023
@melvin-bot melvin-bot bot changed the title [ECard Settings] - Add API Calls when clicking “Reveal details” buttons. [HOLD for payment 2023-11-02] [ECard Settings] - Add API Calls when clicking “Reveal details” buttons. Oct 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 26, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 26, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 26, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.91-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-11-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Nov 2, 2023
@grgia grgia added the Bug Something is broken. Auto assigns a BugZero manager. label Nov 6, 2023
Copy link

melvin-bot bot commented Nov 6, 2023

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot removed the Overdue label Nov 6, 2023

This comment was marked as off-topic.

@grgia
Copy link
Contributor Author

grgia commented Nov 6, 2023

@jliexpensify would you please ensure that @rushatgabhane received C+ review payment for #29017

@dylanexpensify dylanexpensify changed the title [HOLD for payment 2023-11-02] [ECard Settings] - Add API Calls when clicking “Reveal details” buttons. [HOLD for payment 2023-11-02] [ECARD] CRITICAL: Settings - Add API Calls when clicking “Reveal details” buttons. Nov 7, 2023
@dylanexpensify dylanexpensify added the ECard Wave5-free-submitters label Nov 7, 2023
@jliexpensify
Copy link
Contributor

Payment Summary

@jliexpensify
Copy link
Contributor

@grgia there's no payment on my end (J.Mills will use the summary above to pay Rushat). Feel free to close this GH if it's done!

@melvin-bot melvin-bot bot added the Overdue label Nov 10, 2023
@rushatgabhane
Copy link
Member

@melvin-bot melvin-bot bot removed the Overdue label Nov 12, 2023
@JmillsExpensify
Copy link

$500 payment approved for @rushatgabhane based on this comment.

@jliexpensify
Copy link
Contributor

@grgia @joekaufmanexpensify payment for Rushat has been approved, can we close this GH? (sorry I got assigned just to handle payment so am unsure if anything else needs to be done here)

@joekaufmanexpensify
Copy link
Contributor

Yep, this one should be all set!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 ECard Wave5-free-submitters Internal Requires API changes or must be handled by Expensify staff
Projects
No open projects
Development

No branches or pull requests

9 participants