[Awaiting Sibtain payment] [HOLD for payment 2023-09-12] [$500] When Distance Request Tab is tapped, all waypoints are lost

[hayata-suenaga]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to a workspace chat
2. "+" button next to text composer -> Request money -> Distance request
3. "Start" -> type and choose an address (this creates one waypoint)
4. Click "Distance request" tab again

Expected Result:

The start waypoint should remain the same

Actual Result:

The start waypoint is cleared

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.62-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @b4s36t4
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693685299726929

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b0d78086aa76dc15
• Upwork Job ID: 1698069080541106176
• Last Price Increase: 2023-09-02

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b0d78086aa76dc15

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @flaviadefaria (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tapping on the distance request resets the tab.

What is the root cause of that problem?

We're calling the onPress handler here without checking if the tab being pressed is currently focused.

What changes do you think we should make in order to solve the problem?

We can trigger the onPress handler here only if isFocused is false. I don't see any reason for triggering rest of the function code if isFocused is true, so maybe we can also prevent the execution of whole function code if isFocused is true.

If we want to trigger the onPress handler but not reset the state, then we can also do this by adding the following condition here:

if (props.selectedTab === routeName) return;

Note that routeName is passed to the onTabPress handler here by the TabSelector component.

What alternative solutions did you explore? (Optional)

We can also remove this altogether if the purpose of this bug report is that we should not reset the request when any tab is clicked.

[hayata-suenaga]

What alternative solutions did you explore? (Optional)
We can also remove this altogether if the purpose of this bug report is that we should not reset the request when any tab is clicked.

We still want to reset the money request information because we are sharing the data for a draft money request. If we don't clear the data when a different tab/request type is selected, draft data from the previous type might be included in the new money request.

so maybe we can also prevent the execution of whole function code if isFocused is true.

I agree let's try this approach 💯

[melvin-bot]

📣 @allroundexperts Please request via NewDot manual requests for the Contributor role ($500)

[hayata-suenaga]

@allroundexperts looking forward for your PR 😄

[allroundexperts]

PR created #26584 @hayata-suenaga

[b4s36t4]

Missed this 🙂🥲

[hayata-suenaga]

@trjExpensify @allroundexperts is a C+ and they made the PR
@situchan is also a C+ and they reviewed the PR

[trjExpensify]

Cool, assigning @situchan on the issue as well for tracking.

[b4s36t4]

I have reported this issue. @hayata-suenaga

[hayata-suenaga]

@b4s36t4 yep you did

[b4s36t4]

Thanks so much Hayata. 🙌

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.63-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: do not reset the state if same tab is clicked #26584

If no regressions arise, payment will be issued on 2023-09-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @allroundexperts does not require payment (Eligible for Manual Requests)
• @situchan requires payment
• @b4s36t4 requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts / @situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts / @situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts / @situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts / @situchan] Determine if we should create a regression test for this bug.
• [@allroundexperts / @situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[trjExpensify]

👋 Can we get the checklist filled out please?

[trjExpensify]

Confirming those payments due as follows, correct?

• $50 to @b4s36t4 for the bug report
• $750 to @allroundexperts for the fix + #urgency bonus (to be paid via NewDot)
• $750 to @situchan for the C+ review + #urgency bonus

[situchan]

No regression. Same tab press action was not prevented during first implementation of tab navigator.

Regression Test Proposal

1. Open FAB > Request money
2. Click Distance tab
3. Enter start and finish address
4. Click again Distance tab
5. Verify that entered addresses are not cleared

[trjExpensify]

Cool, thanks! I don't think we need to check for this one on every regression run, so I'm going to hold off on that test.

Offers sent on this job.

[allroundexperts]

Cool, thanks! I don't think we need to check for this one on every regression run, so I'm going to hold off on that test.

Offers sent on this job.

@trjExpensify I get paid through the App. I think the payment summary is not correct. Shouldn't it be 750 instead?

[trjExpensify]

@trjExpensify I get paid through the App.

Ah of course, I forgot you did. I can retract your offer no worries.

Shouldn't it be 750 instead?

Ah yes, it's 50% bonus. That's cool. I sent offers for the bounty price of $500 and then I add the bonus once accepted anyway. Modified the above though!

[trjExpensify]

okay, just awaiting your payment now @allroundexperts!

[allroundexperts]

Requested the payment on ND!

[trjExpensify]

Cool, let's close it out!

[JmillsExpensify]

$750 payment approved for @allroundexperts based on BZ summary.