[$500] [Distance] - Start and Finish data does not remain when user change to Manual/Scan #26716

lanitochka17 · 2023-09-04T19:51:17Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Issue found when executing PR #26622

Action Performed:

Open New Expensify app
Tap FAB button
Tap Request money
Tap Distance
Enter Start address
Enter Finish address
Navigate to Scan/Manual tab
Turn back to Distance tab

Expected Result:

Entered Start and Finish data should remain when user change to Manual/Scan

Actual Result:

Start and Finish data does not remain when user change to Manual/Scan

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.63-0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6188324_az_recorder_20230904_204906.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~013db7c954b21603ab
Upwork Job ID: 1698830860091473920
Last Price Increase: 2023-09-04

melvin-bot · 2023-09-04T19:51:22Z

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-09-04T19:51:24Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot · 2023-09-04T22:50:16Z

Job added to Upwork: https://www.upwork.com/jobs/~013db7c954b21603ab

adelekennedy · 2023-09-04T22:50:17Z

reproduced!

melvin-bot · 2023-09-04T22:50:19Z

Current assignee @adelekennedy is eligible for the External assigner, not assigning anyone new.

melvin-bot · 2023-09-04T22:50:25Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

DylanDylann · 2023-09-05T03:28:22Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance - Start and Finish data does not remain when user change to Manual/Scan

What is the root cause of that problem?

After selecting the location (start and finish) we save it in ONYX in the transcation_{transactionID} field. But when selecting another tab we reset the field

App/src/pages/iou/MoneyRequestSelectorPage.js

Line 66 in f67bf9f

IOU.resetMoneyRequestInfo(moneyRequestID);

It causes that the transactionID field in iou will be empty. Then, when coming back the new transaction will be created

App/src/pages/iou/DistanceRequestPage.js

Lines 48 to 53 in f67bf9f

    
           useEffect(() => { 
        
               if (iou.transactionID) { 
        
                   return; 
        
               } 
        
               IOU.createEmptyTransaction(); 
        
           }, [iou.transactionID]);

The old transaction with the old value will not be used anymore

What changes do you think we should make in order to solve the problem?

When selecting another request tab, we should keep transactionID in iou field. So that, the new transaction will be not created by this logic

App/src/pages/iou/DistanceRequestPage.js

Lines 48 to 53 in f67bf9f

    
           useEffect(() => { 
        
               if (iou.transactionID) { 
        
                   return; 
        
               } 
        
               IOU.createEmptyTransaction(); 
        
           }, [iou.transactionID]);

To do that, in resetMoneyRequestInfo function we can define transactionID param with the default value is ''.
And in here

App/src/pages/iou/MoneyRequestSelectorPage.js

Line 66 in f67bf9f

IOU.resetMoneyRequestInfo(moneyRequestID);

we pass transactionID to this fucntion

        IOU.resetMoneyRequestInfo(moneyRequestID, lodashGet(props.iou, 'transactionID', ''));

What alternative solutions did you explore? (Optional)

We can create a new field on ONYX called draftTransaction to save the location that the user selects.

App/src/pages/iou/WaypointEditor.js

Line 156 in f67bf9f

Transaction.saveWaypoint(transactionID, waypointIndex, waypoint);

Here we will save to draftTransaction instead of transactions_{transactionID}, we only save to transactions_{transactionID} when the user clicks the Next button. This is the way we did in task page

tienifr · 2023-09-05T03:38:03Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance - Start and Finish data does not remain when user change to Manual/Scan

What is the root cause of that problem?

In

App/src/pages/iou/MoneyRequestSelectorPage.js

Lines 64 to 67 in f67bf9f

    
           const resetMoneyRequestInfo = () => { 
        
               const moneyRequestID = `${iouType}${reportID}`; 
        
               IOU.resetMoneyRequestInfo(moneyRequestID); 
        
           };

We have the logic to reset request info when users change page. Unfortunately, we don't have the logic to check shouldReset as what we did in other pages like MoneyRequestMerchantPage,...

What changes do you think we should make in order to solve the problem?

add logic check shouldReset in resetMoneyRequestInfo function like below

    const resetMoneyRequestInfo = () => {
        const moneyRequestID = `${iouType}${reportID}`;
        const shouldReset = props.iou.id !== moneyRequestID;
        if(shouldReset){
            IOU.resetMoneyRequestInfo(moneyRequestID);
        }
    };

DylanDylann · 2023-09-05T03:42:39Z

updated proposal: Adding alternative solution

studentofcoding · 2023-09-05T06:01:52Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance - Start and Finish data does not remain when user change to Manual/Scan

What is the root cause of that problem?

We reset the Request Info in resetMoneyRequestInfo, but did not give the condition to check if the current tab is the same as the new tab or not run & resetMoneyRequestInfo based on that condition

App/src/pages/iou/MoneyRequestSelectorPage.js

Lines 64 to 67 in f67bf9f

    
           const resetMoneyRequestInfo = () => { 
        
               const moneyRequestID = `${iouType}${reportID}`; 
        
               IOU.resetMoneyRequestInfo(moneyRequestID); 
        
           };

What changes do you think we should make in order to solve the problem?

Both the solution of @tienifr and @DylanDylann is similar, but will not satisfy the Expected behavior & we didn't really need to add and track props.iou.

I also imagine that we only want this behaviour on Distance, and the value will reset on others Tab, therefore what we should do instead, is handle it simply via condition on resetMoneyRequestInfo & onTabPress

resetMoneyRequestInfo

const resetMoneyRequestInfo = (currentTab) => {
        if (currentTab === CONST.TAB.DISTANCE) {
            return;
        }
    
        const moneyRequestID = `${iouType}${reportID}`;
        IOU.resetMoneyRequestInfo(moneyRequestID);
};

onTabPress

<TabSelector
          state={state}
           navigation={navigation}
           onTabPress={(newTab) => {
                   if (props.selectedTab !== newTab) {
                           return;
                   }
                   resetMoneyRequestInfo(newTab);
            }
            position={position}
/>

Result

tab_changes.mp4

cc: @narefyev91 @adelekennedy

narefyev91 · 2023-09-05T07:20:29Z

@adelekennedy are we sure that we should keep values? We have 3 options to request money - either manually or scan or distance - navigating between tabs - means that user should not expect saving redundant information. Maybe i'm wrong but needs to clarify

joh42 · 2023-09-05T09:47:59Z

~~I also thought this was expected behavior when I encountered it~~ Actually since the amount persists on the manual tab, the expected behavior might be saving the waypoints

studentofcoding · 2023-09-05T10:06:17Z

I can imagine that the user would benefit from keeping the waypoint value (in case let say they inputted 5 points, and accidently switch from Distance to another tab)

In case on another tab, its make sense to keep the reselt to default behaviour as it's a one item (time) input

Additional note: In my proposal, I've laid out the details on those 2 conditions

@narefyev91 @adelekennedy

narefyev91 · 2023-09-05T10:14:12Z

~~I also thought this was expected behavior when I encountered it~~ Actually since the amount persists on the manual tab, the expected behavior might be saving the waypoints

Amount exists only if you not do any interaction on other tabs - for example choosing start/end on distance tab will reset amount of manual. We need to have correct understanding how it should be working @adelekennedy

situchan · 2023-09-05T17:25:21Z

This is intentional - #26579 (comment)

adelekennedy · 2023-09-05T17:35:35Z

Let's close - looking back at this I hit external too soon without covering expected behavior

lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 4, 2023

melvin-bot bot assigned adelekennedy Sep 4, 2023

adelekennedy added the External Added to denote the issue can be worked on by a contributor label Sep 4, 2023

melvin-bot bot changed the title ~~Distance - Start and Finish data does not remain when user change to Manual/Scan~~ [$500] Distance - Start and Finish data does not remain when user change to Manual/Scan Sep 4, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 4, 2023

melvin-bot bot assigned narefyev91 Sep 4, 2023

lanitochka17 changed the title ~~[$500] Distance - Start and Finish data does not remain when user change to Manual/Scan~~ [$500] [Distance] - Start and Finish data does not remain when user change to Manual/Scan Sep 5, 2023

adelekennedy closed this as completed Sep 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[$500] [Distance] - Start and Finish data does not remain when user change to Manual/Scan #26716

[$500] [Distance] - Start and Finish data does not remain when user change to Manual/Scan #26716

lanitochka17 commented Sep 4, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Sep 4, 2023

melvin-bot bot commented Sep 4, 2023

melvin-bot bot commented Sep 4, 2023

adelekennedy commented Sep 4, 2023

melvin-bot bot commented Sep 4, 2023

melvin-bot bot commented Sep 4, 2023

DylanDylann commented Sep 5, 2023 •

edited

Loading

tienifr commented Sep 5, 2023 •

edited

Loading

DylanDylann commented Sep 5, 2023

studentofcoding commented Sep 5, 2023 •

edited

Loading

narefyev91 commented Sep 5, 2023

joh42 commented Sep 5, 2023 •

edited

Loading

studentofcoding commented Sep 5, 2023

narefyev91 commented Sep 5, 2023

situchan commented Sep 5, 2023

adelekennedy commented Sep 5, 2023

[$500] [Distance] - Start and Finish data does not remain when user change to Manual/Scan #26716

[$500] [Distance] - Start and Finish data does not remain when user change to Manual/Scan #26716

Comments

lanitochka17 commented Sep 4, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Sep 4, 2023

melvin-bot bot commented Sep 4, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot bot commented Sep 4, 2023

adelekennedy commented Sep 4, 2023

melvin-bot bot commented Sep 4, 2023

melvin-bot bot commented Sep 4, 2023

DylanDylann commented Sep 5, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

tienifr commented Sep 5, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

DylanDylann commented Sep 5, 2023

studentofcoding commented Sep 5, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Result

narefyev91 commented Sep 5, 2023

joh42 commented Sep 5, 2023 • edited Loading

studentofcoding commented Sep 5, 2023

narefyev91 commented Sep 5, 2023

situchan commented Sep 5, 2023

adelekennedy commented Sep 5, 2023

lanitochka17 commented Sep 4, 2023 •

edited by melvin-bot bot

Loading

DylanDylann commented Sep 5, 2023 •

edited

Loading

tienifr commented Sep 5, 2023 •

edited

Loading

studentofcoding commented Sep 5, 2023 •

edited

Loading

joh42 commented Sep 5, 2023 •

edited

Loading