[HOLD for payment 2023-10-09] [$500] Request money - Scan - Choose file container is pressable

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open any report
2. Request money and select scan section
3. Press around choose file

Expected Result:

The container should not be pressable.

Actual Result:

Choose file container is pressable

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.65.6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Monosnap.screencast.2023-09-03.19-56-06.mp4

Recording.4324.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Krishna2323
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693751505390489

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0152d45357c33d904a
• Upwork Job ID: 1702227989073571840
• Last Price Increase: 2023-09-21
• Automatic offers:
• hoangzinh | Reviewer | 26879451
• namhihi237 | Contributor | 26879453
• Krishna2323 | Reporter | 26879455

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Choose file container is pressable

What is the root cause of that problem?

1. We added padding 36px to the style of the Choose File button in here

App/src/pages/iou/ReceiptSelector/index.js

Line 122 in db1a306

style={[styles.p9]}

2. The same behavior happens in mobile native when asking for permission to scan the file

App/src/pages/iou/ReceiptSelector/index.native.js

Line 230 in db1a306

style={[styles.p9, styles.pt5]}

What changes do you think we should make in order to solve the problem?

Instead of adding style to the button itself, we should move the styles.p9 to the PressableWithFeedback component by passing wrapperStyle

wrapperStyle={[styles.p9]}

What alternative solutions did you explore? (Optional)

Result

• Web

Screen.Recording.2023-09-07.at.17.06.55.mov

• Mobile

Screen.Recording.2023-09-07.at.16.02.34.mov

[namhihi237]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The cursor shouldn't be displayed as a cursor around the chosen file

What is the root cause of that problem?

We are wrapping Button with PressableWithFeedback and Button has style styles.p9 so we have around button 36px which will be clickable but no action happening here.

App/src/pages/iou/ReceiptSelector/index.js

Lines 114 to 122 in d2bdaec

	<PressableWithFeedback
	accessibilityLabel={translate('receipt.chooseFile')}
	accessibilityRole={CONST.ACCESSIBILITY_ROLE.BUTTON}
	>
	<Button
	medium
	success
	text={translate('receipt.chooseFile')}
	style={[styles.p9]}

What changes do you think we should make in order to solve the problem?

We can remove PressableWithFeedback and just use Button (move prop into Button)

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[ahmedGaber93]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Choose file container is pressable

What is the root cause of that problem?

The root cause is the button has style style={[styles.p9]} and is wrapped with PressableWithFeedback has pointer cursor.

App/src/pages/iou/ReceiptSelector/index.js

Lines 114 to 131 in edab657

	<PressableWithFeedback
	accessibilityLabel={translate('receipt.chooseFile')}
	accessibilityRole={CONST.ACCESSIBILITY_ROLE.BUTTON}
	>
	<Button
	medium
	success
	text={translate('receipt.chooseFile')}
	style={[styles.p9]}
	onPress={() => {
	openPicker({
	onPicked: (file) => {
	setReceiptAndNavigate(file, props.iou, props.report);
	},
	});
	}}
	/>
	</PressableWithFeedback>

What changes do you think we should make in order to solve the problem?

1. remove the wrapper PressableWithFeedback.
2. use PressableWithFeedback inside the Button to handle the accessibility by pass accessibilityLabel={translate('receipt.chooseFile')} in a Button prop.
3. inside Button > PressableWithFeedback add new static prop accessibilityRole={CONST.ACCESSIBILITY_ROLE.BUTTON} or we can create it as Button prop and pass it to PressableWithFeedback

What alternative solutions did you explore? (Optional)

we can instead remove the style style={[styles.p9]} from Button and add it as margin style={[styles.m9]} to the wrapper PressableWithFeedback

[kbecciv]

Proposal by: @Krishna2323
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693751505390489

Proposal

Please re-state the problem that we are trying to solve in this issue.

Choose file container is pressable

What is the root cause of that problem?

We are adding padding of '36px' on the button which is a child of PressableWithFeedback thats why we are getting the press effect around the button.

App/src/pages/iou/ReceiptSelector/index.js

Lines 114 to 131 in 2bce7f9

	<PressableWithFeedback
	accessibilityLabel={translate('receipt.chooseFile')}
	accessibilityRole={CONST.ACCESSIBILITY_ROLE.BUTTON}
	>
	<Button
	medium
	success
	text={translate('receipt.chooseFile')}
	style={[styles.p9]}
	onPress={() => {
	openPicker({
	onPicked: (file) => {
	setReceiptAndNavigate(file, props.iou, props.report);
	},
	});
	}}
	/>
	</PressableWithFeedback>

What changes do you think we should make in order to solve the problem?

Remove padding from button & add it to PressableWithFeedback.
Result:

[saisixthblock]

Please re-state the problem that we are trying to solve in this issue.
Choose file container is pressable

What is the root cause of that problem?

We added style with 30 px padding property, Thats why button surrounding area became pressable.

What changes do you think we should make in order to solve the problem?
To clear this we need to replace style with wrapperStyle to the button component

[melvin-bot]

📣 @saisixthblock! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@mallenexpensify Eep! 4 days overdue now. Issues have feelings too...

[mallenexpensify]

Sorry it took a min to get to this.
@Krishna2323 to make sure I fully understand

The container should not be pressable.

means that only the green Choose File button should be clickable and not the rectangle area outside of the button, right? I'm going to assume so and make this External. Also adding design for bonus 👀 in case there's a design-related detail I'm unaware of (this seems pretty straight forward though)

[Krishna2323]

@mallenexpensify yes.

[melvin-bot]

Triggered auto assignment to @shawnborton (Design), see these Stack Overflow questions for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0152d45357c33d904a

[melvin-bot]

Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[shawnborton]

Nice, this proposal here makes sense to me.

[melvin-bot]

🎯 ⚡️ Woah @hoangzinh / @namhihi237, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @namhihi237 got assigned: 2023-09-26 08:47:37 Z
• when the PR got merged: 2023-09-27 03:01:35 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• remove PressableWithFeedback wrap button choose file and give permission #28245

If no regressions arise, payment will be issued on 2023-10-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment offer (Reviewer)
• @namhihi237 requires payment offer (Contributor)
• @Krishna2323 requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@hoangzinh] The PR that introduced the bug has been identified. Link to the PR:
• [@hoangzinh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@hoangzinh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@hoangzinh] Determine if we should create a regression test for this bug.
• [@hoangzinh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

@shawnborton, @dangrous, @hoangzinh, @mallenexpensify, @namhihi237 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[hoangzinh]

BugZero Checklist:

• The PR that introduced the bug has been identified. Link to the PR: Add ability to Take/Upload Receipts #23046
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/23046/files#r1357060177
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug: ❌ No I think it's just an UI improvement.

[melvin-bot]

@shawnborton, @dangrous, @hoangzinh, @mallenexpensify, @namhihi237 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[shawnborton]

What's left for this one?

[hoangzinh]

@shawnborton I think the payout.

[mallenexpensify]

Issue reporter: @Krishna2323 paid $50 via Upwork
Contributor: @namhihi237 paid $750 via Upwork, inc. urgency bonus
Contributor+: @hoangzinh paid $750 via Upwork, inc. urgency bonus

Thanks all!